github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2025-01-27 00:44:18 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #164 from overleaf/bg-fix-buffer-deprecations

Browse source 
fix deprecated usage of Buffer constructor
This commit is contained in:
Henry Oswald 2020-05-19 10:26:56 +01:00 committed by GitHub
commit 2547725f35
3 changed files with 5 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
services/clsi/app/js/OutputFileOptimiser.js
View file

@ -45,8 +45,7 @@ module.exports = OutputFileOptimiser = {
checkIfPDFIsOptimised(file, callback) {
const SIZE = 16 * 1024 // check the header of the pdf
const result = new Buffer(SIZE)
result.fill(0) // prevent leakage of uninitialised buffer
const result = Buffer.alloc(SIZE) // fills with zeroes by default
return fs.open(file, 'r', function(err, fd) {
if (err != null) {
return callback(err)

2
services/clsi/app/js/SafeReader.js
View file

@ -43,7 +43,7 @@ module.exports = SafeReader = {
}
return callback(null, ...Array.from(result))
})
const buff = new Buffer(size, 0) // fill with zeros
const buff = Buffer.alloc(size) // fills with zeroes by default
return fs.read(fd, buff, 0, buff.length, 0, function(
err,
bytesRead,

6
services/clsi/test/unit/js/OutputFileOptimiserTests.js
View file

@ -124,7 +124,7 @@ describe('OutputFileOptimiser', function() {
this.fs.read = sinon
.stub()
.withArgs(this.fd)
.yields(null, 100, new Buffer('hello /Linearized 1'))
.yields(null, 100, Buffer.from('hello /Linearized 1'))
this.fs.close = sinon
.stub()
.withArgs(this.fd)
@ -140,7 +140,7 @@ describe('OutputFileOptimiser', function() {
this.fs.read = sinon
.stub()
.withArgs(this.fd)
.yields(null, 100, new Buffer('hello /Linearized 1'))
.yields(null, 100, Buffer.from('hello /Linearized 1'))
return this.OutputFileOptimiser.checkIfPDFIsOptimised(
this.src,
this.callback
@ -169,7 +169,7 @@ describe('OutputFileOptimiser', function() {
this.fs.read = sinon
.stub()
.withArgs(this.fd)
.yields(null, 100, new Buffer('hello not linearized 1'))
.yields(null, 100, Buffer.from('hello not linearized 1'))
return this.OutputFileOptimiser.checkIfPDFIsOptimised(
this.src,
this.callback