From 2453e55ebb4b7df68f68922ee6ef0945ddc31d67 Mon Sep 17 00:00:00 2001
From: Alasdair Smith <ali@alasdairsmith.co.uk>
Date: Fri, 2 Mar 2018 16:06:48 +0000
Subject: [PATCH] Remove eslint loader

After using the webpack set up a bit more, having linting block compiles in
dev is more annoying than helpful. Linting pre commit is more valuable
---
 services/web/.eslintrc           |  2 +-
 services/web/npm-shrinkwrap.json | 64 --------------------------------
 services/web/package.json        |  1 -
 services/web/webpack.config.js   |  7 ----
 4 files changed, 1 insertion(+), 73 deletions(-)

diff --git a/services/web/.eslintrc b/services/web/.eslintrc
index 01107abc0c..aab3a10f54 100644
--- a/services/web/.eslintrc
+++ b/services/web/.eslintrc
@@ -23,4 +23,4 @@
     "no-unused-expressions": 0,
     "chai-friendly/no-unused-expressions": "error"
   }
-}
\ No newline at end of file
+}
diff --git a/services/web/npm-shrinkwrap.json b/services/web/npm-shrinkwrap.json
index 2b7714dd4e..2971ad2b50 100644
--- a/services/web/npm-shrinkwrap.json
+++ b/services/web/npm-shrinkwrap.json
@@ -2923,32 +2923,6 @@
         }
       }
     },
-    "eslint-loader": {
-      "version": "1.9.0",
-      "from": "eslint-loader@>=1.9.0 <2.0.0",
-      "resolved": "https://registry.npmjs.org/eslint-loader/-/eslint-loader-1.9.0.tgz",
-      "dev": true,
-      "dependencies": {
-        "glob": {
-          "version": "7.1.2",
-          "from": "glob@^7.0.5",
-          "resolved": "https://registry.npmjs.org/glob/-/glob-7.1.2.tgz",
-          "dev": true
-        },
-        "minimatch": {
-          "version": "3.0.4",
-          "from": "minimatch@^3.0.4",
-          "resolved": "https://registry.npmjs.org/minimatch/-/minimatch-3.0.4.tgz",
-          "dev": true
-        },
-        "rimraf": {
-          "version": "2.6.2",
-          "from": "rimraf@^2.6.1",
-          "resolved": "https://registry.npmjs.org/rimraf/-/rimraf-2.6.2.tgz",
-          "dev": true
-        }
-      }
-    },
     "eslint-module-utils": {
       "version": "2.1.1",
       "from": "eslint-module-utils@>=2.1.1 <3.0.0",
@@ -6950,38 +6924,6 @@
         }
       }
     },
-    "loader-fs-cache": {
-      "version": "1.0.1",
-      "from": "loader-fs-cache@>=1.0.0 <2.0.0",
-      "resolved": "https://registry.npmjs.org/loader-fs-cache/-/loader-fs-cache-1.0.1.tgz",
-      "dev": true,
-      "dependencies": {
-        "find-cache-dir": {
-          "version": "0.1.1",
-          "from": "find-cache-dir@>=0.1.1 <0.2.0",
-          "resolved": "https://registry.npmjs.org/find-cache-dir/-/find-cache-dir-0.1.1.tgz",
-          "dev": true
-        },
-        "find-up": {
-          "version": "1.1.2",
-          "from": "find-up@>=1.0.0 <2.0.0",
-          "resolved": "https://registry.npmjs.org/find-up/-/find-up-1.1.2.tgz",
-          "dev": true
-        },
-        "path-exists": {
-          "version": "2.1.0",
-          "from": "path-exists@>=2.0.0 <3.0.0",
-          "resolved": "https://registry.npmjs.org/path-exists/-/path-exists-2.1.0.tgz",
-          "dev": true
-        },
-        "pkg-dir": {
-          "version": "1.0.0",
-          "from": "pkg-dir@>=1.0.0 <2.0.0",
-          "resolved": "https://registry.npmjs.org/pkg-dir/-/pkg-dir-1.0.0.tgz",
-          "dev": true
-        }
-      }
-    },
     "loader-runner": {
       "version": "2.3.0",
       "from": "loader-runner@>=2.3.0 <3.0.0",
@@ -8745,12 +8687,6 @@
         }
       }
     },
-    "object-hash": {
-      "version": "1.2.0",
-      "from": "object-hash@>=1.1.4 <2.0.0",
-      "resolved": "https://registry.npmjs.org/object-hash/-/object-hash-1.2.0.tgz",
-      "dev": true
-    },
     "object-keys": {
       "version": "1.0.11",
       "from": "object-keys@>=1.0.8 <2.0.0",
diff --git a/services/web/package.json b/services/web/package.json
index 485450807d..75b83e6ac6 100644
--- a/services/web/package.json
+++ b/services/web/package.json
@@ -102,7 +102,6 @@
     "es6-promise": "^4.0.5",
     "eslint": "^4.18.1",
     "eslint-config-standard": "^11.0.0",
-    "eslint-loader": "^1.9.0",
     "eslint-plugin-chai-expect": "^1.1.1",
     "eslint-plugin-chai-friendly": "^0.4.1",
     "eslint-plugin-import": "^2.9.0",
diff --git a/services/web/webpack.config.js b/services/web/webpack.config.js
index 7210a27488..09a4abd05b 100644
--- a/services/web/webpack.config.js
+++ b/services/web/webpack.config.js
@@ -31,13 +31,6 @@ module.exports = {
 	// Define how file types are handled by webpack
 	module: {
 		rules: [{
-			// Ensure eslint is run before compilation with babel
-			enforce: 'pre',
-			test: /\.js$/,
-			// Only compile application files (dependencies are in ES5 already)
-			exclude: /node_modules/,
-			loader: 'eslint-loader'
-		}, {
 			// Pass application JS files through babel-loader, compiling to ES5
 			test: /\.js$/,
 			// Only compile application files (dependencies are in ES5 already)