github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-07 20:31:06 -05:00
Code Issues Projects Releases Packages Wiki Activity

add metric for RoomEvents listeners

Browse source
This commit is contained in:
Brian Gough 2019-07-24 16:25:45 +01:00
parent 277ec71a5b
commit 22d722f3e8
2 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
services/real-time/app/coffee/RoomManager.coffee
View file

@ -1,4 +1,5 @@
logger = require 'logger-sharelatex' logger = require 'logger-sharelatex'
metrics = require "metrics-sharelatex"
{EventEmitter} = require 'events' {EventEmitter} = require 'events'
IdMap = new Map() # keep track of whether ids are from projects or docs IdMap = new Map() # keep track of whether ids are from projects or docs
@ -55,6 +56,8 @@ module.exports = RoomManager =
callback(err) callback(err)
RoomEvents.emit "#{entity}-active", id RoomEvents.emit "#{entity}-active", id
IdMap.set(id, entity) IdMap.set(id, entity)
# keep track of the number of listeners
metrics.gauge "room-listeners", RoomEvents.eventNames().length
else else
logger.log {client: client.id, entity, id, beforeCount}, "client joined existing room" logger.log {client: client.id, entity, id, beforeCount}, "client joined existing room"
client.join id client.join id
@ -72,6 +75,7 @@ module.exports = RoomManager =
logger.log {entity, id}, "room is now empty" logger.log {entity, id}, "room is now empty"
RoomEvents.emit "#{entity}-empty", id RoomEvents.emit "#{entity}-empty", id
IdMap.delete(id) IdMap.delete(id)
metrics.gauge "room-listeners", RoomEvents.eventNames().length
# internal functions below, these access socket.io rooms data directly and # internal functions below, these access socket.io rooms data directly and
# will need updating for socket.io v2 # will need updating for socket.io v2

1
services/real-time/test/unit/coffee/RoomManagerTests.coffee
View file

@ -13,6 +13,7 @@ describe 'RoomManager', ->
@RoomManager = SandboxedModule.require modulePath, requires: @RoomManager = SandboxedModule.require modulePath, requires:
"settings-sharelatex": @settings = {} "settings-sharelatex": @settings = {}
"logger-sharelatex": @logger = { log: sinon.stub(), error: sinon.stub() } "logger-sharelatex": @logger = { log: sinon.stub(), error: sinon.stub() }
"metrics-sharelatex": @metrics = { gauge: sinon.stub() }
@RoomManager._clientsInRoom = sinon.stub() @RoomManager._clientsInRoom = sinon.stub()
@RoomEvents = @RoomManager.eventSource() @RoomEvents = @RoomManager.eventSource()
sinon.spy(@RoomEvents, 'emit') sinon.spy(@RoomEvents, 'emit')