From 1fca37af61fdcf78220c97a59383e9ababd12792 Mon Sep 17 00:00:00 2001
From: Jakob Ackermann <jakob.ackermann@overleaf.com>
Date: Wed, 20 Nov 2024 15:20:00 +0100
Subject: [PATCH] Merge pull request #22016 from overleaf/jpa-fix-flaky-test

[history-v1] back_fill_file_hash: fix typo in tests and add comments

GitOrigin-RevId: a4055d7dd33ba584a2a86053470585f412392305
---
 .../acceptance/js/storage/back_fill_file_hash.test.mjs     | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/services/history-v1/test/acceptance/js/storage/back_fill_file_hash.test.mjs b/services/history-v1/test/acceptance/js/storage/back_fill_file_hash.test.mjs
index dcd4434b85..b7f05738ff 100644
--- a/services/history-v1/test/acceptance/js/storage/back_fill_file_hash.test.mjs
+++ b/services/history-v1/test/acceptance/js/storage/back_fill_file_hash.test.mjs
@@ -1020,8 +1020,11 @@ describe('back_fill_file_hash script', function () {
       filesRetries: 0,
       readFromGCSCount: 0,
     })
-    expect(stats.filesRetries).to.be.greaterThan(0)
-    expect(stats.filesRetries).to.be.greaterThan(STATS_ALL.readFromGCSCount)
+    expect(stats.filesRetries).to.be.greaterThan(0, 'should have retried')
+    expect(stats.readFromGCSCount).to.be.greaterThan(
+      STATS_ALL.readFromGCSCount,
+      'should have read more times from GCS compared to normal operations'
+    )
   })
 
   describe('full run CONCURRENCY=1', function () {