github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-07 20:31:06 -05:00
Code Issues Projects Releases Packages Wiki Activity

If function is called without callback, apply with original args

Browse source
This commit is contained in:
Shane Kilkelly 2017-03-20 16:37:53 +00:00
parent fbe19cd97d
commit 1f77cc0fd3
2 changed files with 12 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
libraries/metrics/test/unit/coffee/timeAsyncMethodTests.coffee
View file

@ -90,8 +90,8 @@ describe 'timeAsyncMethod', ->
describe 'when the wrapped function is not using a callback', ->
beforeEach ->
@testObject.nextNumber = (n) ->
return n+1
@realMethod = sinon.stub().returns(42)
@testObject.nextNumber = @realMethod
it 'should not throw an error', ->
@timeAsyncMethod @testObject, 'nextNumber', 'test.nextNumber'
@ -99,4 +99,11 @@ describe 'timeAsyncMethod', ->
@testObject.nextNumber 2
expect(badCall).to.not.throw(Error)
it 'should call the underlying method', ->
@timeAsyncMethod @testObject, 'nextNumber', 'test.nextNumber'
result = @testObject.nextNumber(12)
expect(@realMethod.callCount).to.equal 1
expect(@realMethod.calledWith(12)).to.equal true
expect(result).to.equal 42

4
libraries/metrics/timeAsyncMethod.coffee
View file

@ -13,7 +13,9 @@ module.exports = (obj, methodName, prefix, logger) ->
[firstArgs..., callback] = originalArgs
if !callback? || typeof callback != 'function'
logger.log "[Metrics] expected wrapped method '#{methodName}' to be invoked with a callback"
if logger?
logger.log "[Metrics] expected wrapped method '#{methodName}' to be invoked with a callback"
return realMethod.apply this, originalArgs
timer = new metrics.Timer(key)