From 1edf1964c821f931f42a0e4da467a5618eac6272 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timoth=C3=A9e=20Alby?= Date: Thu, 14 Mar 2019 10:48:37 -0500 Subject: [PATCH] Merge pull request #1607 from sharelatex/spd-succserror Don't show 'No errors' message if PDF generation fails GitOrigin-RevId: 7ed454b489dcef419c51f48b6c5b3920d5558a79 --- services/web/app/views/project/editor/pdf.pug | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/services/web/app/views/project/editor/pdf.pug b/services/web/app/views/project/editor/pdf.pug index f0d1a11666..ad4b36bbb5 100644 --- a/services/web/app/views/project/editor/pdf.pug +++ b/services/web/app/views/project/editor/pdf.pug @@ -129,7 +129,7 @@ div.full-size.pdf(ng-controller="PdfController") // logs view .pdf-logs(ng-show="shouldShowLogs") - .alert.alert-success(ng-show="pdf.logEntries.all.length == 0") + .alert.alert-success(ng-show="pdf.logEntries.all.length == 0 && !pdf.failure") | #{translate("no_errors_good_job")} .alert.alert-danger(ng-show="pdf.failure")