github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-21 20:47:08 -05:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #15445 from overleaf/jpa-history-v1-gzip-in-place

Browse source 
[history-v1] gzip chunk string in-place before passing to object layer

GitOrigin-RevId: db5ded0b0db32757ed35c31c77d190bc121711a7
This commit is contained in:
Jakob Ackermann 2023-10-25 15:47:02 +02:00 committed by Copybot
parent 0ae174a47b
commit 1dc2bd3a24
2 changed files with 12 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
services/history-v1/storage/lib/history_store.js
View file

@ -103,11 +103,11 @@ HistoryStore.prototype.storeRaw = function historyStoreStoreRaw(
assert.object(rawHistory, 'bad rawHistory') assert.object(rawHistory, 'bad rawHistory')
const key = getKey(projectId, chunkId) const key = getKey(projectId, chunkId)
const stream = streams.gzipStringToStream(JSON.stringify(rawHistory))
logger.debug({ projectId, chunkId }, 'storeRaw started') logger.debug({ projectId, chunkId }, 'storeRaw started')
return BPromise.resolve() return BPromise.resolve()
.then(() => .then(() => streams.gzipStringToStream(JSON.stringify(rawHistory)))
.then(stream =>
persistor.sendStream(BUCKET, key, stream, { persistor.sendStream(BUCKET, key, stream, {
contentType: 'application/json', contentType: 'application/json',
contentEncoding: 'gzip', contentEncoding: 'gzip',

13
services/history-v1/storage/lib/streams.js
View file

@ -79,8 +79,15 @@ function gunzipStreamToBuffer(readStream) {
exports.gunzipStreamToBuffer = gunzipStreamToBuffer exports.gunzipStreamToBuffer = gunzipStreamToBuffer
function gzipStringToStream(string) { function gzipStringToStream(string) {
const gzip = zlib.createGzip() return new BPromise(function (resolve, reject) {
return new ReadableString(string).pipe(gzip) zlib.gzip(Buffer.from(string), function (error, result) {
if (error) {
reject(error)
} else {
resolve(new ReadableString(result))
}
})
})
} }
/** /**
@ -88,6 +95,6 @@ function gzipStringToStream(string) {
* *
* @function * @function
* @param {string} string * @param {string} string
* @return {stream.Writable} * @return {Promise.<stream.Readable>}
*/ */
exports.gzipStringToStream = gzipStringToStream exports.gzipStringToStream = gzipStringToStream