From 1c552cba92e55439506a4716bfd5443553598a80 Mon Sep 17 00:00:00 2001 From: Miguel Serrano Date: Thu, 13 May 2021 12:20:41 +0200 Subject: [PATCH] Merge pull request #4015 from overleaf/msm-fix-chat-button-reset Fixed `resetUnreadMessageCount` used instead of `markMessagesAsRead` GitOrigin-RevId: 8337afd73d8dff570a289e159847a1f6b4fd2fb2 --- .../components/editor-navigation-toolbar-root.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/services/web/frontend/js/features/editor-navigation-toolbar/components/editor-navigation-toolbar-root.js b/services/web/frontend/js/features/editor-navigation-toolbar/components/editor-navigation-toolbar-root.js index 622f9dbb18..82f0c91569 100644 --- a/services/web/frontend/js/features/editor-navigation-toolbar/components/editor-navigation-toolbar-root.js +++ b/services/web/frontend/js/features/editor-navigation-toolbar/components/editor-navigation-toolbar-root.js @@ -26,7 +26,7 @@ const layoutContextPropTypes = { } const chatContextPropTypes = { - resetUnreadMessageCount: PropTypes.func.isRequired, + markMessagesAsRead: PropTypes.func.isRequired, unreadMessageCount: PropTypes.number.isRequired, } @@ -55,16 +55,16 @@ function EditorNavigationToolbarRoot({ pdfLayout, } = useLayoutContext(layoutContextPropTypes) - const { resetUnreadMessageCount, unreadMessageCount } = useChatContext( + const { markMessagesAsRead, unreadMessageCount } = useChatContext( chatContextPropTypes ) const toggleChatOpen = useCallback(() => { if (!chatIsOpen) { - resetUnreadMessageCount() + markMessagesAsRead() } setChatIsOpen(value => !value) - }, [chatIsOpen, setChatIsOpen, resetUnreadMessageCount]) + }, [chatIsOpen, setChatIsOpen, markMessagesAsRead]) const toggleReviewPanelOpen = useCallback( () => setReviewPanelOpen(value => !value),