From 1bcc0a4554358676f0de63826edd52e527bf632b Mon Sep 17 00:00:00 2001 From: James Allen Date: Thu, 19 Jun 2014 13:11:01 +0100 Subject: [PATCH] Send 204 rather than redirect when leaving a project --- .../Features/Collaborators/CollaboratorsController.coffee | 2 +- .../coffee/Collaborators/CollaboratorsControllerTests.coffee | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/services/web/app/coffee/Features/Collaborators/CollaboratorsController.coffee b/services/web/app/coffee/Features/Collaborators/CollaboratorsController.coffee index cbf3d9c04a..db98e411c0 100644 --- a/services/web/app/coffee/Features/Collaborators/CollaboratorsController.coffee +++ b/services/web/app/coffee/Features/Collaborators/CollaboratorsController.coffee @@ -19,7 +19,7 @@ module.exports = CollaboratorsController = return next(new Error("User should be logged in")) CollaboratorsHandler.removeUserFromProject req.params.project_id, user_id, (error) -> return next(error) if error? - res.redirect "/project" + res.send 204 _formatCollaborators: (project, callback = (error, collaborators) ->) -> collaborators = [] diff --git a/services/web/test/UnitTests/coffee/Collaborators/CollaboratorsControllerTests.coffee b/services/web/test/UnitTests/coffee/Collaborators/CollaboratorsControllerTests.coffee index 8460b6b00e..e181c43146 100644 --- a/services/web/test/UnitTests/coffee/Collaborators/CollaboratorsControllerTests.coffee +++ b/services/web/test/UnitTests/coffee/Collaborators/CollaboratorsControllerTests.coffee @@ -63,8 +63,8 @@ describe "CollaboratorsController", -> it "should remove the logged in user from the project", -> @CollaboratorsHandler.removeUserFromProject.calledWith(@project_id, @user_id) - it "should redirect to the project page", -> - @res.redirectedTo.should.equal "/project" + it "should return a success code", -> + @res.statusCode.should.equal 204 describe "_formatCollaborators", -> beforeEach ->