From 1a4b8f4269d9ccfaa8fcd592db77bee7f88265e7 Mon Sep 17 00:00:00 2001 From: James Allen Date: Wed, 7 Oct 2015 13:44:40 +0100 Subject: [PATCH] API/service layout deprecation warning --- services/track-changes/app/coffee/WebApiManager.coffee | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/services/track-changes/app/coffee/WebApiManager.coffee b/services/track-changes/app/coffee/WebApiManager.coffee index d7441682e3..4e8e9602d8 100644 --- a/services/track-changes/app/coffee/WebApiManager.coffee +++ b/services/track-changes/app/coffee/WebApiManager.coffee @@ -2,6 +2,11 @@ request = require "request" logger = require "logger-sharelatex" Settings = require "settings-sharelatex" +# DEPRECATED! This method of getting user details via track-changes is deprecated +# in the way we lay out our services. +# Instead, web should be responsible for collecting the raw data (user_ids) and +# filling it out with calls to other services. All API calls should create a +# tree-like structure as much as possible, with web as the root. module.exports = WebApiManager = sendRequest: (url, callback = (error, body) ->) -> request.get { @@ -56,4 +61,4 @@ module.exports = WebApiManager = project = JSON.parse(body) catch error return callback(error) - callback null, project \ No newline at end of file + callback null, project