github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-07 20:31:06 -05:00
Code Issues Projects Releases Packages Wiki Activity

make logging of hash errors optional

Browse source
This commit is contained in:
Brian Gough 2017-02-22 13:46:34 +00:00
parent 8d1b11f37a
commit 19e7522d3f
2 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
services/document-updater/app/coffee/RedisManager.coffee
View file

@ -18,6 +18,8 @@ setScript = """
return redis.sha1hex(ARGV[1])
"""
logHashErrors = Settings.documentupdater?.logHashErrors
module.exports = RedisManager =
rclient: rclient
@ -43,7 +45,7 @@ module.exports = RedisManager =
return callback(error) if error?
# check the hash computed on the redis server
writeHash = result?[0]
if writeHash? and writeHash isnt docHash
if logHashErrors and writeHash? and writeHash isnt docHash
logger.error project_id: project_id, doc_id: doc_id, writeHash: writeHash, origHash: docHash, "hash mismatch on putDocInMemory"
# update docsInProject set
rclient.sadd keys.docsInProject(project_id:project_id), doc_id, callback
@ -83,7 +85,7 @@ module.exports = RedisManager =
# check sha1 hash value if present
if docLines? and storedHash?
computedHash = RedisManager._computeHash(docLines)
if computedHash isnt storedHash
if logHashErrors and computedHash isnt storedHash
logger.error project_id: project_id, doc_id: doc_id, doc_project_id: doc_project_id, computedHash: computedHash, storedHash: storedHash, "hash mismatch on retrieved document"
try
@ -164,7 +166,7 @@ module.exports = RedisManager =
return callback(error) if error?
# check the hash computed on the redis server
writeHash = result?[0]
if writeHash? and writeHash isnt newHash
if logHashErrors and writeHash? and writeHash isnt newHash
logger.error doc_id: doc_id, writeHash: writeHash, origHash: newHash, "hash mismatch on updateDocument"
return callback()

1
services/document-updater/test/unit/coffee/RedisManager/RedisManagerTests.coffee
View file

@ -26,6 +26,7 @@ describe "RedisManager", ->
docsInProject: ({project_id}) -> "DocsIn:#{project_id}"
ranges: ({doc_id}) -> "Ranges:#{doc_id}"
"logger-sharelatex": @logger = { error: sinon.stub(), log: sinon.stub(), warn: sinon.stub() }
"settings-sharelatex": {documentupdater: {logHashErrors: true}}
"./Metrics": @metrics =
inc: sinon.stub()
Timer: class Timer