From 18726f739d5de11a15c9d21a03e366630004bc1f Mon Sep 17 00:00:00 2001 From: Jimmy Domagala-Tang Date: Fri, 29 Sep 2023 09:56:14 -0400 Subject: [PATCH] Merge pull request #14995 from overleaf/jdt-detach-breaks-on-clone remove messageComponent until we handle markup GitOrigin-RevId: d4220277d3cb16eda32325eb3ba2f70102e36d2c --- .../frontend/js/ide/human-readable-logs/HumanReadableLogs.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/services/web/frontend/js/ide/human-readable-logs/HumanReadableLogs.js b/services/web/frontend/js/ide/human-readable-logs/HumanReadableLogs.js index 61867c6a6b..e07b007bf2 100644 --- a/services/web/frontend/js/ide/human-readable-logs/HumanReadableLogs.js +++ b/services/web/frontend/js/ide/human-readable-logs/HumanReadableLogs.js @@ -48,7 +48,10 @@ export default { ) if (Array.isArray(message)) { entry.message = message[0] - entry.messageComponent = message[1] + // removing the messageComponent, as the markup possible in it was causing crashes when + // attempting to broadcast it in the detach-context (cant structuredClone an html node) + // see https://github.com/overleaf/internal/discussions/15031 for context + // entry.messageComponent = message[1] } else { entry.message = message }