github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-14 20:40:17 -05:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #21377 from overleaf/mf-add-countryCode-to-view-plans-and-interstitial-page-new

Browse source 
[web] Add missing `countryCode` in new-design plans page and all variants of the interstitial payment page

GitOrigin-RevId: e3a410e89a6745d042f9747a01960618eb622733
This commit is contained in:
M Fahru 2024-10-31 08:49:54 -07:00 committed by Copybot
parent d0df44b190
commit 1547325073
2 changed files with 33 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
services/web/app/src/Features/Subscription/SubscriptionController.js
View file

@ -397,6 +397,7 @@ async function interstitialPaymentPage(req, res) {
latamCountryBannerDetails,
skipLinkTarget: req.session?.postCheckoutRedirect || '/project',
websiteRedesignPlansVariant: websiteRedesignPlansAssignment.variant,
countryCode,
})
}
}

32
services/web/test/unit/src/Subscription/SubscriptionControllerTests.js
View file

@ -525,6 +525,16 @@ describe('SubscriptionController', function () {
})
})
})
it('should return correct countryCode', function (done) {
this.GeoIpLookup.promises.getCurrencyCode.resolves({
countryCode: 'MX',
})
this.res.render = (page, opts) => {
expect(opts.countryCode).to.equal('MX')
done()
}
this.SubscriptionController.plansPage(this.req, this.res)
})
})
describe('plansPage light touch redesign', function () {
@ -772,6 +782,17 @@ describe('SubscriptionController', function () {
this.SubscriptionController.plansPageLightDesign(this.req, this.res)
})
})
it('should return correct countryCode', function (done) {
this.GeoIpLookup.promises.getCurrencyCode.resolves({
countryCode: 'MX',
})
this.res.render = (page, opts) => {
expect(opts.countryCode).to.equal('MX')
done()
}
this.SubscriptionController.plansPageLightDesign(this.req, this.res)
})
})
describe('interstitialPaymentPage', function () {
@ -959,6 +980,17 @@ describe('SubscriptionController', function () {
})
})
})
it('should return correct countryCode', function (done) {
this.GeoIpLookup.promises.getCurrencyCode.resolves({
countryCode: 'MX',
})
this.res.render = (page, opts) => {
expect(opts.countryCode).to.equal('MX')
done()
}
this.SubscriptionController.interstitialPaymentPage(this.req, this.res)
})
})
describe('successfulSubscription', function () {