mirror of
https://github.com/overleaf/overleaf.git
synced 2024-11-07 20:31:06 -05:00
Merge pull request #284 from sharelatex/fix-synctex-subdir-path
work around for synctex paths containing /./
This commit is contained in:
commit
13d6448ab8
1 changed files with 9 additions and 1 deletions
|
@ -163,7 +163,15 @@ module.exports = CompileController =
|
||||||
proxySyncCode: (req, res, next = (error) ->) ->
|
proxySyncCode: (req, res, next = (error) ->) ->
|
||||||
project_id = req.params.Project_id
|
project_id = req.params.Project_id
|
||||||
{file, line, column} = req.query
|
{file, line, column} = req.query
|
||||||
if not file? or Path.resolve("/", file) isnt "/#{file}"
|
if not file?
|
||||||
|
return next(new Error("missing file parameter"))
|
||||||
|
# Check that we are dealing with a simple file path (this is not
|
||||||
|
# strictly needed because synctex uses this parameter as a label
|
||||||
|
# to look up in the synctex output, and does not open the file
|
||||||
|
# itself). Since we have valid synctex paths like foo/./bar we
|
||||||
|
# allow those by replacing /./ with /
|
||||||
|
testPath = file.replace '/./', '/'
|
||||||
|
if Path.resolve("/", testPath) isnt "/#{testPath}"
|
||||||
return next(new Error("invalid file parameter"))
|
return next(new Error("invalid file parameter"))
|
||||||
if not line?.match(/^\d+$/)
|
if not line?.match(/^\d+$/)
|
||||||
return next(new Error("invalid line parameter"))
|
return next(new Error("invalid line parameter"))
|
||||||
|
|
Loading…
Reference in a new issue