From 130fece0f6fd3461c5761a24ffe83dbeec5de53a Mon Sep 17 00:00:00 2001 From: Henry Oswald Date: Fri, 19 Aug 2016 18:33:03 +0100 Subject: [PATCH] track when users accept invites --- .../Collaborators/CollaboratorsInviteController.coffee | 3 ++- .../Collaborators/CollaboratorsInviteControllerTests.coffee | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/services/web/app/coffee/Features/Collaborators/CollaboratorsInviteController.coffee b/services/web/app/coffee/Features/Collaborators/CollaboratorsInviteController.coffee index 216e2f8a01..4f8daf4bdb 100644 --- a/services/web/app/coffee/Features/Collaborators/CollaboratorsInviteController.coffee +++ b/services/web/app/coffee/Features/Collaborators/CollaboratorsInviteController.coffee @@ -7,7 +7,7 @@ logger = require('logger-sharelatex') EmailHelper = require "../Helpers/EmailHelper" EditorRealTimeController = require("../Editor/EditorRealTimeController") NotificationsBuilder = require("../Notifications/NotificationsBuilder") - +AnalyticsManger = require("../Analytics/AnalyticsManager") module.exports = CollaboratorsInviteController = @@ -120,4 +120,5 @@ module.exports = CollaboratorsInviteController = logger.err {projectId, inviteId}, "error accepting invite by token" return next(err) EditorRealTimeController.emitToRoom projectId, 'project:membership:changed', {invites: true, members: true} + AnalyticsManger.recordEvent(currentUser._id, "project-invite-accept", {inviteId:inviteId, projectId:projectId}) res.redirect "/project/#{projectId}" diff --git a/services/web/test/UnitTests/coffee/Collaborators/CollaboratorsInviteControllerTests.coffee b/services/web/test/UnitTests/coffee/Collaborators/CollaboratorsInviteControllerTests.coffee index 346ac3a3c1..0144583f05 100644 --- a/services/web/test/UnitTests/coffee/Collaborators/CollaboratorsInviteControllerTests.coffee +++ b/services/web/test/UnitTests/coffee/Collaborators/CollaboratorsInviteControllerTests.coffee @@ -11,6 +11,7 @@ ObjectId = require("mongojs").ObjectId describe "CollaboratorsInviteController", -> beforeEach -> + @AnalyticsManger = recordEvent: sinon.stub() @CollaboratorsInviteController = SandboxedModule.require modulePath, requires: "../Project/ProjectGetter": @ProjectGetter = {} '../Subscription/LimitationsManager' : @LimitationsManager = {} @@ -20,6 +21,7 @@ describe "CollaboratorsInviteController", -> 'logger-sharelatex': @logger = {err: sinon.stub(), error: sinon.stub(), log: sinon.stub()} "../Editor/EditorRealTimeController": @EditorRealTimeController = {emitToRoom: sinon.stub()} "../Notifications/NotificationsBuilder": @NotificationsBuilder = {} + "../Analytics/AnalyticsManager": @AnalyticsManger @res = new MockResponse() @req = new MockRequest()