github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-09-16 02:52:31 -04:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #6083 from overleaf/ta-on-select-conditional

Browse source 
Avoid Calling onSelect When Selection Hasn't Changed

GitOrigin-RevId: 20e9b9a905195c98c60fafe132adfbaa90925e40
This commit is contained in:
Timothée Alby 2021-12-14 14:24:41 +01:00 committed by Copybot
parent c1c0f1fe4a
commit 1201a733d9
2 changed files with 12 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
services/web/frontend/js/features/file-tree/contexts/file-tree-selectable.js
View file

@ -9,11 +9,13 @@ import {
} from 'react'
import PropTypes from 'prop-types'
import classNames from 'classnames'
import _ from 'lodash'
import { findInTree } from '../util/find-in-tree'
import { useFileTreeMutable } from './file-tree-mutable'
import { useFileTreeMainContext } from './file-tree-main'
import usePersistedState from '../../../shared/hooks/use-persisted-state'
import usePreviousValue from '../../../shared/hooks/use-previous-value'
const FileTreeSelectableContext = createContext()
@ -122,12 +124,16 @@ export function FileTreeSelectableProvider({
}, [fileTreeData, selectedEntityIds])
// calls `onSelect` on entities selection
const previousSelectedEntityIds = usePreviousValue(selectedEntityIds)
useEffect(() => {
if (_.isEqual(selectedEntityIds, previousSelectedEntityIds)) {
return
}
const selectedEntities = Array.from(selectedEntityIds)
.map(id => findInTree(fileTreeData, id))
.filter(Boolean)
onSelect(selectedEntities)
}, [fileTreeData, selectedEntityIds, onSelect])
}, [fileTreeData, selectedEntityIds, previousSelectedEntityIds, onSelect])
useEffect(() => {
// listen for `editor.openDoc` and selected that doc

5
services/web/test/frontend/features/file-tree/flows/rename-entity.test.js
View file

@ -62,6 +62,7 @@ describe('FileTree Rename Entity Flow', function () {
/>,
{ socket: new MockedSocket() }
)
onSelect.reset()
})
it('renames doc', function () {
@ -76,6 +77,10 @@ describe('FileTree Rename Entity Flow', function () {
const lastFetchBody = getLastFetchBody(fetchMatcher)
expect(lastFetchBody.name).to.equal('b.tex')
// onSelect should have been called once only: when the doc was selected for
// rename
sinon.assert.calledOnce(onSelect)
})
it('renames folder', function () {