github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-21 20:47:08 -05:00
Code Issues Projects Releases Packages Wiki Activity

Don't record redirect to static asset paths

Browse source
This commit is contained in:
Shane Kilkelly 2017-01-17 14:35:37 +00:00
parent 82ddeab2bd
commit 1137ab0715
2 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
services/web/app/coffee/Features/Authentication/AuthenticationController.coffee
View file

@ -194,8 +194,8 @@ module.exports = AuthenticationController =
_setRedirectInSession: (req, value) -> _setRedirectInSession: (req, value) ->
if !value? if !value?
value = if Object.keys(req.query).length > 0 then "#{req.path}?#{querystring.stringify(req.query)}" else req.path value = if Object.keys(req.query).length > 0 then "#{req.path}?#{querystring.stringify(req.query)}" else "#{req.path}"
if req.session? if req.session? && !value.match(new RegExp('^\/(socket.io|js|stylesheets|img)\/.*$'))
req.session.postLoginRedirect = value req.session.postLoginRedirect = value
_getRedirectFromSession: (req) -> _getRedirectFromSession: (req) ->

9
services/web/test/UnitTests/coffee/Authentication/AuthenticationControllerTests.coffee
View file

@ -550,6 +550,15 @@ describe "AuthenticationController", ->
@AuthenticationController._setRedirectInSession(@req, '/somewhere/specific') @AuthenticationController._setRedirectInSession(@req, '/somewhere/specific')
expect(@req.session.postLoginRedirect).to.equal "/somewhere/specific" expect(@req.session.postLoginRedirect).to.equal "/somewhere/specific"
describe 'with a js path', ->
beforeEach ->
@req = {session: {}}
it 'should not set the redirect', ->
@AuthenticationController._setRedirectInSession(@req, '/js/something.js')
expect(@req.session.postLoginRedirect).to.equal undefined
describe '_getRedirectFromSession', -> describe '_getRedirectFromSession', ->
beforeEach -> beforeEach ->
@req = {session: {postLoginRedirect: "/a?b=c"}} @req = {session: {postLoginRedirect: "/a?b=c"}}