From 0edd4b78997516efa3acfe75ef8c8ee69ccdc56b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timoth=C3=A9e=20Alby?= Date: Tue, 1 Mar 2022 10:14:58 +0100 Subject: [PATCH] Merge pull request #6934 from overleaf/ab-sso-user-assignment Fix assignment by user ID for SSO test GitOrigin-RevId: a487bf45444507246899ea918ffe02ad67e514d4 --- services/web/app/src/Features/SplitTests/SplitTestHandler.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/services/web/app/src/Features/SplitTests/SplitTestHandler.js b/services/web/app/src/Features/SplitTests/SplitTestHandler.js index 7593e63989..6a54930d0a 100644 --- a/services/web/app/src/Features/SplitTests/SplitTestHandler.js +++ b/services/web/app/src/Features/SplitTests/SplitTestHandler.js @@ -7,6 +7,7 @@ const _ = require('lodash') const { callbackify } = require('util') const SplitTestCache = require('./SplitTestCache') const { SplitTest } = require('../../models/SplitTest') +const UserAnalyticsIdCache = require('../Analytics/UserAnalyticsIdCache') const DEFAULT_VARIANT = 'default' const ALPHA_PHASE = 'alpha' @@ -78,7 +79,8 @@ async function getAssignmentForUser( splitTestName, { sync = false } = {} ) { - return _getAssignment(splitTestName, { userId, sync }) + const analyticsId = await UserAnalyticsIdCache.get(userId) + return _getAssignment(splitTestName, { analyticsId, userId, sync }) } /**