github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2025-04-17 09:58:45 +00:00
Code Issues Projects Releases Packages Wiki Activity

update tests to use safe_exec

Browse source
This commit is contained in:
Brian Gough 2015-03-13 09:31:43 +00:00
parent 33d8974d02
commit 0e5abe1ff8
1 changed files with 11 additions and 12 deletions

23
services/filestore/test/unit/coffee/FileConverterTests.coffee
View file

@ -10,10 +10,9 @@ describe "FileConverter", ->
beforeEach ->
@child_process =
exec : sinon.stub()
@safe_exec = sinon.stub()
@converter = SandboxedModule.require modulePath, requires:
'child_process': @child_process
"./SafeExec": @safe_exec
"logger-sharelatex":
log:->
err:->
@ -25,43 +24,43 @@ describe "FileConverter", ->
describe "convert", ->
it "should convert the source to the requested format", (done)->
@child_process.exec.callsArgWith(2)
@safe_exec.callsArgWith(2)
@converter.convert @sourcePath, @format, (err)=>
args = @child_process.exec.args[0][0]
args = @safe_exec.args[0][0]
args.indexOf(@sourcePath).should.not.equal -1
args.indexOf(@format).should.not.equal -1
done()
it "should return the dest path", (done)->
@child_process.exec.callsArgWith(2)
@safe_exec.callsArgWith(2)
@converter.convert @sourcePath, @format, (err, destPath)=>
destPath.should.equal "#{@sourcePath}.#{@format}"
done()
it "should return the error from convert", (done)->
@child_process.exec.callsArgWith(2, @error)
@safe_exec.callsArgWith(2, @error)
@converter.convert @sourcePath, @format, (err)=>
err.should.equal @error
done()
it "should not accapt an non aproved format", (done)->
@child_process.exec.callsArgWith(2)
@safe_exec.callsArgWith(2)
@converter.convert @sourcePath, "ahhhhh", (err)=>
expect(err).to.exist
done()
describe "thumbnail", ->
it "should call converter resize with args", (done)->
@child_process.exec.callsArgWith(2)
@safe_exec.callsArgWith(2)
@converter.thumbnail @sourcePath, (err)=>
args = @child_process.exec.args[0][0]
args = @safe_exec.args[0][0]
args.indexOf(@sourcePath).should.not.equal -1
done()
describe "preview", ->
it "should call converter resize with args", (done)->
@child_process.exec.callsArgWith(2)
@safe_exec.callsArgWith(2)
@converter.preview @sourcePath, (err)=>
args = @child_process.exec.args[0][0]
args = @safe_exec.args[0][0]
args.indexOf(@sourcePath).should.not.equal -1
done()