github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-21 20:47:08 -05:00
Code Issues Projects Releases Packages Wiki Activity

monkeypatch socket.io to fix frame handler in v0.9.16

Browse source
This commit is contained in:
Brian Gough 2019-07-16 14:02:52 +01:00
parent a724021900
commit 0c6ba4c1a8
2 changed files with 46 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
services/real-time/app.coffee
View file

@ -23,6 +23,9 @@ CookieParser = require("cookie-parser")
DrainManager = require("./app/js/DrainManager")
HealthCheckManager = require("./app/js/HealthCheckManager")
# work around frame handler bug in socket.io v0.9.16
require("./socket.io.patch.js")
# Set up socket.io server
app = express()
Metrics.injectMetricsRoute(app)

43
services/real-time/socket.io.patch.js Normal file
View file

@ -0,0 +1,43 @@
var io = require("socket.io");
if (io.version === "0.9.16") {
console.log("patching socket.io hybi-16 transport frame prototype");
var transports = require("socket.io/lib/transports/websocket/hybi-16.js");
transports.prototype.frame = patchedFrameHandler;
// file hybi-07-12 has the same problem but no browsers are using that protocol now
}
function patchedFrameHandler(opcode, str) {
var dataBuffer = new Buffer(str),
dataLength = dataBuffer.length,
startOffset = 2,
secondByte = dataLength;
if (dataLength === 65536) {
console.log("fixing invalid frame length in socket.io");
}
if (dataLength > 65535) {
// original code had > 65536
startOffset = 10;
secondByte = 127;
} else if (dataLength > 125) {
startOffset = 4;
secondByte = 126;
}
var outputBuffer = new Buffer(dataLength + startOffset);
outputBuffer[0] = opcode;
outputBuffer[1] = secondByte;
dataBuffer.copy(outputBuffer, startOffset);
switch (secondByte) {
case 126:
outputBuffer[2] = dataLength >>> 8;
outputBuffer[3] = dataLength % 256;
break;
case 127:
var l = dataLength;
for (var i = 1; i <= 8; ++i) {
outputBuffer[startOffset - i] = l & 0xff;
l >>>= 8;
}
}
return outputBuffer;
}