From 08861187d51b42a93ce79e31a09484b72a8e3879 Mon Sep 17 00:00:00 2001
From: Simon Detheridge <gh2k@users.noreply.github.com>
Date: Mon, 17 Jun 2019 15:47:19 +0100
Subject: [PATCH] Merge pull request #1834 from
 overleaf/ns-sd-synctex-fail-gooder

display warning if synctex fails to return filename

GitOrigin-RevId: 1de5f9f06a03d6debc35cd4bace6cc921a634d6d
---
 services/web/app/views/project/editor.pug                | 7 +++++++
 .../web/public/src/ide/pdf/controllers/PdfController.js  | 9 ++++++++-
 services/web/public/stylesheets/app/editor.less          | 4 ++++
 3 files changed, 19 insertions(+), 1 deletion(-)

diff --git a/services/web/app/views/project/editor.pug b/services/web/app/views/project/editor.pug
index d17a5d70aa..65fb7b4190 100644
--- a/services/web/app/views/project/editor.pug
+++ b/services/web/app/views/project/editor.pug
@@ -34,6 +34,13 @@ block content
 			.alert.alert-warning.small(ng-if="connection.reconnecting")
 				strong #{translate("reconnecting")}...
 
+			.alert.alert-warning.small(ng-if="sync_tex_error")
+				strong #{translate("synctex_failed")}.
+				a#synctex-more-info-button.alert-link-as-btn.pull-right(
+					href="/learn/how-to/SyncTeX_Errors"
+					target="_blank"
+				) #{translate("more_info")}
+
 			.alert.alert-warning.small(ng-if="connection.inactive_disconnect")
 				strong #{translate("editor_disconected_click_to_reconnect")}
 
diff --git a/services/web/public/src/ide/pdf/controllers/PdfController.js b/services/web/public/src/ide/pdf/controllers/PdfController.js
index e5bbffa9bd..f1315f07ae 100644
--- a/services/web/public/src/ide/pdf/controllers/PdfController.js
+++ b/services/web/public/src/ide/pdf/controllers/PdfController.js
@@ -1012,7 +1012,11 @@ define([
           })
             .then(function(response) {
               const { data } = response
-              if (data.code != null && data.code.length > 0) {
+              if (
+                data.code != null &&
+                data.code.length > 0 &&
+                data.code[0].file !== ''
+              ) {
                 const doc = ide.fileTreeManager.findEntityByPath(
                   data.code[0].file
                 )
@@ -1020,6 +1024,9 @@ define([
                   return
                 }
                 return deferred.resolve({ doc, line: data.code[0].line })
+              } else if (data.code[0].file === '') {
+                ide.$scope.sync_tex_error = true
+                setTimeout(() => (ide.$scope.sync_tex_error = false), 4000)
               }
             })
             .catch(function(response) {
diff --git a/services/web/public/stylesheets/app/editor.less b/services/web/public/stylesheets/app/editor.less
index 10b385ef13..17844dc31e 100644
--- a/services/web/public/stylesheets/app/editor.less
+++ b/services/web/public/stylesheets/app/editor.less
@@ -72,6 +72,10 @@
 		margin-left: 20px;
 	}
 
+	#synctex-more-info-button {
+		margin-left: 20px;
+	}
+
 #ide-body {
 	.full-size;
 	top: @ide-body-top-offset;