From 0841ab82789cd447863b2be3341ef31f3a433d44 Mon Sep 17 00:00:00 2001 From: Paulo Reis Date: Fri, 17 Feb 2017 11:24:21 +0000 Subject: [PATCH] Add directive to collapse elements via height. --- services/web/app/views/project/editor/review-panel.pug | 4 +++- .../coffee/ide/review-panel/ReviewPanelManager.coffee | 1 + .../web/public/stylesheets/app/editor/review-panel.less | 6 ++++++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/services/web/app/views/project/editor/review-panel.pug b/services/web/app/views/project/editor/review-panel.pug index 37490227df..5b12eff9de 100644 --- a/services/web/app/views/project/editor/review-panel.pug +++ b/services/web/app/views/project/editor/review-panel.pug @@ -100,7 +100,9 @@ ) i.fa.fa-angle-down - .rp-overview-file-entries(ng-class="{ 'rp-overview-file-entries-collapsed' : reviewPanel.overview.docsCollapsedState[doc.doc.id] }") + .rp-overview-file-entries( + review-panel-collapse-height="reviewPanel.overview.docsCollapsedState[doc.doc.id]" + ) .rp-entry-wrapper( ng-repeat="(entry_id, entry) in reviewPanel.entries[doc.doc.id] | orderOverviewEntries" ng-if="!(entry.type === 'comment' && reviewPanel.commentThreads[entry.thread_id].resolved === true)" diff --git a/services/web/public/coffee/ide/review-panel/ReviewPanelManager.coffee b/services/web/public/coffee/ide/review-panel/ReviewPanelManager.coffee index 1565d6db73..4e0b70768c 100644 --- a/services/web/public/coffee/ide/review-panel/ReviewPanelManager.coffee +++ b/services/web/public/coffee/ide/review-panel/ReviewPanelManager.coffee @@ -8,6 +8,7 @@ define [ "ide/review-panel/directives/addCommentEntry" "ide/review-panel/directives/resolvedCommentEntry" "ide/review-panel/directives/resolvedCommentsDropdown" + "ide/review-panel/directives/reviewPanelCollapseHeight" "ide/review-panel/filters/notEmpty" "ide/review-panel/filters/orderOverviewEntries" ], () -> \ No newline at end of file diff --git a/services/web/public/stylesheets/app/editor/review-panel.less b/services/web/public/stylesheets/app/editor/review-panel.less index 394468a026..62f3a0e16b 100644 --- a/services/web/public/stylesheets/app/editor/review-panel.less +++ b/services/web/public/stylesheets/app/editor/review-panel.less @@ -575,10 +575,16 @@ transform: rotateZ(0deg); transition: transform 0.15s ease } + .rp-overview-file-header-collapse-on { transform: rotateZ(180deg); } + .rp-overview-file-entries { + overflow: hidden; + transition: height .15s; + } + .rp-comment-wrapper { transition: .35s opacity ease-out .2s;