Merge pull request #14129 from overleaf/ii-ref-providers

[web] Map refProviders values to booleans

GitOrigin-RevId: d1a81dab4eb432e4e34f1f195b80dd676bfe172e
This commit is contained in:
ilkin-overleaf 2023-08-03 13:20:01 +03:00 committed by Copybot
parent b5ae499315
commit 083bee6545
3 changed files with 17 additions and 6 deletions

View file

@ -101,8 +101,8 @@ async function settingsPage(req, res) {
references: user.features.references,
},
refProviders: {
mendeley: user.refProviders?.mendeley,
zotero: user.refProviders?.zotero,
mendeley: Boolean(user.refProviders?.mendeley),
zotero: Boolean(user.refProviders?.zotero),
},
},
hasPassword: !!user.hashedPassword,

View file

@ -25,8 +25,8 @@ UserContext.Provider.propTypes = {
compileTimeout: PropTypes.number,
}),
refProviders: PropTypes.shape({
mendeley: PropTypes.any,
zotero: PropTypes.any,
mendeley: PropTypes.boolean,
zotero: PropTypes.boolean,
}),
}),
}),

View file

@ -44,8 +44,8 @@ describe('UserPagesController', function () {
},
],
refProviders: {
mendeley: true,
zotero: true,
mendeley: { encrypted: 'aaaa' },
zotero: { encrypted: 'bbbb' },
},
}
@ -314,6 +314,17 @@ describe('UserPagesController', function () {
return this.UserPagesController.settingsPage(this.req, this.res)
})
it('should cast refProviders to booleans', function (done) {
this.res.render = function (page, opts) {
expect(opts.user.refProviders).to.deep.equal({
mendeley: true,
zotero: true,
})
return done()
}
return this.UserPagesController.settingsPage(this.req, this.res)
})
describe('when ldap.updateUserDetailsOnLogin is true', function () {
beforeEach(function () {
return (this.settings.ldap = { updateUserDetailsOnLogin: true })