From e31464b47d19f78f26694b2aa908238dfedfcd79 Mon Sep 17 00:00:00 2001 From: Alasdair Smith Date: Mon, 25 Sep 2017 15:46:29 +0100 Subject: [PATCH 1/2] Keep track of pdf layout hidden state --- services/web/public/coffee/ide.coffee | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/services/web/public/coffee/ide.coffee b/services/web/public/coffee/ide.coffee index d37334649c..e317b355ef 100644 --- a/services/web/public/coffee/ide.coffee +++ b/services/web/public/coffee/ide.coffee @@ -71,11 +71,12 @@ define [ view: "editor" chatOpen: false pdfLayout: 'sideBySide' + pdfHidden: false, reviewPanelOpen: localStorage("ui.reviewPanelOpen.#{window.project_id}") miniReviewPanelVisible: false } $scope.user = window.user - + $scope.$watch "project.features.trackChangesVisible", (visible) -> return if !visible? $scope.ui.showCollabFeaturesOnboarding = window.showTrackChangesOnboarding and visible @@ -99,6 +100,9 @@ define [ if value? localStorage "ui.reviewPanelOpen.#{window.project_id}", value + $scope.$on "layout:pdf:resize", (_, layoutState) -> + $scope.ui.pdfHidden = layoutState.east.initClosed + # Tracking code. $scope.$watch "ui.view", (newView, oldView) -> if newView? and newView != "editor" and newView != "pdf" From 5b3c9f4033cbde25a708a30e59578c1e41bf050f Mon Sep 17 00:00:00 2001 From: Alasdair Smith Date: Mon, 25 Sep 2017 15:46:43 +0100 Subject: [PATCH 2/2] Prevent autocompile if pdf preview is hidden --- .../web/public/coffee/ide/pdf/controllers/PdfController.coffee | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/services/web/public/coffee/ide/pdf/controllers/PdfController.coffee b/services/web/public/coffee/ide/pdf/controllers/PdfController.coffee index ce3c8cbce1..93166d4388 100644 --- a/services/web/public/coffee/ide/pdf/controllers/PdfController.coffee +++ b/services/web/public/coffee/ide/pdf/controllers/PdfController.coffee @@ -77,7 +77,7 @@ define [ autoCompileTimeout = null triggerAutoCompile = () -> - return if autoCompileTimeout + return if autoCompileTimeout or $scope.ui.pdfHidden timeSinceLastCompile = Date.now() - $scope.recompiledAt # If time is non-monotonic, assume that the user's system clock has been