github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2025-04-20 04:13:39 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #1742 from sharelatex/bg-avoid-unnecessary-callback-for-emit-to-room

Browse source 
remove unnecessary callback on emitToRoom

GitOrigin-RevId: a34006d6f72862b1f2e0b88d20ad8003ea5b8883
This commit is contained in:
Alasdair Smith 2019-05-01 10:23:48 +01:00 • committed by sharelatex
parent 2c30ae0f8a
commit 028c3bc94c
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
services/web/app/coffee/Features/Chat/ChatController.coffee
View file

@ -19,7 +19,7 @@ module.exports = ChatController =
UserInfoManager.getPersonalInfo message.user_id, (err, user) ->
return next(err) if err?
message.user = UserInfoController.formatPersonalInfo(user)
EditorRealTimeController.emitToRoom project_id, "new-chat-message", message, (err)->
EditorRealTimeController.emitToRoom project_id, "new-chat-message", message
res.send(204)
getMessages: (req, res, next)->

2
services/web/test/unit/coffee/Chat/ChatControllerTests.coffee
View file

@ -12,7 +12,7 @@ describe "ChatController", ->
@settings = {}
@ChatApiHandler = {}
@EditorRealTimeController =
emitToRoom:sinon.stub().callsArgWith(3)
emitToRoom:sinon.stub()
@AuthenticationController =
getLoggedInUserId: sinon.stub().returns(@user_id)
@ChatController = SandboxedModule.require modulePath, requires: