github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-09-16 02:52:31 -04:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #2512 from overleaf/jel-plans-scroll-event

Browse source 
Fix throttle used for scroll event

GitOrigin-RevId: fd453a74fca823391c3ca962f076a89f778f9f28
This commit is contained in:
nate stemen 2020-01-13 09:49:27 -07:00 committed by Copybot
parent 31bc0c640b
commit 00b537b047
1 changed files with 12 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
services/web/frontend/js/directives/eventTracking.js
View file

@ -84,18 +84,18 @@ define(['base'], App =>
timer = setTimeout(() => sendEvent(), timeoutAmt)
})
.on('mouseleave', () => clearTimeout(timer))
} else if (attrs.eventTrackingTrigger === 'scroll') {
if (!eventTracking.eventInCache(scope.eventTracking)) {
return $(window).on('resize scroll', () =>
_.throttle(
isInViewport(element) &&
!eventTracking.eventInCache(scope.eventTracking)
? sendEvent(true)
: undefined,
500
)
)
}
} else if (
attrs.eventTrackingTrigger === 'scroll' &&
!eventTracking.eventInCache(scope.eventTracking)
) {
$(window).on(
'resize scroll',
_.throttle(() => {
if (isInViewport(element)) {
sendEvent(true)
}
}, 500)
)
}
}
})))