2024-05-01 09:52:12 -04:00
|
|
|
const SandboxedModule = require('sandboxed-module')
|
|
|
|
const sinon = require('sinon')
|
|
|
|
const { assert, expect } = require('chai')
|
|
|
|
|
|
|
|
const MODULE_PATH = require('path').join(
|
|
|
|
__dirname,
|
|
|
|
'../../../app/js/OutputFileArchiveManager'
|
|
|
|
)
|
|
|
|
|
|
|
|
describe('OutputFileArchiveManager', function () {
|
|
|
|
const userId = 'user-id-123'
|
|
|
|
const projectId = 'project-id-123'
|
|
|
|
const buildId = 'build-id-123'
|
|
|
|
|
|
|
|
afterEach(function () {
|
|
|
|
sinon.restore()
|
|
|
|
})
|
|
|
|
|
|
|
|
beforeEach(function () {
|
|
|
|
this.OutputFileFinder = {
|
|
|
|
promises: {
|
|
|
|
findOutputFiles: sinon.stub().resolves({ outputFiles: [] }),
|
|
|
|
},
|
|
|
|
}
|
|
|
|
|
|
|
|
this.OutputCacheManger = {
|
|
|
|
path: sinon.stub().callsFake((build, path) => {
|
|
|
|
return `${build}/${path}`
|
|
|
|
}),
|
|
|
|
}
|
|
|
|
|
|
|
|
this.archive = {
|
|
|
|
append: sinon.stub(),
|
|
|
|
finalize: sinon.stub(),
|
2024-06-18 04:17:15 -04:00
|
|
|
on: sinon.stub(),
|
2024-05-01 09:52:12 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
this.archiver = sinon.stub().returns(this.archive)
|
|
|
|
|
|
|
|
this.outputDir = '/output/dir'
|
|
|
|
|
|
|
|
this.fs = {
|
|
|
|
open: sinon.stub().callsFake(file => ({
|
|
|
|
createReadStream: sinon.stub().returns(`handle: ${file}`),
|
|
|
|
})),
|
|
|
|
}
|
|
|
|
|
|
|
|
this.OutputFileArchiveManager = SandboxedModule.require(MODULE_PATH, {
|
|
|
|
requires: {
|
|
|
|
'./OutputFileFinder': this.OutputFileFinder,
|
|
|
|
'./OutputCacheManager': this.OutputCacheManger,
|
|
|
|
archiver: this.archiver,
|
|
|
|
'node:fs/promises': this.fs,
|
|
|
|
'@overleaf/settings': {
|
|
|
|
path: {
|
|
|
|
outputDir: this.outputDir,
|
|
|
|
},
|
|
|
|
},
|
|
|
|
},
|
|
|
|
})
|
|
|
|
})
|
|
|
|
|
2024-06-13 05:13:22 -04:00
|
|
|
describe('when the output cache directory contains only exportable files', function () {
|
2024-05-01 09:52:12 -04:00
|
|
|
beforeEach(async function () {
|
|
|
|
this.OutputFileFinder.promises.findOutputFiles.resolves({
|
|
|
|
outputFiles: [
|
|
|
|
{ path: 'file_1' },
|
|
|
|
{ path: 'file_2' },
|
|
|
|
{ path: 'file_3' },
|
|
|
|
{ path: 'file_4' },
|
|
|
|
],
|
|
|
|
})
|
|
|
|
await this.OutputFileArchiveManager.archiveFilesForBuild(
|
|
|
|
projectId,
|
|
|
|
userId,
|
|
|
|
buildId
|
|
|
|
)
|
|
|
|
})
|
|
|
|
|
|
|
|
it('creates a zip archive', function () {
|
|
|
|
sinon.assert.calledWith(this.archiver, 'zip')
|
|
|
|
})
|
|
|
|
|
2024-06-18 04:17:15 -04:00
|
|
|
it('listens to errors from the archive', function () {
|
|
|
|
sinon.assert.calledWith(this.archive.on, 'error', sinon.match.func)
|
|
|
|
})
|
|
|
|
|
2024-05-01 09:52:12 -04:00
|
|
|
it('adds all the output files to the archive', function () {
|
|
|
|
expect(this.archive.append.callCount).to.equal(4)
|
|
|
|
sinon.assert.calledWith(
|
|
|
|
this.archive.append,
|
|
|
|
`handle: ${this.outputDir}/${projectId}-${userId}/${buildId}/file_1`,
|
|
|
|
sinon.match({ name: 'file_1' })
|
|
|
|
)
|
|
|
|
sinon.assert.calledWith(
|
|
|
|
this.archive.append,
|
|
|
|
`handle: ${this.outputDir}/${projectId}-${userId}/${buildId}/file_2`,
|
|
|
|
sinon.match({ name: 'file_2' })
|
|
|
|
)
|
|
|
|
sinon.assert.calledWith(
|
|
|
|
this.archive.append,
|
|
|
|
`handle: ${this.outputDir}/${projectId}-${userId}/${buildId}/file_3`,
|
|
|
|
sinon.match({ name: 'file_3' })
|
|
|
|
)
|
|
|
|
sinon.assert.calledWith(
|
|
|
|
this.archive.append,
|
|
|
|
`handle: ${this.outputDir}/${projectId}-${userId}/${buildId}/file_4`,
|
|
|
|
sinon.match({ name: 'file_4' })
|
|
|
|
)
|
|
|
|
})
|
|
|
|
|
|
|
|
it('finalizes the archive after all files are appended', function () {
|
|
|
|
sinon.assert.called(this.archive.finalize)
|
|
|
|
expect(this.archive.finalize.calledBefore(this.archive.append)).to.be
|
|
|
|
.false
|
|
|
|
})
|
|
|
|
})
|
|
|
|
|
2024-06-13 05:13:22 -04:00
|
|
|
describe('when the directory includes files ignored by web', function () {
|
2024-05-01 09:52:12 -04:00
|
|
|
beforeEach(async function () {
|
|
|
|
this.OutputFileFinder.promises.findOutputFiles.resolves({
|
|
|
|
outputFiles: [
|
|
|
|
{ path: 'file_1' },
|
|
|
|
{ path: 'file_2' },
|
|
|
|
{ path: 'file_3' },
|
|
|
|
{ path: 'file_4' },
|
2024-06-13 05:13:22 -04:00
|
|
|
{ path: 'output.pdf' },
|
2024-05-01 09:52:12 -04:00
|
|
|
],
|
|
|
|
})
|
|
|
|
await this.OutputFileArchiveManager.archiveFilesForBuild(
|
|
|
|
projectId,
|
|
|
|
userId,
|
2024-06-13 05:13:22 -04:00
|
|
|
buildId
|
2024-05-01 09:52:12 -04:00
|
|
|
)
|
|
|
|
})
|
|
|
|
|
2024-06-13 05:13:22 -04:00
|
|
|
it('only includes the non-ignored files in the archive', function () {
|
|
|
|
expect(this.archive.append.callCount).to.equal(4)
|
2024-05-01 09:52:12 -04:00
|
|
|
sinon.assert.calledWith(
|
|
|
|
this.archive.append,
|
2024-06-13 05:13:22 -04:00
|
|
|
`handle: ${this.outputDir}/${projectId}-${userId}/${buildId}/file_1`,
|
|
|
|
sinon.match({ name: 'file_1' })
|
2024-05-01 09:52:12 -04:00
|
|
|
)
|
|
|
|
sinon.assert.calledWith(
|
|
|
|
this.archive.append,
|
2024-06-13 05:13:22 -04:00
|
|
|
`handle: ${this.outputDir}/${projectId}-${userId}/${buildId}/file_2`,
|
|
|
|
sinon.match({ name: 'file_2' })
|
|
|
|
)
|
|
|
|
sinon.assert.calledWith(
|
|
|
|
this.archive.append,
|
|
|
|
`handle: ${this.outputDir}/${projectId}-${userId}/${buildId}/file_3`,
|
|
|
|
sinon.match({ name: 'file_3' })
|
|
|
|
)
|
|
|
|
sinon.assert.calledWith(
|
|
|
|
this.archive.append,
|
|
|
|
`handle: ${this.outputDir}/${projectId}-${userId}/${buildId}/file_4`,
|
|
|
|
sinon.match({ name: 'file_4' })
|
2024-05-01 09:52:12 -04:00
|
|
|
)
|
|
|
|
})
|
|
|
|
})
|
|
|
|
|
2024-06-13 05:13:22 -04:00
|
|
|
describe('when one of the files is called output.pdf', function () {
|
2024-05-01 09:52:12 -04:00
|
|
|
beforeEach(async function () {
|
|
|
|
this.OutputFileFinder.promises.findOutputFiles.resolves({
|
|
|
|
outputFiles: [
|
|
|
|
{ path: 'file_1' },
|
|
|
|
{ path: 'file_2' },
|
|
|
|
{ path: 'file_3' },
|
2024-06-13 05:13:22 -04:00
|
|
|
{ path: 'file_4' },
|
|
|
|
{ path: 'output.pdf' },
|
2024-05-01 09:52:12 -04:00
|
|
|
],
|
|
|
|
})
|
|
|
|
await this.OutputFileArchiveManager.archiveFilesForBuild(
|
|
|
|
projectId,
|
|
|
|
userId,
|
2024-06-13 05:13:22 -04:00
|
|
|
buildId
|
2024-05-01 09:52:12 -04:00
|
|
|
)
|
|
|
|
})
|
|
|
|
|
2024-06-13 05:13:22 -04:00
|
|
|
it('does not include that file in the archive', function () {
|
|
|
|
expect(this.archive.append.callCount).to.equal(4)
|
2024-05-01 09:52:12 -04:00
|
|
|
sinon.assert.calledWith(
|
|
|
|
this.archive.append,
|
2024-06-13 05:13:22 -04:00
|
|
|
`handle: ${this.outputDir}/${projectId}-${userId}/${buildId}/file_1`,
|
2024-05-01 09:52:12 -04:00
|
|
|
sinon.match({ name: 'file_1' })
|
|
|
|
)
|
|
|
|
sinon.assert.calledWith(
|
|
|
|
this.archive.append,
|
2024-06-13 05:13:22 -04:00
|
|
|
`handle: ${this.outputDir}/${projectId}-${userId}/${buildId}/file_2`,
|
|
|
|
sinon.match({ name: 'file_2' })
|
|
|
|
)
|
|
|
|
sinon.assert.calledWith(
|
|
|
|
this.archive.append,
|
|
|
|
`handle: ${this.outputDir}/${projectId}-${userId}/${buildId}/file_3`,
|
|
|
|
sinon.match({ name: 'file_3' })
|
|
|
|
)
|
|
|
|
sinon.assert.calledWith(
|
|
|
|
this.archive.append,
|
|
|
|
`handle: ${this.outputDir}/${projectId}-${userId}/${buildId}/file_4`,
|
|
|
|
sinon.match({ name: 'file_4' })
|
2024-05-01 09:52:12 -04:00
|
|
|
)
|
|
|
|
})
|
|
|
|
})
|
|
|
|
|
|
|
|
describe('when the output directory cannot be accessed', function () {
|
|
|
|
beforeEach(async function () {
|
|
|
|
this.OutputFileFinder.promises.findOutputFiles.rejects({
|
|
|
|
code: 'ENOENT',
|
|
|
|
})
|
|
|
|
})
|
|
|
|
|
|
|
|
it('rejects with a NotFoundError', async function () {
|
|
|
|
try {
|
|
|
|
await this.OutputFileArchiveManager.archiveFilesForBuild(
|
|
|
|
projectId,
|
|
|
|
userId,
|
|
|
|
buildId
|
|
|
|
)
|
|
|
|
assert.fail('should have thrown a NotFoundError')
|
|
|
|
} catch (err) {
|
|
|
|
expect(err).to.haveOwnProperty('name', 'NotFoundError')
|
|
|
|
}
|
|
|
|
})
|
|
|
|
|
|
|
|
it('does not create an archive', function () {
|
|
|
|
expect(this.archiver.called).to.be.false
|
|
|
|
})
|
|
|
|
})
|
|
|
|
})
|