2014-02-12 05:23:40 -05:00
|
|
|
should = require('chai').should()
|
|
|
|
SandboxedModule = require('sandboxed-module')
|
|
|
|
assert = require('assert')
|
|
|
|
path = require('path')
|
|
|
|
modulePath = path.join __dirname, '../../../../app/js/Features/User/UserRegistrationHandler'
|
2014-04-10 09:43:06 -04:00
|
|
|
sinon = require("sinon")
|
|
|
|
expect = require("chai").expect
|
2018-06-11 06:29:08 -04:00
|
|
|
EmailHelper = require '../../../../app/js/Features/Helpers/EmailHelper'
|
2014-02-12 05:23:40 -05:00
|
|
|
|
2014-04-10 07:39:13 -04:00
|
|
|
describe "UserRegistrationHandler", ->
|
2014-04-10 09:43:06 -04:00
|
|
|
|
2014-04-10 07:39:13 -04:00
|
|
|
beforeEach ->
|
2014-04-10 09:43:06 -04:00
|
|
|
@user =
|
2015-12-11 12:11:13 -05:00
|
|
|
_id: @user_id = "31j2lk21kjl"
|
2014-04-10 09:43:06 -04:00
|
|
|
@User =
|
|
|
|
update: sinon.stub().callsArgWith(2)
|
2018-05-23 10:12:23 -04:00
|
|
|
@UserGetter =
|
2018-05-28 10:08:37 -04:00
|
|
|
getUserByAnyEmail: sinon.stub()
|
2014-04-10 09:43:06 -04:00
|
|
|
@UserCreator =
|
|
|
|
createNewUser:sinon.stub().callsArgWith(1, null, @user)
|
|
|
|
@AuthenticationManager =
|
|
|
|
setUserPassword: sinon.stub().callsArgWith(2)
|
|
|
|
@NewsLetterManager =
|
|
|
|
subscribe: sinon.stub().callsArgWith(1)
|
2015-12-11 12:11:13 -05:00
|
|
|
@EmailHandler =
|
|
|
|
sendEmail:sinon.stub().callsArgWith(2)
|
|
|
|
@OneTimeTokenHandler =
|
|
|
|
getNewToken: sinon.stub()
|
2014-04-10 09:43:06 -04:00
|
|
|
@handler = SandboxedModule.require modulePath, requires:
|
|
|
|
"../../models/User": {User:@User}
|
2018-05-23 10:12:23 -04:00
|
|
|
"./UserGetter": @UserGetter
|
2014-04-10 09:43:06 -04:00
|
|
|
"./UserCreator": @UserCreator
|
|
|
|
"../Authentication/AuthenticationManager":@AuthenticationManager
|
2014-04-10 17:21:20 -04:00
|
|
|
"../Newsletter/NewsletterManager":@NewsLetterManager
|
2015-03-18 11:57:01 -04:00
|
|
|
"logger-sharelatex": @logger = { log: sinon.stub() }
|
2015-12-11 12:11:13 -05:00
|
|
|
"crypto": @crypto = {}
|
|
|
|
"../Email/EmailHandler": @EmailHandler
|
|
|
|
"../Security/OneTimeTokenHandler": @OneTimeTokenHandler
|
2016-08-11 09:09:57 -04:00
|
|
|
"../Analytics/AnalyticsManager": @AnalyticsManager = { recordEvent: sinon.stub() }
|
2015-12-11 12:11:13 -05:00
|
|
|
"settings-sharelatex": @settings = {siteUrl: "http://sl.example.com"}
|
2018-06-11 06:29:08 -04:00
|
|
|
"../Helpers/EmailHelper": EmailHelper
|
2014-04-10 09:43:06 -04:00
|
|
|
|
|
|
|
@passingRequest = {email:"something@email.com", password:"123"}
|
2014-02-12 05:23:40 -05:00
|
|
|
|
|
|
|
|
2014-04-10 07:39:13 -04:00
|
|
|
describe 'validate Register Request', ->
|
2014-02-12 05:23:40 -05:00
|
|
|
|
|
|
|
|
2014-04-10 07:39:13 -04:00
|
|
|
it 'allow working account through', ->
|
2014-04-10 09:43:06 -04:00
|
|
|
result = @handler._registrationRequestIsValid @passingRequest
|
|
|
|
result.should.equal true
|
2014-04-10 07:39:13 -04:00
|
|
|
|
2014-04-10 09:43:06 -04:00
|
|
|
it 'not allow not valid email through ', ()->
|
|
|
|
@passingRequest.email = "notemail"
|
|
|
|
result = @handler._registrationRequestIsValid @passingRequest
|
|
|
|
result.should.equal false
|
|
|
|
|
2014-04-10 07:39:13 -04:00
|
|
|
it 'not allow no email through ', ->
|
2014-04-10 09:43:06 -04:00
|
|
|
@passingRequest.email = ""
|
|
|
|
result = @handler._registrationRequestIsValid @passingRequest
|
|
|
|
result.should.equal false
|
2014-04-10 07:39:13 -04:00
|
|
|
|
2014-04-10 09:43:06 -04:00
|
|
|
it 'not allow no password through ', ()->
|
|
|
|
@passingRequest.password= ""
|
|
|
|
result = @handler._registrationRequestIsValid @passingRequest
|
|
|
|
result.should.equal false
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
describe "registerNewUser", ->
|
|
|
|
|
|
|
|
describe "holdingAccount", (done)->
|
|
|
|
|
|
|
|
beforeEach ->
|
|
|
|
@user.holdingAccount = true
|
|
|
|
@handler._registrationRequestIsValid = sinon.stub().returns true
|
2018-05-28 10:08:37 -04:00
|
|
|
@UserGetter.getUserByAnyEmail.callsArgWith(1, null, @user)
|
2014-04-10 09:43:06 -04:00
|
|
|
|
|
|
|
it "should not create a new user if there is a holding account there", (done)->
|
|
|
|
@handler.registerNewUser @passingRequest, (err)=>
|
|
|
|
@UserCreator.createNewUser.called.should.equal false
|
|
|
|
done()
|
|
|
|
|
|
|
|
it "should set holding account to false", (done)->
|
|
|
|
@handler.registerNewUser @passingRequest, (err)=>
|
|
|
|
update = @User.update.args[0]
|
|
|
|
assert.deepEqual update[0], {_id:@user._id}
|
|
|
|
assert.deepEqual update[1], {"$set":{holdingAccount:false}}
|
|
|
|
done()
|
|
|
|
|
|
|
|
describe "invalidRequest", ->
|
|
|
|
|
|
|
|
it "should not create a new user if the the request is not valid", (done)->
|
|
|
|
@handler._registrationRequestIsValid = sinon.stub().returns false
|
|
|
|
@handler.registerNewUser @passingRequest, (err)=>
|
|
|
|
expect(err).to.exist
|
|
|
|
@UserCreator.createNewUser.called.should.equal false
|
|
|
|
done()
|
|
|
|
|
|
|
|
it "should return email registered in the error if there is a non holdingAccount there", (done)->
|
2018-05-28 10:08:37 -04:00
|
|
|
@UserGetter.getUserByAnyEmail.callsArgWith(1, null, @user = {holdingAccount:false})
|
2015-03-19 10:22:48 -04:00
|
|
|
@handler.registerNewUser @passingRequest, (err, user)=>
|
2015-03-18 12:19:48 -04:00
|
|
|
err.should.deep.equal new Error("EmailAlreadyRegistered")
|
2015-03-19 10:22:48 -04:00
|
|
|
user.should.deep.equal @user
|
2014-04-10 09:43:06 -04:00
|
|
|
done()
|
|
|
|
|
|
|
|
describe "validRequest", ->
|
|
|
|
beforeEach ->
|
|
|
|
@handler._registrationRequestIsValid = sinon.stub().returns true
|
2018-05-28 10:08:37 -04:00
|
|
|
@UserGetter.getUserByAnyEmail.callsArgWith 1
|
2014-04-10 09:43:06 -04:00
|
|
|
|
|
|
|
it "should create a new user", (done)->
|
|
|
|
@handler.registerNewUser @passingRequest, (err)=>
|
2016-06-13 08:38:17 -04:00
|
|
|
@UserCreator.createNewUser.calledWith({email:@passingRequest.email, holdingAccount:false, first_name:@passingRequest.first_name, last_name:@passingRequest.last_name}).should.equal true
|
2014-04-10 09:43:06 -04:00
|
|
|
done()
|
|
|
|
|
|
|
|
it 'lower case email', (done)->
|
|
|
|
@passingRequest.email = "soMe@eMail.cOm"
|
|
|
|
@handler.registerNewUser @passingRequest, (err)=>
|
2016-06-13 08:21:44 -04:00
|
|
|
@UserCreator.createNewUser.args[0][0].email.should.equal "some@email.com"
|
2014-04-10 09:43:06 -04:00
|
|
|
done()
|
|
|
|
|
|
|
|
it 'trim white space from email', (done)->
|
|
|
|
@passingRequest.email = " some@email.com "
|
|
|
|
@handler.registerNewUser @passingRequest, (err)=>
|
2016-06-13 08:21:44 -04:00
|
|
|
@UserCreator.createNewUser.args[0][0].email.should.equal "some@email.com"
|
2014-04-10 09:43:06 -04:00
|
|
|
done()
|
|
|
|
|
|
|
|
|
|
|
|
it "should set the password", (done)->
|
|
|
|
@handler.registerNewUser @passingRequest, (err)=>
|
|
|
|
@AuthenticationManager.setUserPassword.calledWith(@user._id, @passingRequest.password).should.equal true
|
|
|
|
done()
|
|
|
|
|
2018-08-06 12:43:03 -04:00
|
|
|
it "should add the user to the newsletter if accepted terms", (done)->
|
|
|
|
@passingRequest.subscribeToNewsletter = "true"
|
2014-04-10 09:43:06 -04:00
|
|
|
@handler.registerNewUser @passingRequest, (err)=>
|
|
|
|
@NewsLetterManager.subscribe.calledWith(@user).should.equal true
|
|
|
|
done()
|
2018-08-06 12:43:03 -04:00
|
|
|
|
|
|
|
it "should not add the user to the newsletter if not accepted terms", (done)->
|
|
|
|
@handler.registerNewUser @passingRequest, (err)=>
|
|
|
|
@NewsLetterManager.subscribe.calledWith(@user).should.equal false
|
|
|
|
done()
|
2014-04-10 09:43:06 -04:00
|
|
|
|
2016-08-11 09:09:57 -04:00
|
|
|
it "should track the registration event", (done)->
|
|
|
|
@handler.registerNewUser @passingRequest, (err)=>
|
|
|
|
@AnalyticsManager.recordEvent
|
|
|
|
.calledWith(@user._id, "user-registered")
|
|
|
|
.should.equal true
|
|
|
|
done()
|
|
|
|
|
2014-04-10 09:43:06 -04:00
|
|
|
|
|
|
|
it "should call the ReferalAllocator", (done)->
|
|
|
|
done()
|
2014-02-12 05:23:40 -05:00
|
|
|
|
2015-12-11 12:11:13 -05:00
|
|
|
describe "registerNewUserAndSendActivationEmail", ->
|
|
|
|
beforeEach ->
|
|
|
|
@email = "email@example.com"
|
|
|
|
@crypto.randomBytes = sinon.stub().returns({toString: () => @password = "mock-password"})
|
2018-06-19 08:55:34 -04:00
|
|
|
@OneTimeTokenHandler.getNewToken.yields(null, @token = "mock-token")
|
2015-12-11 12:11:13 -05:00
|
|
|
@handler.registerNewUser = sinon.stub()
|
|
|
|
@callback = sinon.stub()
|
|
|
|
|
|
|
|
describe "with a new user", ->
|
|
|
|
beforeEach ->
|
|
|
|
@handler.registerNewUser.callsArgWith(1, null, @user)
|
|
|
|
@handler.registerNewUserAndSendActivationEmail @email, @callback
|
|
|
|
|
|
|
|
it "should ask the UserRegistrationHandler to register user", ->
|
|
|
|
@handler.registerNewUser
|
|
|
|
.calledWith({
|
|
|
|
email: @email
|
|
|
|
password: @password
|
|
|
|
}).should.equal true
|
|
|
|
|
|
|
|
it "should generate a new password reset token", ->
|
|
|
|
|
|
|
|
@OneTimeTokenHandler.getNewToken
|
2018-06-19 08:55:34 -04:00
|
|
|
.calledWith('password', @user_id, expiresIn: 7 * 24 * 60 * 60)
|
2015-12-11 12:11:13 -05:00
|
|
|
.should.equal true
|
|
|
|
|
|
|
|
it "should send a registered email", ->
|
|
|
|
@EmailHandler.sendEmail
|
|
|
|
.calledWith("registered", {
|
|
|
|
to: @user.email
|
|
|
|
setNewPasswordUrl: "#{@settings.siteUrl}/user/activate?token=#{@token}&user_id=#{@user_id}"
|
|
|
|
})
|
|
|
|
.should.equal true
|
|
|
|
|
|
|
|
it "should return the user", ->
|
|
|
|
@callback
|
|
|
|
.calledWith(null, @user, "#{@settings.siteUrl}/user/activate?token=#{@token}&user_id=#{@user_id}")
|
|
|
|
.should.equal true
|
|
|
|
|
|
|
|
describe "with a user that already exists", ->
|
|
|
|
beforeEach ->
|
|
|
|
@handler.registerNewUser.callsArgWith(1, new Error("EmailAlreadyRegistered"), @user)
|
|
|
|
@handler.registerNewUserAndSendActivationEmail @email, @callback
|
|
|
|
|
|
|
|
it "should still generate a new password token and email", ->
|
|
|
|
@OneTimeTokenHandler.getNewToken.called.should.equal true
|
|
|
|
@EmailHandler.sendEmail.called.should.equal true
|