overleaf/services/document-updater/test/unit/js/ProjectManager/updateProjectTests.js

413 lines
12 KiB
JavaScript
Raw Normal View History

const sinon = require('sinon')
const modulePath = '../../../../app/js/ProjectManager.js'
const SandboxedModule = require('sandboxed-module')
const _ = require('lodash')
describe('ProjectManager', function () {
beforeEach(function () {
2020-05-15 08:40:11 -04:00
this.RedisManager = {}
this.ProjectHistoryRedisManager = {
queueRenameEntity: sinon.stub().yields(),
2021-07-13 07:04:42 -04:00
queueAddEntity: sinon.stub().yields(),
2020-05-15 08:40:11 -04:00
}
this.DocumentManager = {
2021-07-13 07:04:42 -04:00
renameDocWithLock: sinon.stub().yields(),
2020-05-15 08:40:11 -04:00
}
this.HistoryManager = {
flushProjectChangesAsync: sinon.stub(),
2021-07-13 07:04:42 -04:00
shouldFlushHistoryOps: sinon.stub().returns(false),
2020-05-15 08:40:11 -04:00
}
this.Metrics = {
2021-07-13 07:04:42 -04:00
Timer: class Timer {},
2020-05-15 08:40:11 -04:00
}
this.Metrics.Timer.prototype.done = sinon.stub()
this.ProjectManager = SandboxedModule.require(modulePath, {
requires: {
2020-05-15 08:40:11 -04:00
'./RedisManager': this.RedisManager,
'./ProjectHistoryRedisManager': this.ProjectHistoryRedisManager,
'./DocumentManager': this.DocumentManager,
'./HistoryManager': this.HistoryManager,
2021-07-13 07:04:42 -04:00
'./Metrics': this.Metrics,
},
})
this.project_id = 'project-id-123'
this.projectHistoryId = 'history-id-123'
this.user_id = 'user-id-123'
this.version = 1234567
this.source = 'editor'
2020-05-15 08:31:06 -04:00
this.callback = sinon.stub()
})
2020-05-15 08:31:06 -04:00
describe('updateProjectWithLocks', function () {
describe('rename operations', function () {
beforeEach(function () {
this.firstDocUpdate = {
type: 'rename-doc',
id: 1,
pathname: 'foo',
2021-07-13 07:04:42 -04:00
newPathname: 'foo',
}
this.secondDocUpdate = {
type: 'rename-doc',
id: 2,
pathname: 'bar',
2021-07-13 07:04:42 -04:00
newPathname: 'bar2',
}
this.firstFileUpdate = {
type: 'rename-file',
id: 2,
pathname: 'bar',
2021-07-13 07:04:42 -04:00
newPathname: 'bar2',
}
this.updates = [
this.firstDocUpdate,
this.secondDocUpdate,
2021-07-13 07:04:42 -04:00
this.firstFileUpdate,
]
})
describe('successfully', function () {
beforeEach(function () {
2020-05-15 08:31:06 -04:00
this.ProjectManager.updateProjectWithLocks(
this.project_id,
this.projectHistoryId,
this.user_id,
this.updates,
this.version,
this.source,
this.callback
)
})
it('should rename the docs in the updates', function () {
const firstDocUpdateWithVersion = _.extend({}, this.firstDocUpdate, {
2021-07-13 07:04:42 -04:00
version: `${this.version}.0`,
})
const secondDocUpdateWithVersion = _.extend(
{},
this.secondDocUpdate,
{ version: `${this.version}.1` }
)
this.DocumentManager.renameDocWithLock
.calledWith(
this.project_id,
this.firstDocUpdate.id,
this.user_id,
firstDocUpdateWithVersion,
this.projectHistoryId
)
.should.equal(true)
2020-05-15 08:31:06 -04:00
this.DocumentManager.renameDocWithLock
.calledWith(
this.project_id,
this.secondDocUpdate.id,
this.user_id,
secondDocUpdateWithVersion,
this.projectHistoryId
)
.should.equal(true)
})
it('should rename the files in the updates', function () {
const firstFileUpdateWithVersion = _.extend(
{},
this.firstFileUpdate,
{ version: `${this.version}.2` }
)
2020-05-15 08:31:06 -04:00
this.ProjectHistoryRedisManager.queueRenameEntity
.calledWith(
this.project_id,
this.projectHistoryId,
'file',
this.firstFileUpdate.id,
this.user_id,
firstFileUpdateWithVersion,
this.source
)
.should.equal(true)
})
it('should not flush the history', function () {
2020-05-15 08:31:06 -04:00
this.HistoryManager.flushProjectChangesAsync
.calledWith(this.project_id)
.should.equal(false)
})
2020-05-15 08:31:06 -04:00
it('should call the callback', function () {
this.callback.called.should.equal(true)
})
})
describe('when renaming a doc fails', function () {
beforeEach(function () {
this.error = new Error('error')
2020-05-15 08:40:11 -04:00
this.DocumentManager.renameDocWithLock.yields(this.error)
2020-05-15 08:31:06 -04:00
this.ProjectManager.updateProjectWithLocks(
this.project_id,
this.projectHistoryId,
this.user_id,
this.updates,
this.version,
this.source,
this.callback
)
})
2020-05-15 08:31:06 -04:00
it('should call the callback with the error', function () {
this.callback.calledWith(this.error).should.equal(true)
})
})
describe('when renaming a file fails', function () {
beforeEach(function () {
this.error = new Error('error')
2020-05-15 08:40:11 -04:00
this.ProjectHistoryRedisManager.queueRenameEntity.yields(this.error)
2020-05-15 08:31:06 -04:00
this.ProjectManager.updateProjectWithLocks(
this.project_id,
this.projectHistoryId,
this.user_id,
this.updates,
this.version,
this.source,
this.callback
)
})
2020-05-15 08:31:06 -04:00
it('should call the callback with the error', function () {
this.callback.calledWith(this.error).should.equal(true)
})
})
2020-05-15 08:31:06 -04:00
describe('with enough ops to flush', function () {
beforeEach(function () {
2020-05-15 08:40:11 -04:00
this.HistoryManager.shouldFlushHistoryOps.returns(true)
2020-05-15 08:31:06 -04:00
this.ProjectManager.updateProjectWithLocks(
this.project_id,
this.projectHistoryId,
this.user_id,
this.updates,
this.version,
this.source,
this.callback
)
})
2020-05-15 08:31:06 -04:00
it('should flush the history', function () {
this.HistoryManager.flushProjectChangesAsync
.calledWith(this.project_id)
.should.equal(true)
})
})
})
2020-05-15 08:31:06 -04:00
describe('add operations', function () {
beforeEach(function () {
this.firstDocUpdate = {
type: 'add-doc',
id: 1,
2021-07-13 07:04:42 -04:00
docLines: 'a\nb',
}
this.secondDocUpdate = {
type: 'add-doc',
id: 2,
2021-07-13 07:04:42 -04:00
docLines: 'a\nb',
}
this.firstFileUpdate = {
type: 'add-file',
id: 3,
2021-07-13 07:04:42 -04:00
url: 'filestore.example.com/2',
}
this.secondFileUpdate = {
type: 'add-file',
id: 4,
2021-07-13 07:04:42 -04:00
url: 'filestore.example.com/3',
}
this.updates = [
this.firstDocUpdate,
this.secondDocUpdate,
this.firstFileUpdate,
2021-07-13 07:04:42 -04:00
this.secondFileUpdate,
]
})
describe('successfully', function () {
beforeEach(function () {
2020-05-15 08:31:06 -04:00
this.ProjectManager.updateProjectWithLocks(
this.project_id,
this.projectHistoryId,
this.user_id,
this.updates,
this.version,
this.source,
this.callback
)
})
it('should add the docs in the updates', function () {
const firstDocUpdateWithVersion = _.extend({}, this.firstDocUpdate, {
2021-07-13 07:04:42 -04:00
version: `${this.version}.0`,
})
const secondDocUpdateWithVersion = _.extend(
{},
this.secondDocUpdate,
{ version: `${this.version}.1` }
)
this.ProjectHistoryRedisManager.queueAddEntity
.getCall(0)
.calledWith(
this.project_id,
this.projectHistoryId,
'doc',
this.firstDocUpdate.id,
this.user_id,
firstDocUpdateWithVersion,
this.source
)
.should.equal(true)
2020-05-15 08:31:06 -04:00
this.ProjectHistoryRedisManager.queueAddEntity
.getCall(1)
.calledWith(
this.project_id,
this.projectHistoryId,
'doc',
this.secondDocUpdate.id,
this.user_id,
secondDocUpdateWithVersion,
this.source
)
.should.equal(true)
})
it('should add the files in the updates', function () {
const firstFileUpdateWithVersion = _.extend(
{},
this.firstFileUpdate,
{ version: `${this.version}.2` }
)
const secondFileUpdateWithVersion = _.extend(
{},
this.secondFileUpdate,
{ version: `${this.version}.3` }
)
this.ProjectHistoryRedisManager.queueAddEntity
.getCall(2)
.calledWith(
this.project_id,
this.projectHistoryId,
'file',
this.firstFileUpdate.id,
this.user_id,
firstFileUpdateWithVersion,
this.source
)
.should.equal(true)
2020-05-15 08:31:06 -04:00
this.ProjectHistoryRedisManager.queueAddEntity
.getCall(3)
.calledWith(
this.project_id,
this.projectHistoryId,
'file',
this.secondFileUpdate.id,
this.user_id,
secondFileUpdateWithVersion,
this.source
)
.should.equal(true)
})
it('should not flush the history', function () {
2020-05-15 08:31:06 -04:00
this.HistoryManager.flushProjectChangesAsync
.calledWith(this.project_id)
.should.equal(false)
})
2020-05-15 08:31:06 -04:00
it('should call the callback', function () {
this.callback.called.should.equal(true)
})
})
describe('when adding a doc fails', function () {
beforeEach(function () {
this.error = new Error('error')
2020-05-15 08:40:11 -04:00
this.ProjectHistoryRedisManager.queueAddEntity.yields(this.error)
2020-05-15 08:31:06 -04:00
this.ProjectManager.updateProjectWithLocks(
this.project_id,
this.projectHistoryId,
this.user_id,
this.updates,
this.version,
this.source,
this.callback
)
})
2020-05-15 08:31:06 -04:00
it('should call the callback with the error', function () {
this.callback.calledWith(this.error).should.equal(true)
})
})
describe('when adding a file fails', function () {
beforeEach(function () {
this.error = new Error('error')
2020-05-15 08:40:11 -04:00
this.ProjectHistoryRedisManager.queueAddEntity.yields(this.error)
2020-05-15 08:31:06 -04:00
this.ProjectManager.updateProjectWithLocks(
this.project_id,
this.projectHistoryId,
this.user_id,
this.updates,
this.version,
this.source,
this.callback
)
})
2020-05-15 08:31:06 -04:00
it('should call the callback with the error', function () {
this.callback.calledWith(this.error).should.equal(true)
})
})
2020-05-15 08:31:06 -04:00
describe('with enough ops to flush', function () {
beforeEach(function () {
2020-05-15 08:40:11 -04:00
this.HistoryManager.shouldFlushHistoryOps.returns(true)
2020-05-15 08:31:06 -04:00
this.ProjectManager.updateProjectWithLocks(
this.project_id,
this.projectHistoryId,
this.user_id,
this.updates,
this.version,
this.source,
this.callback
)
})
2020-05-15 08:31:06 -04:00
it('should flush the history', function () {
this.HistoryManager.flushProjectChangesAsync
.calledWith(this.project_id)
.should.equal(true)
})
})
})
describe('when given an unknown operation type', function () {
beforeEach(function () {
this.updates = [{ type: 'brew-coffee' }]
this.ProjectManager.updateProjectWithLocks(
this.project_id,
this.projectHistoryId,
this.user_id,
this.updates,
this.version,
this.source,
this.callback
)
})
it('should call back with an error', function () {
this.callback.calledWith(sinon.match.instanceOf(Error)).should.be.true
})
})
})
})