Free and open source manga reader for Android
Find a file
MajorTanya 617bf491ee
Fix DelayedTrackingUpdateJob spam on update errors (#411)
* Fix DelayedTrackingUpdateJob spam on update errors

DelayedTrackingUpdateJob would start spamming when it encountered an
error (e.g. a tracker has an issue) and never stop.
This seems to stem from a circular dependency between the Job's
`doWork` and TrackChapter's `await`.

TrackChapter sets up a completely new instance of the
DelayedTrackingUpdateJob if any Exception was thrown during the track
update.

This causes the Job to get replaced (as per the WorkManager's set
ExistingWorkPolicy).

Because of this, the guard clause at the start of doWork would never
trigger, as all instances of the Job would report being the 0th try
(because they were completely new instances).

This simple fix introduces a boolean `isRetry` parameter to
TrackChapter's await method, which is set to `false` by default.
DelayedTrackingUpdateJob however sets this parameter to `true`, which
means TrackChapter won't try to set up the Job again.

* Rename isRetry parameter to setupJobOnFailure

This also inverts the logic, so true & false were swapped.
2024-02-19 00:57:50 +06:00
.github [skip ci] Add Dependencies label to Renovate Dependencies (#354) 2024-02-07 03:18:04 +06:00
.idea Update project icon 2024-01-17 13:29:42 +06:00
app Fix DelayedTrackingUpdateJob spam on update errors (#411) 2024-02-19 00:57:50 +06:00
buildSrc Adding Detekt in the project (#216) 2024-01-29 03:29:55 +06:00
config/detekt Tweak detekt config 2024-02-17 04:25:41 +06:00
core/common Don't copy archives to temp files when opening (#326) 2024-02-03 23:33:18 +06:00
core-metadata Adding Type-safe project accessors (#194) 2024-01-23 18:35:58 +06:00
data Move :core to :core:common 2024-01-29 15:20:21 +06:00
domain Move :core to :core:common 2024-01-29 15:20:21 +06:00
gradle Update dependency androidx.test.ext:junit-ktx to v1.2.0-alpha03 (#340) 2024-02-14 01:54:37 +06:00
i18n Translations update from Hosted Weblate (#269) 2024-01-30 02:31:16 +06:00
macrobenchmark Switch to different ktlint plugin 2023-09-01 23:02:18 -04:00
presentation-core Move :core to :core:common 2024-01-29 15:20:21 +06:00
presentation-widget Move :core to :core:common 2024-01-29 15:20:21 +06:00
source-api Move :core to :core:common 2024-01-29 15:20:21 +06:00
source-local Fix extracting ComicInfo.xml files in local source (#325) 2024-02-04 13:27:46 +06:00
.editorconfig Restrict line length with ktlint 2023-11-04 23:28:41 -04:00
.gitattributes Mark JAR as binary too 2020-01-11 16:13:08 -05:00
.gitignore Add project icon (#9972) 2023-10-01 10:07:14 -04:00
build.gradle.kts Adding Detekt in the project (#216) 2024-01-29 03:29:55 +06:00
CODE_OF_CONDUCT.md Replace several reference of Tachiyomi to Mihon 2024-01-15 23:53:13 +06:00
CONTRIBUTING.md Rename master branch to main 2024-01-16 01:36:08 +06:00
gradle.properties Update gradle.properties 2024-02-17 03:35:46 +06:00
gradlew Bump dependencies 2023-06-30 22:09:07 -04:00
gradlew.bat Update dependency gradle to v7.6 (#8630) 2022-11-26 21:36:46 -05:00
LICENSE Remove License Appendix That Should Have Been Removed Initially (#4158) 2020-12-19 18:41:02 -05:00
README.md [skip ci] Tweak README.md (#353) 2024-02-07 13:54:37 +06:00
settings.gradle.kts Move :core to :core:common 2024-01-29 15:20:21 +06:00

Mihon logo

Mihon App

Discover and read manga, webtoons, comics, and more easier than ever on your Android device.

Discord server GitHub downloads

CI License: Apache-2.0 Translation status

Download

Mihon Stable Mihon Beta

Requires Android 8.0 or higher.

Features

  • Local reading of content.
  • A configurable reader with multiple viewers, reading directions and other settings.
  • Tracker support: MyAnimeList, AniList, Kitsu, MangaUpdates, Shikimori, and Bangumi support.
  • Categories to organize your library.
  • Light and dark themes.
  • Schedule updating your library for new chapters.
  • Create backups locally to read offline or to your desired cloud service.
  • Plus much more...

Contributing

Code of conduct · Contributing guide

Pull requests are welcome. For major changes, please open an issue first to discuss what you would like to change.

Before reporting a new issue, take a look at the FAQ, the changelog and the already opened issues; if you got any questions, join our Discord server.

Repositories

mihonapp/website - GitHub mihonapp/bitmap.kt - GitHub

Credits

Thank you to all the people who have contributed!

Mihon app contributors

Disclaimer

The developer(s) of this application does not have any affiliation with the content providers available, and this application hosts zero content.

License

Copyright © 2015 Javier Tomás
Copyright © 2024 The Mihon Open Source Project

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.