Commit graph

2330 commits

Author SHA1 Message Date
arkon
940c5b3838 Refactor BaseBottomSheetDialog to set maxWidth with newer API 2021-05-19 22:20:45 -04:00
Hunter Nickel
19f39fcdb0
Change ordering of labels in "when" clause (#5103) 2021-05-18 08:08:23 -04:00
arkon
ab021c1302 Restore original preference background after highlight animation (fixes #5094) 2021-05-17 17:32:10 -04:00
arkon
3b11ad8de8 Revert hide updates/history 2021-05-17 17:24:59 -04:00
Riztard Lanthorn
cf4b870846
library update notif text progress (#5098) 2021-05-17 17:20:58 -04:00
arkon
5e37f72d74 Remove legacy backup creation 2021-05-17 11:41:12 -04:00
arkon
09c07faafd Avoid invalid reading mode/orientation selections
Related to #5068
2021-05-15 15:29:21 -04:00
arkon
8e7c235ff0 Cleanup hide updates/history button settings 2021-05-15 15:03:09 -04:00
simakover
7fb4cbb8a0
Add option to hide "Updates" and "History" buttons (#5077)
* Add otion to hide "Updates" abd "History" buttons

* Add otion to hide "Updates" abd "History" buttons

* explicit imports

* New category Navigation

* Add functionality for SideNav
2021-05-15 15:01:05 -04:00
arkon
fa872f6cf7 Don't hide side nav when opening ActionToolbar on tablets 2021-05-14 18:26:39 -04:00
arkon
ef53d4ec07 Fix grid columns on tablets, split out common main_activity layout sections 2021-05-14 17:48:11 -04:00
arkon
c68e7c8da7 Update OneWayFadeChangeHandler to match TachiyomiSY
Co-authored-by: jobobby04 <jobobby04@users.noreply.github.com>
2021-05-14 10:40:38 -04:00
arkon
de35a4c62a Initial tablet NavigationRailView implementation
TODO:
- Make the side nav go beside the toolbar too
- Extract out common main_activity stuff to remove duplicated code
2021-05-14 09:14:42 -04:00
arkon
fcde6c2b84 Minor cleanup 2021-05-14 09:10:17 -04:00
Ivan Iskandar
818468c58f
Open migrated/copied MangaController right away (#5005) 2021-05-13 17:36:05 -04:00
Riztard Lanthorn
7ba43ae5c2
Add cancel all for series in download queue (#5062)
Co-authored-by: Jays2Kings <jays@outlook.com>
2021-05-13 17:35:47 -04:00
arkon
5700c7a0c7 Instantiate extension preferences with proper datastore earlier 2021-05-08 19:52:49 -04:00
Andreas
4bfd395d9f
Add automatic setting to reader settings (#5045) 2021-05-08 18:55:27 -04:00
arkon
5069d8dee6 Fix MultiSelectListPreference crash in extensions 2021-05-08 17:23:48 -04:00
arkon
47c120e58c Fix rotation shortcut tooltip 2021-05-08 09:14:01 -04:00
arkon
8d7ab13f5c Don't toggle favorite status from snackbar if already added (fixes #5038) 2021-05-08 09:13:49 -04:00
Andreas
122cdae5bc
Automatic background color for PagerViewer (#4996)
* Add J2K implementation of automatic background

Co-authored-by: Jays2Kings <8617760+Jays2Kings@users.noreply.github.com>

* Tweak the monstrosity called automatic background

* Add ability to choose Automatic as a background

* More tweaks

Co-authored-by: Jays2Kings <8617760+Jays2Kings@users.noreply.github.com>
2021-05-04 22:46:42 -04:00
arkon
8d58a8d548 Fix source filter FAB disappear on rotation (fixes #4994) 2021-05-02 13:34:53 -04:00
arkon
b453be081e Fix settings search crash (fixes #5002)
Can't lateinit since the controllers are instantiated via reflection.
2021-05-02 13:29:20 -04:00
arkon
3c947f323f Fix navigation issue when activity is recreated 2021-05-02 13:22:32 -04:00
Ivan Iskandar
cb203ef02c
Show notification to disable Incognito Mode when it's enabled (#4976)
* Show notification to disable Incognito Mode when it's enabled

* Finish ReaderActivity and BrowseSourceController when incognito is disabled

* CLeanup strings

* Only register DisableIncognitoReceiver when needed
2021-04-30 22:36:54 -04:00
arkon
908c9bc624 Reader grayscale filter (closes #2822) 2021-04-30 22:35:49 -04:00
Andreas
fe373a95a2
Fix bugs in dual-page split (#4983)
If more bugs appear probably better to go back to the main thread and process dual-pages every time a page is shown as it did before
2021-04-30 09:14:20 -04:00
arkon
284c019b32 Cancel scope in SettingsControllers properly 2021-04-28 17:38:41 -04:00
Jays2Kings
6a4c280235 Change string chop method default to use smaller ... instead
(cherry picked from commit 43b42f8d54bf8872b4fd2467b33fa06a9a44dbb6)
2021-04-28 17:30:22 -04:00
arkon
f0eacf4218 Re-enable update check job for Android M 2021-04-28 08:55:30 -04:00
arkon
0afe3011bc Better handling of coroutine cancellations for http calls
Based on b94b7eeb6d
2021-04-28 08:53:41 -04:00
Andreas
0fef546a0d
Add manga-wised rotation mode settings (#4841)
* Add manga-wised rotation mode settings

Based on #3522

Co-authored-by: bboyz269 <4453811+bboyz269@users.noreply.github.com>

* Fix small mistakes

* Complete TODOs

* Rename functions

rotation -> orientation

* Fix orientation icon not changing

Bug from video

* Fix bug with force portrait not being force if a default value

Bug from video

* Backup viewer_flag as a seperate field in so legacy/forks doesn't crash

* Make viewer_flags nullable so old backups viewer gets restored

* Add migration for old rotation and viewer to new defaults ones

* Rename variable in enums

* Fix migration after OrientationType was changed

* Remove untrue comment

Co-authored-by: bboyz269 <4453811+bboyz269@users.noreply.github.com>
2021-04-28 08:32:47 -04:00
Ivan Iskandar
93e6136795
Use Coil (#4870)
* Use Coil

* Remove coil-transformations lib

* Add MangaCoverFetcher

* Remove Glide

* MangaCoverFetcher: Allow skipping custom cover usage

* Adjust coil caching policy for some non-library items

* Allow coil to use RGB565 only on low ram devices

* Fix image loading progress view not showing

a

* Increase coil crossfade duration

Same as default glide duration

* Add back request clearing
2021-04-28 08:32:00 -04:00
arkon
71c9df5279 Lint fixes 2021-04-27 17:46:34 -04:00
arkon
224fcada17 Move save pages to manga title setting to Reader section 2021-04-27 17:46:16 -04:00
OncePunchedMan
9278407b85
Setting: Creates folders according to manga title (#4861)
* cherry-picking my changes

* Update SettingsDownloadController.kt

* Update SettingsDownloadController.kt

* Update ReaderPresenter.kt

Co-authored-by: arkon <arkon@users.noreply.github.com>
2021-04-27 17:38:56 -04:00
arkon
89619b7836 Drop support for Android 5.x 2021-04-27 09:29:05 -04:00
arkon
13324dd1a1 Remove app update check on Android 5.x 2021-04-27 09:26:46 -04:00
Ivan Iskandar
bf80dd622c
Fix download error icon color tint (#4959)
* Fix download error color tint

* Use progress indicator as download icon border

* Resolve feedback

* Use extension function to set tinted drawable
2021-04-25 11:36:13 -04:00
Andreas
662b71436e
Cleanup dual page split (#4956)
* Cleanup Dual Page Split

* Move where images is processed

* Change parameter name to imageStream

* Use available instead of Int.MAX_VALUE

* Update JavaDoc
2021-04-25 11:08:51 -04:00
arkon
f608cb55eb Minor cleanup to updating download status in Updates 2021-04-25 11:01:12 -04:00
arkon
6ba82da029 Don't automatically go to HALF_EXPANDED state for color filter tab (closes #4913) 2021-04-25 10:59:53 -04:00
arkon
f407e30b6e Reset Incognito Mode on app relaunch (closes #4928) 2021-04-25 10:57:14 -04:00
Ivan Iskandar
4e7b8c98f9
Make the download progress status smoother (#4958)
* Make the download progress status smoother

* Download status icon cleanup
2021-04-25 10:42:06 -04:00
arkon
5f9574541f Use popup menus for reader shortcuts instead of toggling through 2021-04-24 19:17:52 -04:00
arkon
08a6db7d6e Maybe better handle MAL token expiration 2021-04-24 16:30:53 -04:00
arkon
e8d8621f06 Remove "Locked" orientation, replace with explicit orientations
Portrait/Landscape allow sensor, Locked Portrait/Landscape don't.
2021-04-23 22:37:43 -04:00
arkon
4cefbce7c3 Make manga and chapter folder name searching case insensitive 2021-04-23 08:44:12 -04:00
arkon
fa31369f99 Sanitize source download folder name (fixes #4945) 2021-04-23 08:43:47 -04:00
Ivan Iskandar
d0bf93ebb7
MainActivity: Show bottom nav when the tab page is changed (#4914)
* MainActivity: Show bottom nav when the tab page is changed

* Revert "MainActivity: Show bottom nav when the tab page is changed"

This reverts commit 27fd73db

* MainActivity: Show bottom nav when the app bar is fully expanded
2021-04-21 17:43:53 -04:00
arkon
41a747c7e7 Consider sort direction when downloading next n chapters (fixes #4916) 2021-04-21 17:41:43 -04:00
arkon
8882cd4787 Consider sort direction when resuming (fixes #4909) 2021-04-21 17:38:46 -04:00
arkon
6676490e09 Remove preview release notes
The GitHub releases contain the commit messages.
2021-04-19 15:30:04 -04:00
arkon
68bea8a196 Add link to official Facebook page 2021-04-19 15:23:20 -04:00
arkon
dd1743698f Theme BiometricUnlockActivity to avoid flashing light theme 2021-04-19 10:24:57 -04:00
arkon
b092e98ac9 Include extension loading errors in error logs 2021-04-19 10:18:32 -04:00
arkon
9ee6262aed Fix activity leak 2021-04-19 10:18:32 -04:00
arkon
7654feb6a8 Fix chapter read status not being migrated (fixes #4892) 2021-04-18 13:07:53 -04:00
arkon
cab919d74c Clean up controller viewbinding creation
Based on https://github.com/Jays2Kings/tachiyomiJ2K/blob/master/app/src/main/java/eu/kanade/tachiyomi/ui/base/controller/BaseController.kt
2021-04-18 12:54:51 -04:00
Ivan Iskandar
60a929b92c
Fix source SearchView stuck open until query submitted (#4897)
closes #4850
2021-04-18 11:32:22 -04:00
arkon
356b7c346a Clean up ChapterCache (remove Gson, Rx usage) 2021-04-18 11:30:16 -04:00
Ivan Iskandar
ad57fde1c5
Themes cleanup (#4894) 2021-04-18 11:29:56 -04:00
arkon
b40af7c3c6 Minor cleanup 2021-04-17 19:05:35 -04:00
arkon
9065362fde Move reading mode toast to default bottom position
Toasts don't block user interaction, so it's probably fine.
2021-04-17 18:52:52 -04:00
arkon
ad9bad3d17 Adjust ActionToolbar positioning
Have I ever mentioned that I hate insets?
2021-04-17 13:07:25 -04:00
arkon
dfd858034f Avoid duplicate actions in update notifications 2021-04-17 12:58:14 -04:00
arkon
38610d8a24 Avoid crash when users copying to clipboard fails because they have apps that are listening to their clipboards but also denied permissions
See https://commonsware.com/blog/2013/08/08/developer-psa-please-fix-your-clipboard-handling.html
2021-04-17 12:29:22 -04:00
arkon
27cec697bf Avoid rare crash in WebViewActivity 2021-04-17 12:22:58 -04:00
arkon
f7cc36f2f0 Follow chapter sort setting for start/resume FAB (closes #1716) 2021-04-17 11:38:08 -04:00
arkon
ef5148ebb4 Double tap Updates to go to Download Queue (closes #4884) 2021-04-17 11:13:09 -04:00
arkon
6dbc0a6fd5 Use DSL for creating chapter description spanned string 2021-04-17 11:06:30 -04:00
arkon
fba3f9d501 Follow chapter sort setting when downloading next n chapters (closes #4725) 2021-04-17 10:51:38 -04:00
arkon
28416489b2 Adjust MoreController bottom padding for navbar 2021-04-16 23:10:38 -04:00
arkon
54a23ddd1f Long press reader settings icon to open color filter tab
Partially addresses #4867
2021-04-16 23:06:24 -04:00
arkon
3287ca9cf2 Add checkmark beside selected popup menu item
Based on what's in J2K. Also renamed to MaterialSpinnerView to match what's there.

Co-authored-by: Jays2Kings <Jays2Kings@users.noreply.github.com>
2021-04-16 22:39:19 -04:00
arkon
a59e134862 Case insensitive source directory search 2021-04-16 22:27:00 -04:00
arkon
1f8c5b0120 Adjust ActionToolbar positioning 2021-04-16 22:26:41 -04:00
arkon
c7f839ea4a Minor cleanup 2021-04-15 10:09:16 -04:00
arkon
d981245723 Remove toolbar snapping 2021-04-15 10:05:47 -04:00
Ivan Iskandar
1f729f1cb3
Add navigation bar scrim (#4845)
* Revert "Add navigation bar scrim (closes #4836)"

This reverts commit 2a69d1b0

* Add navigation bar scrim
2021-04-15 09:55:39 -04:00
arkon
b4577d6676 Avoid crash when unknown reading mode is used 2021-04-14 18:03:48 -04:00
arkon
1875c4a752 Include chapter fetch date when migrating
Based on ee4f3e6586

Co-authored-by: Jays2Kings <Jays2Kings@users.noreply.github.com>
2021-04-14 08:57:00 -04:00
Jays2Kings
5f0493f1e5 Fix webtoon mode not calling OnPageSelected in some cases (in upstream too)
This fix isn't 100% tested, but like 80%.

@arkon if you're reading this, this issue is happening up stream too. I can make a issue for it in the repo but haven't checked if it happens there:

Steps:
Get Cubari source, search "cubari:imgur/3iOqiIy" change to continuous vertical, crop borders. Then back out and open the chapter again. onPageSelected isn't called because recycler position is -1. Regardless of the 4 pages you should be on

also fyi just a slight scroll fixes this issue but still

(cherry picked from commit 88fd6e5c9897d4a528f93dd02cfa2a4c644a799d)
2021-04-14 08:49:48 -04:00
arkon
c749e50bec Edge-to-edge in licenses activity 2021-04-13 22:48:54 -04:00
arkon
2a69d1b051 Add navigation bar scrim (closes #4836) 2021-04-13 18:23:06 -04:00
arkon
126e1e2d9d Allow weaker unlock methods in Android 6 - 10 (fixes #4833) 2021-04-13 15:02:57 -04:00
arkon
0586e1d3ad Include debug info in dumped crash logs 2021-04-13 09:06:41 -04:00
arkon
07cb1c237e Allow dismissing download progress notification when paused (closes #4832) 2021-04-13 08:53:46 -04:00
arkon
37fdf4d434 Fix toolbar elevation in History and Updates 2021-04-12 18:43:22 -04:00
arkon
99b46096a4 Fully expand source filter sheet on show (closes #4455) 2021-04-12 17:30:44 -04:00
arkon
12e90ae35e Use same non-sticky heading style as Browse for Updates/History (closes #4822) 2021-04-12 17:11:47 -04:00
arkon
023311a874 Start download when tapping update notification (closes #4825) 2021-04-12 13:43:46 -04:00
arkon
155a4dd463 Fix ActionToolbar bottom offset 2021-04-12 12:42:07 -04:00
arkon
15bed1ac4c Offset appbar using margin instead (maybe fixes #4819) 2021-04-12 09:01:11 -04:00
arkon
00598879e2 Insets fix for migration manga list 2021-04-11 22:57:54 -04:00
arkon
0dc4862d79 Revert case insensitive source folder check 2021-04-11 18:19:41 -04:00
arkon
a3f1b72126 Lint fixes/ignore some errors 2021-04-11 18:16:15 -04:00
arkon
a82e5f5452 Make library update/backup error log action clearer for non-technical users 2021-04-11 16:19:56 -04:00
arkon
e10cb0e632 Add locales: jv, lt, ne 2021-04-11 16:03:03 -04:00
arkon
592050c668 Actually ignore the case... 2021-04-11 14:23:24 -04:00
arkon
02c9191525 Make source download folder name case-insensitive
Fixes issues from things like "Mangasee" being renamed to "MangaSee"
2021-04-11 14:03:23 -04:00
arkon
d421401626 Log "Invalid download location" issues to error log 2021-04-11 14:00:45 -04:00
arkon
b2d4e5ab84 Add Google DoH provider 2021-04-11 13:10:03 -04:00
Ivan Iskandar
84e023607c
BrowseSourceController: Fix navigation bar insets not properly applied (#4810) 2021-04-11 10:49:23 -04:00
Ken Swenson
f145fd0dec
Move deletion actions to the IO thread (#4808) 2021-04-11 10:49:13 -04:00
arkon
9567d55312 Revert manga title folder for saved pages (closes #4803)
People also didn't like it making their galleries more complicate to navigate.
2021-04-10 14:33:14 -04:00
Ivan Iskandar
f3660d88dd
Draw edge-to-edge (#4802) 2021-04-10 09:38:55 -04:00
Riztard Lanthorn
01c3498dbf
Search in library include manga description (#4787)
Co-Authored-By: jobobby04 <jobobby04@gmail.com>

Co-authored-by: jobobby04 <jobobby04@gmail.com>
2021-04-08 17:56:33 -04:00
Taco
b3471234ad
Update NDK, more KTX usage (#4792)
* Update NDK

* Utilize more KTX extensions
2021-04-08 17:56:01 -04:00
arkon
b2d697131c Add clarification for category exclusion (closes #4777) 2021-04-06 23:29:46 -04:00
arkon
ef49fc91d8 Minor cleanup 2021-04-06 23:21:21 -04:00
arkon
6222b47a4f Flip crop borders and orientation toggles 2021-04-06 22:31:36 -04:00
arkon
5b23f29d06 Revert using fetch date for updates list
Spamming the list post-migration is currently a more common usecase than sources without chapter dates. We'll need to figure out a better way of handling both scenarios.
2021-04-04 18:11:11 -04:00
arkon
c1bdebee78 Fix global update category exclusion 2021-04-04 18:09:07 -04:00
Riztard Lanthorn
ddd4cc10ff
add sort by date fetched in library (#4773)
* add sort by date fetched in library

* chapter fetch date to 8
2021-04-04 17:18:28 -04:00
arkon
0ca62a4acc Allow excluding categories from auto-download
Closes #1412

Supersedes #4121
2021-04-04 17:15:06 -04:00
arkon
4f1275ac01 Allow excluding categories from library update
Closes #3467, #4661, #1839

Supersedes #4474
2021-04-04 16:48:39 -04:00
arkon
b2fee7035f Use Material Dialogs for auto-download categories preference
To allow for negative selections in the future.
2021-04-03 16:13:12 -04:00
arkon
e15d7cb548 Use Material Dialogs for global update categories preference
To allow for negative selections in the future.
2021-04-03 16:07:42 -04:00
arkon
1237af1ff3 Move BiometricUtil to correct package 2021-04-03 11:38:01 -04:00
arkon
68600b337e Allow weaker unlock methods (closes #4265) 2021-04-03 11:35:33 -04:00
arkon
dac2072eaa Use app name for page download folder and use manga title subfolders (closes #4684) 2021-04-03 10:40:35 -04:00
arkon
1b921f9845 Make extension load error logs less verbose 2021-04-03 10:27:40 -04:00
arkon
a3992d9fbe Minor cleanup 2021-04-03 10:12:31 -04:00
Tooster
efd2a0cb7b
Replace reading mode snackbar with toast (#4752) 2021-04-03 10:07:49 -04:00
arkon
ff36901007 Don't repeatedly vibrate/make sounds on download progress 2021-04-01 12:18:54 -04:00
arkon
940d8389b5 Add QuadStateCheckBox view 2021-03-31 23:03:42 -04:00
arkon
f7a6cbe5e2 Revert "Drop support for Android 5.x"
This reverts commit 443024cebb. Guess I'll do this a bit later so scb can get another major update first.

April Fools or whatever.
2021-03-31 22:20:59 -04:00
arkon
7aa379a857 Better handle webtoon SSIV crop border change 2021-03-31 22:20:17 -04:00
arkon
443024cebb Drop support for Android 5.x
It's 5-6 years old, and only accounts for 2% of users in the Firebase analytics.
2021-03-30 23:15:17 -04:00
arkon
1657f04d55 Add tooltips for previous/next chapter buttons
Based on d0738f5b00
2021-03-30 23:11:36 -04:00
arkon
407e798fdb Recreate webtoon SSIV when crop borders setting changes (fixes #4734) 2021-03-30 18:47:44 -04:00
arkon
4054f2a6a0 Add icon for crop border shortcut off state 2021-03-30 18:27:09 -04:00
arkon
988ec6a224 Fix nav overlay always showing on start (fixes #4736) 2021-03-29 16:54:32 -04:00
Andreas
bdbdf211e2
Remove insert page when dual page split get turned off (#4739) 2021-03-29 16:54:20 -04:00
arkon
0437703cbf Fix binding of intarray preferences (maybe fixes #4728) 2021-03-28 17:06:56 -04:00
arkon
d501c02f8b Add crop borders shortcut 2021-03-28 16:25:53 -04:00
arkon
dfa07a5f35 Clean up SpinnerPreference a bit 2021-03-28 16:13:59 -04:00
arkon
437c995d12 Show nav overlay on invert tap change
Based on db4eca90e9
2021-03-28 16:13:34 -04:00
mutsumi
cc6ae9d1a8
Fix Some Bangumi Track Bug (#4726) 2021-03-28 11:36:29 -04:00
arkon
c87b0e77de Show number of manga per source in migrate menu (#4703) 2021-03-28 11:11:19 -04:00
arkon
355d5af8ae Dismiss action toolbar after download action in updates (closes #4729) 2021-03-28 10:59:35 -04:00
arkon
3d99a8ebdb Fix fullscreen not applying on opening reader (fixes #4723) 2021-03-28 10:48:41 -04:00
arkon
c4b975b777 Cleanup reader spinner layouts 2021-03-27 17:59:52 -04:00
Antoine Gaudreau Simard
2911fe7a1a
Add onPause\onResume persistence to searchView. Fixes issue #3627 (#4494)
* Add onPause\onResume persistence to searchView. Fixes issue #3627

* New controller subclass with built-in SearchView support

* Implement new SearchableNucleusController in SourceController

* Add query to BasePresenter (for one field it is not worth create a subclass in my opinion), convert BrowseSourceController to inherit from SearchableNucleusController

* move to flows to fix an issue in GlobalSearch where it would trigger the search multiple times

* Continue conversion to SearchableNucleusController

* Convert LibraryController, convert to flows, Known ISSUE with empty string being posted after setting the query upon creation of UI

* Fix issues with the post being tide to the SearchView queue which is not processed until shown. Add COLLAPSING state capture which should wrap this up.

* refactoring & enforce @StringRes for queryHint
2021-03-27 16:38:41 -04:00
arkon
14c114756d Clean up reader sheet spinner preferences
Based on fe2543b9d5

Co-Authored-By: Jays2Kings
2021-03-27 16:28:49 -04:00
arkon
e7a8107279 Reduce height of sheet when on color filter tab 2021-03-27 15:15:31 -04:00
arkon
bff73b1b40 Add tooltips to bottom reader menu items 2021-03-27 10:53:31 -04:00
arkon
64c47bbaed Split general and reading mode sheet settings 2021-03-26 22:31:21 -04:00