github/mihon
1
0
Fork 0
mirror of https://github.com/mihonapp/mihon.git synced 2024-11-21 20:47:03 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

pmd:ImmutableField - Immutable Field (#282)

Browse source
This commit is contained in:
Mohamed Ezzat 2016-04-28 18:46:05 +02:00 committed by inorichi
parent 9f546d13c2
commit ff6eefe1c4
8 changed files with 16 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/src/main/java/eu/kanade/tachiyomi/data/source/online/english/Batoto.java
View file

@ -54,8 +54,8 @@ public class Batoto extends LoginSource {
public static final Pattern staffNotice = Pattern.compile("=+Batoto Staff Notice=+([^=]+)==+", Pattern.CASE_INSENSITIVE); public static final Pattern staffNotice = Pattern.compile("=+Batoto Staff Notice=+([^=]+)==+", Pattern.CASE_INSENSITIVE);
private Pattern datePattern; private final Pattern datePattern;
private Map<String, Integer> dateFields; private final Map<String, Integer> dateFields;
public Batoto(Context context) { public Batoto(Context context) {
super(context); super(context);

2
app/src/main/java/eu/kanade/tachiyomi/ui/base/activity/BaseRxActivity.java
View file

@ -22,7 +22,7 @@ public abstract class BaseRxActivity<P extends Presenter> extends BaseActivity i
private static final String PRESENTER_STATE_KEY = "presenter_state"; private static final String PRESENTER_STATE_KEY = "presenter_state";
private PresenterLifecycleDelegate<P> presenterDelegate = private final PresenterLifecycleDelegate<P> presenterDelegate =
new PresenterLifecycleDelegate<>(ReflectionPresenterFactory.<P>fromViewClass(getClass())); new PresenterLifecycleDelegate<>(ReflectionPresenterFactory.<P>fromViewClass(getClass()));
/** /**

2
app/src/main/java/eu/kanade/tachiyomi/ui/base/adapter/SmartFragmentStatePagerAdapter.java
View file

@ -11,7 +11,7 @@ import java.util.List;
public abstract class SmartFragmentStatePagerAdapter extends FragmentStatePagerAdapter { public abstract class SmartFragmentStatePagerAdapter extends FragmentStatePagerAdapter {
// Sparse array to keep track of registered fragments in memory // Sparse array to keep track of registered fragments in memory
private SparseArray<Fragment> registeredFragments = new SparseArray<Fragment>(); private final SparseArray<Fragment> registeredFragments = new SparseArray<Fragment>();
public SmartFragmentStatePagerAdapter(FragmentManager fragmentManager) { public SmartFragmentStatePagerAdapter(FragmentManager fragmentManager) {
super(fragmentManager); super(fragmentManager);

2
app/src/main/java/eu/kanade/tachiyomi/ui/base/decoration/DividerItemDecoration.java
View file

@ -12,7 +12,7 @@ import android.view.View;
public class DividerItemDecoration extends RecyclerView.ItemDecoration { public class DividerItemDecoration extends RecyclerView.ItemDecoration {
private Drawable mDivider; private final Drawable mDivider;
public DividerItemDecoration(Context context, AttributeSet attrs) { public DividerItemDecoration(Context context, AttributeSet attrs) {
final TypedArray a = context.obtainStyledAttributes(attrs, new int [] { android.R.attr.listDivider }); final TypedArray a = context.obtainStyledAttributes(attrs, new int [] { android.R.attr.listDivider });

2
app/src/main/java/eu/kanade/tachiyomi/ui/base/fragment/BaseRxFragment.java
View file

@ -20,7 +20,7 @@ import nucleus.view.ViewWithPresenter;
public abstract class BaseRxFragment<P extends Presenter> extends BaseFragment implements ViewWithPresenter<P> { public abstract class BaseRxFragment<P extends Presenter> extends BaseFragment implements ViewWithPresenter<P> {
private static final String PRESENTER_STATE_KEY = "presenter_state"; private static final String PRESENTER_STATE_KEY = "presenter_state";
private PresenterLifecycleDelegate<P> presenterDelegate = private final PresenterLifecycleDelegate<P> presenterDelegate =
new PresenterLifecycleDelegate<>(ReflectionPresenterFactory.<P>fromViewClass(getClass())); new PresenterLifecycleDelegate<>(ReflectionPresenterFactory.<P>fromViewClass(getClass()));
/** /**

8
app/src/main/java/eu/kanade/tachiyomi/widget/EndlessGridScrollListener.java
View file

@ -9,12 +9,12 @@ public class EndlessGridScrollListener extends RecyclerView.OnScrollListener {
private int previousTotal = 0; // The total number of items in the dataset after the last load private int previousTotal = 0; // The total number of items in the dataset after the last load
private boolean loading = true; // True if we are still waiting for the last set of data to load. private boolean loading = true; // True if we are still waiting for the last set of data to load.
private int visibleThreshold = 5; // The minimum amount of items to have below your current scroll position before loading more. private static final int VISIBLE_THRESHOLD = 5; // The minimum amount of items to have below your current scroll position before loading more.
private int firstVisibleItem, visibleItemCount, totalItemCount; private int firstVisibleItem, visibleItemCount, totalItemCount;
private GridLayoutManager layoutManager; private final GridLayoutManager layoutManager;
private Action0 requestNext; private final Action0 requestNext;
public EndlessGridScrollListener(GridLayoutManager layoutManager, Action0 requestNext) { public EndlessGridScrollListener(GridLayoutManager layoutManager, Action0 requestNext) {
this.layoutManager = layoutManager; this.layoutManager = layoutManager;
@ -39,7 +39,7 @@ public class EndlessGridScrollListener extends RecyclerView.OnScrollListener {
previousTotal = totalItemCount; previousTotal = totalItemCount;
} }
if (!loading && (totalItemCount - visibleItemCount) if (!loading && (totalItemCount - visibleItemCount)
<= (firstVisibleItem + visibleThreshold)) { <= (firstVisibleItem + VISIBLE_THRESHOLD)) {
// End has been reached // End has been reached
requestNext.call(); requestNext.call();
loading = true; loading = true;

6
app/src/main/java/eu/kanade/tachiyomi/widget/EndlessListScrollListener.java
View file

@ -9,12 +9,12 @@ public class EndlessListScrollListener extends RecyclerView.OnScrollListener {
private int previousTotal = 0; // The total number of items in the dataset after the last load private int previousTotal = 0; // The total number of items in the dataset after the last load
private boolean loading = true; // True if we are still waiting for the last set of data to load. private boolean loading = true; // True if we are still waiting for the last set of data to load.
private int visibleThreshold = 5; // The minimum amount of items to have below your current scroll position before loading more. private static final int VISIBLE_THRESHOLD = 5; // The minimum amount of items to have below your current scroll position before loading more.
private int firstVisibleItem, visibleItemCount, totalItemCount; private int firstVisibleItem, visibleItemCount, totalItemCount;
private LinearLayoutManager layoutManager; private LinearLayoutManager layoutManager;
private Action0 requestNext; private final Action0 requestNext;
public EndlessListScrollListener(LinearLayoutManager layoutManager, Action0 requestNext) { public EndlessListScrollListener(LinearLayoutManager layoutManager, Action0 requestNext) {
this.layoutManager = layoutManager; this.layoutManager = layoutManager;
@ -39,7 +39,7 @@ public class EndlessListScrollListener extends RecyclerView.OnScrollListener {
previousTotal = totalItemCount; previousTotal = totalItemCount;
} }
if (!loading && (totalItemCount - visibleItemCount) if (!loading && (totalItemCount - visibleItemCount)
<= (firstVisibleItem + visibleThreshold)) { <= (firstVisibleItem + VISIBLE_THRESHOLD)) {
// End has been reached // End has been reached
requestNext.call(); requestNext.call();
loading = true; loading = true;

6
app/src/main/java/eu/kanade/tachiyomi/widget/EndlessScrollListener.java
View file

@ -7,13 +7,13 @@ import rx.functions.Action0;
public class EndlessScrollListener implements AbsListView.OnScrollListener { public class EndlessScrollListener implements AbsListView.OnScrollListener {
// The minimum amount of items to have below your current scroll position // The minimum amount of items to have below your current scroll position
// before loading more. // before loading more.
private int visibleThreshold = 5; private static final int VISIBLE_THRESHOLD = 5;
// The total number of items in the dataset after the last load // The total number of items in the dataset after the last load
private int previousTotalItemCount = 0; private int previousTotalItemCount = 0;
// True if we are still waiting for the last set of data to load. // True if we are still waiting for the last set of data to load.
private boolean loading = true; private boolean loading = true;
private Action0 requestNext; private final Action0 requestNext;
public EndlessScrollListener(Action0 requestNext) { public EndlessScrollListener(Action0 requestNext) {
this.requestNext = requestNext; this.requestNext = requestNext;
@ -47,7 +47,7 @@ public class EndlessScrollListener implements AbsListView.OnScrollListener {
// If it isn’t currently loading, we check to see if we have breached // If it isn’t currently loading, we check to see if we have breached
// the visibleThreshold and need to reload more data. // the visibleThreshold and need to reload more data.
// If we do need to reload some more data, we execute onLoadMore to fetch the data. // If we do need to reload some more data, we execute onLoadMore to fetch the data.
if (!loading && (totalItemCount - visibleItemCount)<=(firstVisibleItem + visibleThreshold)) { if (!loading && (totalItemCount - visibleItemCount)<=(firstVisibleItem + VISIBLE_THRESHOLD)) {
requestNext.call(); requestNext.call();
loading = true; loading = true;
} }