Make library update error notification optional (closes #3200)

This commit is contained in:
arkon 2020-05-20 17:39:01 -04:00
parent ed029c52ae
commit 647391ef73
6 changed files with 12 additions and 2 deletions

View file

@ -307,7 +307,7 @@ class LibraryUpdateService(
} }
} }
if (failedUpdates.isNotEmpty()) { if (preferences.showLibraryUpdateErrors() && failedUpdates.isNotEmpty()) {
val errorFile = writeErrorFile(failedUpdates) val errorFile = writeErrorFile(failedUpdates)
notifier.showUpdateErrorNotification( notifier.showUpdateErrorNotification(
failedUpdates.map { it.first.title }, failedUpdates.map { it.first.title },

View file

@ -123,6 +123,8 @@ object PreferenceKeys {
const val hideNotificationContent = "hide_notification_content" const val hideNotificationContent = "hide_notification_content"
const val showLibraryUpdateErrors = "show_library_update_errors"
const val downloadNew = "download_new" const val downloadNew = "download_new"
const val downloadNewCategories = "download_new_categories" const val downloadNewCategories = "download_new_categories"

View file

@ -67,6 +67,8 @@ class PreferencesHelper(val context: Context) {
fun hideNotificationContent() = prefs.getBoolean(Keys.hideNotificationContent, false) fun hideNotificationContent() = prefs.getBoolean(Keys.hideNotificationContent, false)
fun showLibraryUpdateErrors() = prefs.getBoolean(Keys.showLibraryUpdateErrors, false)
fun clear() = prefs.edit().clear().apply() fun clear() = prefs.edit().clear().apply()
fun themeMode() = flowPrefs.getString(Keys.themeMode, Values.THEME_MODE_SYSTEM) fun themeMode() = flowPrefs.getString(Keys.themeMode, Values.THEME_MODE_SYSTEM)

View file

@ -120,7 +120,7 @@ class HistoryPresenter : BasePresenter<HistoryController>() {
} }
Manga.SORTING_UPLOAD_DATE -> { Manga.SORTING_UPLOAD_DATE -> {
chapters.drop(currChapterIndex + 1) chapters.drop(currChapterIndex + 1)
.firstOrNull { it.date_upload >= chapter.date_upload} .firstOrNull { it.date_upload >= chapter.date_upload }
} }
else -> throw NotImplementedError("Unknown sorting method") else -> throw NotImplementedError("Unknown sorting method")
} }

View file

@ -164,6 +164,11 @@ class SettingsLibraryController : SettingsController() {
true true
} }
} }
switchPreference {
key = Keys.showLibraryUpdateErrors
titleRes = R.string.pref_library_update_error_notification
defaultValue = false
}
} }
preferenceCategory { preferenceCategory {

View file

@ -184,6 +184,7 @@
<string name="wifi">Wi-Fi</string> <string name="wifi">Wi-Fi</string>
<string name="charging">Charging</string> <string name="charging">Charging</string>
<string name="pref_update_only_non_completed">Only update ongoing manga</string> <string name="pref_update_only_non_completed">Only update ongoing manga</string>
<string name="pref_library_update_error_notification">Show update errors notifications</string>
<string name="pref_category_library_categories">Categories</string> <string name="pref_category_library_categories">Categories</string>
<string name="default_category">Default category</string> <string name="default_category">Default category</string>