github/mihon
1
0
Fork 0
mirror of https://github.com/mihonapp/mihon.git synced 2024-11-21 20:47:03 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Update Compose

Browse source 
Fixes #7004
This commit is contained in:
arkon 2022-05-11 22:29:28 -04:00
parent c7707dc50e
commit 393fc14630
4 changed files with 17 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
app/src/main/java/eu/kanade/presentation/components/Preferences.kt
View file

@ -62,7 +62,7 @@ fun PreferenceRow(
Icon(
painter = painter,
modifier = Modifier
.padding(horizontal = horizontalPadding)
.padding(start = horizontalPadding, end = 16.dp)
.size(24.dp),
tint = MaterialTheme.colorScheme.primary,
contentDescription = null,
@ -70,7 +70,7 @@ fun PreferenceRow(
}
Column(
Modifier
.padding(horizontal = horizontalPadding)
.padding(horizontal = 16.dp)
.weight(1f),
) {
Text(
@ -86,7 +86,11 @@ fun PreferenceRow(
}
}
if (action != null) {
Box(Modifier.widthIn(min = 56.dp)) {
Box(
Modifier
.widthIn(min = 56.dp)
.padding(end = horizontalPadding),
) {
action()
}
}
@ -106,11 +110,7 @@ fun SwitchPreference(
title = title,
subtitle = subtitle,
painter = painter,
action = {
Switch(checked = preference.value, onCheckedChange = null)
// TODO: remove this once switch checked state is fixed: https://issuetracker.google.com/issues/228336571
Text(preference.value.toString())
},
action = { Switch(checked = preference.value, onCheckedChange = null) },
onClick = { preference.value = !preference.value },
)
}

6
app/src/main/java/eu/kanade/tachiyomi/ui/base/controller/ComposeController.kt
View file

@ -30,7 +30,7 @@ abstract class ComposeController<P : Presenter<*>>(bundle: Bundle? = null) :
consumeWindowInsets = false
setViewCompositionStrategy(ViewCompositionStrategy.DisposeOnViewTreeLifecycleDestroyed)
setContent {
val nestedScrollInterop = rememberNestedScrollInteropConnection(binding.root)
val nestedScrollInterop = rememberNestedScrollInteropConnection()
TachiyomiTheme {
ComposeContent(nestedScrollInterop)
}
@ -56,7 +56,7 @@ abstract class BasicComposeController :
consumeWindowInsets = false
setViewCompositionStrategy(ViewCompositionStrategy.DisposeOnViewTreeLifecycleDestroyed)
setContent {
val nestedScrollInterop = rememberNestedScrollInteropConnection(binding.root)
val nestedScrollInterop = rememberNestedScrollInteropConnection()
TachiyomiTheme {
ComposeContent(nestedScrollInterop)
}
@ -79,7 +79,7 @@ abstract class SearchableComposeController<P : BasePresenter<*>>(bundle: Bundle?
consumeWindowInsets = false
setViewCompositionStrategy(ViewCompositionStrategy.DisposeOnViewTreeLifecycleDestroyed)
setContent {
val nestedScrollInterop = rememberNestedScrollInteropConnection(binding.root)
val nestedScrollInterop = rememberNestedScrollInteropConnection()
TachiyomiTheme {
ComposeContent(nestedScrollInterop)
}

8
gradle/compose.versions.toml
View file

@ -1,6 +1,6 @@
[versions]
compose = "1.2.0-alpha08"
accompanist = "0.24.7-alpha"
compose = "1.2.0-beta01"
accompanist = "0.24.8-beta"
[libraries]
activity = "androidx.activity:activity-compose:1.6.0-alpha03"
@ -8,8 +8,8 @@ foundation = { module = "androidx.compose.foundation:foundation", version.ref="c
animation = { module = "androidx.compose.animation:animation", version.ref="compose" }
ui-tooling = { module = "androidx.compose.ui:ui-tooling", version.ref="compose" }
material3-core = "androidx.compose.material3:material3:1.0.0-alpha10"
material3-adapter = "com.google.android.material:compose-theme-adapter-3:1.0.8"
material3-core = "androidx.compose.material3:material3:1.0.0-alpha11"
material3-adapter = "com.google.android.material:compose-theme-adapter-3:1.0.9"
material-icons = { module = "androidx.compose.material:material-icons-extended", version.ref="compose" }
accompanist-webview = { module = "com.google.accompanist:accompanist-webview", version.ref="accompanist" }

3
gradle/kotlinx.versions.toml
View file

@ -1,5 +1,5 @@
[versions]
kotlin_version = "1.6.20"
kotlin_version = "1.6.21"
coroutines_version = "1.6.1"
serialization_version = "1.3.2"
@ -19,5 +19,4 @@ coroutines = ["coroutines-core", "coroutines-android"]
serialization = ["serialization-json", "serialization-protobuf"]
[plugins]
android = { id = "org.jetbrains.kotlin.android", version.ref = "kotlin_version"}