mirror of
https://github.com/gohugoio/hugo.git
synced 2024-11-07 20:30:36 -05:00
7285e74090
There are some breaking changes in this commit, see #11455. Closes #11455 Closes #11549 This fixes a set of bugs (see issue list) and it is also paying some technical debt accumulated over the years. We now build with Staticcheck enabled in the CI build. The performance should be about the same as before for regular sized Hugo sites, but it should perform and scale much better to larger data sets, as objects that uses lots of memory (e.g. rendered Markdown, big JSON files read into maps with transform.Unmarshal etc.) will now get automatically garbage collected if needed. Performance on partial rebuilds when running the server in fast render mode should be the same, but the change detection should be much more accurate. A list of the notable new features: * A new dependency tracker that covers (almost) all of Hugo's API and is used to do fine grained partial rebuilds when running the server. * A new and simpler tree document store which allows fast lookups and prefix-walking in all dimensions (e.g. language) concurrently. * You can now configure an upper memory limit allowing for much larger data sets and/or running on lower specced PCs. We have lifted the "no resources in sub folders" restriction for branch bundles (e.g. sections). Memory Limit * Hugos will, by default, set aside a quarter of the total system memory, but you can set this via the OS environment variable HUGO_MEMORYLIMIT (in gigabytes). This is backed by a partitioned LRU cache used throughout Hugo. A cache that gets dynamically resized in low memory situations, allowing Go's Garbage Collector to free the memory. New Dependency Tracker: Hugo has had a rule based coarse grained approach to server rebuilds that has worked mostly pretty well, but there have been some surprises (e.g. stale content). This is now revamped with a new dependency tracker that can quickly calculate the delta given a changed resource (e.g. a content file, template, JS file etc.). This handles transitive relations, e.g. $page -> js.Build -> JS import, or $page1.Content -> render hook -> site.GetPage -> $page2.Title, or $page1.Content -> shortcode -> partial -> site.RegularPages -> $page2.Content -> shortcode ..., and should also handle changes to aggregated values (e.g. site.Lastmod) effectively. This covers all of Hugo's API with 2 known exceptions (a list that may not be fully exhaustive): Changes to files loaded with template func os.ReadFile may not be handled correctly. We recommend loading resources with resources.Get Changes to Hugo objects (e.g. Page) passed in the template context to lang.Translate may not be detected correctly. We recommend having simple i18n templates without too much data context passed in other than simple types such as strings and numbers. Note that the cachebuster configuration (when A changes then rebuild B) works well with the above, but we recommend that you revise that configuration, as it in most situations should not be needed. One example where it is still needed is with TailwindCSS and using changes to hugo_stats.json to trigger new CSS rebuilds. Document Store: Previously, a little simplified, we split the document store (where we store pages and resources) in a tree per language. This worked pretty well, but the structure made some operations harder than they needed to be. We have now restructured it into one Radix tree for all languages. Internally the language is considered to be a dimension of that tree, and the tree can be viewed in all dimensions concurrently. This makes some operations re. language simpler (e.g. finding translations is just a slice range), but the idea is that it should also be relatively inexpensive to add more dimensions if needed (e.g. role). Fixes #10169 Fixes #10364 Fixes #10482 Fixes #10630 Fixes #10656 Fixes #10694 Fixes #10918 Fixes #11262 Fixes #11439 Fixes #11453 Fixes #11457 Fixes #11466 Fixes #11540 Fixes #11551 Fixes #11556 Fixes #11654 Fixes #11661 Fixes #11663 Fixes #11664 Fixes #11669 Fixes #11671 Fixes #11807 Fixes #11808 Fixes #11809 Fixes #11815 Fixes #11840 Fixes #11853 Fixes #11860 Fixes #11883 Fixes #11904 Fixes #7388 Fixes #7425 Fixes #7436 Fixes #7544 Fixes #7882 Fixes #7960 Fixes #8255 Fixes #8307 Fixes #8863 Fixes #8927 Fixes #9192 Fixes #9324
264 lines
7.1 KiB
Go
264 lines
7.1 KiB
Go
// Copyright 2017 The Hugo Authors. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
// Package partials provides template functions for working with reusable
|
|
// templates.
|
|
package partials
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"html/template"
|
|
"io"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/bep/lazycache"
|
|
|
|
"github.com/gohugoio/hugo/identity"
|
|
|
|
texttemplate "github.com/gohugoio/hugo/tpl/internal/go_templates/texttemplate"
|
|
|
|
"github.com/gohugoio/hugo/tpl"
|
|
|
|
bp "github.com/gohugoio/hugo/bufferpool"
|
|
"github.com/gohugoio/hugo/deps"
|
|
)
|
|
|
|
type partialCacheKey struct {
|
|
Name string
|
|
Variants []any
|
|
}
|
|
type includeResult struct {
|
|
name string
|
|
result any
|
|
mangager identity.Manager
|
|
err error
|
|
}
|
|
|
|
func (k partialCacheKey) Key() string {
|
|
if k.Variants == nil {
|
|
return k.Name
|
|
}
|
|
return identity.HashString(append([]any{k.Name}, k.Variants...)...)
|
|
}
|
|
|
|
func (k partialCacheKey) templateName() string {
|
|
if !strings.HasPrefix(k.Name, "partials/") {
|
|
return "partials/" + k.Name
|
|
}
|
|
return k.Name
|
|
}
|
|
|
|
// partialCache represents a LRU cache of partials.
|
|
type partialCache struct {
|
|
cache *lazycache.Cache[string, includeResult]
|
|
}
|
|
|
|
func (p *partialCache) clear() {
|
|
p.cache.DeleteFunc(func(s string, r includeResult) bool {
|
|
return true
|
|
})
|
|
}
|
|
|
|
// New returns a new instance of the templates-namespaced template functions.
|
|
func New(deps *deps.Deps) *Namespace {
|
|
// This lazycache was introduced in Hugo 0.111.0.
|
|
// We're going to expand and consolidate all memory caches in Hugo using this,
|
|
// so just set a high limit for now.
|
|
lru := lazycache.New(lazycache.Options[string, includeResult]{MaxEntries: 1000})
|
|
|
|
cache := &partialCache{cache: lru}
|
|
deps.BuildStartListeners.Add(
|
|
func() {
|
|
cache.clear()
|
|
})
|
|
|
|
return &Namespace{
|
|
deps: deps,
|
|
cachedPartials: cache,
|
|
}
|
|
}
|
|
|
|
// Namespace provides template functions for the "templates" namespace.
|
|
type Namespace struct {
|
|
deps *deps.Deps
|
|
cachedPartials *partialCache
|
|
}
|
|
|
|
// contextWrapper makes room for a return value in a partial invocation.
|
|
type contextWrapper struct {
|
|
Arg any
|
|
Result any
|
|
}
|
|
|
|
// Set sets the return value and returns an empty string.
|
|
func (c *contextWrapper) Set(in any) string {
|
|
c.Result = in
|
|
return ""
|
|
}
|
|
|
|
// Include executes the named partial.
|
|
// If the partial contains a return statement, that value will be returned.
|
|
// Else, the rendered output will be returned:
|
|
// A string if the partial is a text/template, or template.HTML when html/template.
|
|
// Note that ctx is provided by Hugo, not the end user.
|
|
func (ns *Namespace) Include(ctx context.Context, name string, contextList ...any) (any, error) {
|
|
res := ns.includWithTimeout(ctx, name, contextList...)
|
|
if res.err != nil {
|
|
return nil, res.err
|
|
}
|
|
|
|
if ns.deps.Metrics != nil {
|
|
ns.deps.Metrics.TrackValue(res.name, res.result, false)
|
|
}
|
|
|
|
return res.result, nil
|
|
}
|
|
|
|
func (ns *Namespace) includWithTimeout(ctx context.Context, name string, dataList ...any) includeResult {
|
|
// Create a new context with a timeout not connected to the incoming context.
|
|
timeoutCtx, cancel := context.WithTimeout(context.Background(), ns.deps.Conf.Timeout())
|
|
defer cancel()
|
|
|
|
res := make(chan includeResult, 1)
|
|
|
|
go func() {
|
|
res <- ns.include(ctx, name, dataList...)
|
|
}()
|
|
|
|
select {
|
|
case r := <-res:
|
|
return r
|
|
case <-timeoutCtx.Done():
|
|
err := timeoutCtx.Err()
|
|
if err == context.DeadlineExceeded {
|
|
//lint:ignore ST1005 end user message.
|
|
err = fmt.Errorf("partial %q timed out after %s. This is most likely due to infinite recursion. If this is just a slow template, you can try to increase the 'timeout' config setting.", name, ns.deps.Conf.Timeout())
|
|
}
|
|
return includeResult{err: err}
|
|
}
|
|
}
|
|
|
|
// include is a helper function that lookups and executes the named partial.
|
|
// Returns the final template name and the rendered output.
|
|
func (ns *Namespace) include(ctx context.Context, name string, dataList ...any) includeResult {
|
|
var data any
|
|
if len(dataList) > 0 {
|
|
data = dataList[0]
|
|
}
|
|
|
|
var n string
|
|
if strings.HasPrefix(name, "partials/") {
|
|
n = name
|
|
} else {
|
|
n = "partials/" + name
|
|
}
|
|
|
|
templ, found := ns.deps.Tmpl().Lookup(n)
|
|
if !found {
|
|
// For legacy reasons.
|
|
templ, found = ns.deps.Tmpl().Lookup(n + ".html")
|
|
}
|
|
|
|
if !found {
|
|
return includeResult{err: fmt.Errorf("partial %q not found", name)}
|
|
}
|
|
|
|
var info tpl.ParseInfo
|
|
if ip, ok := templ.(tpl.Info); ok {
|
|
info = ip.ParseInfo()
|
|
}
|
|
|
|
var w io.Writer
|
|
|
|
if info.HasReturn {
|
|
// Wrap the context sent to the template to capture the return value.
|
|
// Note that the template is rewritten to make sure that the dot (".")
|
|
// and the $ variable points to Arg.
|
|
data = &contextWrapper{
|
|
Arg: data,
|
|
}
|
|
|
|
// We don't care about any template output.
|
|
w = io.Discard
|
|
} else {
|
|
b := bp.GetBuffer()
|
|
defer bp.PutBuffer(b)
|
|
w = b
|
|
}
|
|
|
|
if err := ns.deps.Tmpl().ExecuteWithContext(ctx, templ, w, data); err != nil {
|
|
return includeResult{err: err}
|
|
}
|
|
|
|
var result any
|
|
|
|
if ctx, ok := data.(*contextWrapper); ok {
|
|
result = ctx.Result
|
|
} else if _, ok := templ.(*texttemplate.Template); ok {
|
|
result = w.(fmt.Stringer).String()
|
|
} else {
|
|
result = template.HTML(w.(fmt.Stringer).String())
|
|
}
|
|
|
|
return includeResult{
|
|
name: templ.Name(),
|
|
result: result,
|
|
}
|
|
}
|
|
|
|
// IncludeCached executes and caches partial templates. The cache is created with name+variants as the key.
|
|
// Note that ctx is provided by Hugo, not the end user.
|
|
func (ns *Namespace) IncludeCached(ctx context.Context, name string, context any, variants ...any) (any, error) {
|
|
start := time.Now()
|
|
key := partialCacheKey{
|
|
Name: name,
|
|
Variants: variants,
|
|
}
|
|
depsManagerIn := tpl.Context.GetDependencyManagerInCurrentScope(ctx)
|
|
|
|
r, found, err := ns.cachedPartials.cache.GetOrCreate(key.Key(), func(string) (includeResult, error) {
|
|
var depsManagerShared identity.Manager
|
|
if ns.deps.Conf.Watching() {
|
|
// We need to create a shared dependency manager to pass downwards
|
|
// and add those same dependencies to any cached invocation of this partial.
|
|
depsManagerShared = identity.NewManager("partials")
|
|
ctx = tpl.Context.DependencyManagerScopedProvider.Set(ctx, depsManagerShared.(identity.DependencyManagerScopedProvider))
|
|
}
|
|
r := ns.includWithTimeout(ctx, key.Name, context)
|
|
if ns.deps.Conf.Watching() {
|
|
r.mangager = depsManagerShared
|
|
}
|
|
return r, r.err
|
|
})
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
if ns.deps.Metrics != nil {
|
|
if found {
|
|
// The templates that gets executed is measured in Execute.
|
|
// We need to track the time spent in the cache to
|
|
// get the totals correct.
|
|
ns.deps.Metrics.MeasureSince(key.templateName(), start)
|
|
}
|
|
ns.deps.Metrics.TrackValue(key.templateName(), r.result, found)
|
|
}
|
|
|
|
if r.mangager != nil && depsManagerIn != nil {
|
|
depsManagerIn.AddIdentity(r.mangager)
|
|
}
|
|
|
|
return r.result, nil
|
|
}
|