mirror of
https://github.com/gohugoio/hugo.git
synced 2024-12-29 18:11:27 +00:00
c6d650c8c8
This more or less completes the simplification of the template handling code in Hugo started in v0.62. The main motivation was to fix a long lasting issue about a crash in HTML content files without front matter. But this commit also comes with a big functional improvement. As we now have moved the base template evaluation to the build stage we now use the same lookup rules for `baseof` as for `list` etc. type of templates. This means that in this simple example you can have a `baseof` template for the `blog` section without having to duplicate the others: ``` layouts ├── _default │ ├── baseof.html │ ├── list.html │ └── single.html └── blog └── baseof.html ``` Also, when simplifying code, you often get rid of some double work, as shown in the "site building" benchmarks below. These benchmarks looks suspiciously good, but I have repeated the below with ca. the same result. Compared to master: ``` name old time/op new time/op delta SiteNew/Bundle_with_image-16 13.1ms ± 1% 10.5ms ± 1% -19.34% (p=0.029 n=4+4) SiteNew/Bundle_with_JSON_file-16 13.0ms ± 0% 10.7ms ± 1% -18.05% (p=0.029 n=4+4) SiteNew/Tags_and_categories-16 46.4ms ± 2% 43.1ms ± 1% -7.15% (p=0.029 n=4+4) SiteNew/Canonify_URLs-16 52.2ms ± 2% 47.8ms ± 1% -8.30% (p=0.029 n=4+4) SiteNew/Deep_content_tree-16 77.9ms ± 1% 70.9ms ± 1% -9.01% (p=0.029 n=4+4) SiteNew/Many_HTML_templates-16 43.0ms ± 0% 37.2ms ± 1% -13.54% (p=0.029 n=4+4) SiteNew/Page_collections-16 58.2ms ± 1% 52.4ms ± 1% -9.95% (p=0.029 n=4+4) name old alloc/op new alloc/op delta SiteNew/Bundle_with_image-16 3.81MB ± 0% 2.22MB ± 0% -41.70% (p=0.029 n=4+4) SiteNew/Bundle_with_JSON_file-16 3.60MB ± 0% 2.01MB ± 0% -44.20% (p=0.029 n=4+4) SiteNew/Tags_and_categories-16 19.3MB ± 1% 14.1MB ± 0% -26.91% (p=0.029 n=4+4) SiteNew/Canonify_URLs-16 70.7MB ± 0% 69.0MB ± 0% -2.40% (p=0.029 n=4+4) SiteNew/Deep_content_tree-16 37.1MB ± 0% 31.2MB ± 0% -15.94% (p=0.029 n=4+4) SiteNew/Many_HTML_templates-16 17.6MB ± 0% 10.6MB ± 0% -39.92% (p=0.029 n=4+4) SiteNew/Page_collections-16 25.9MB ± 0% 21.2MB ± 0% -17.99% (p=0.029 n=4+4) name old allocs/op new allocs/op delta SiteNew/Bundle_with_image-16 52.3k ± 0% 26.1k ± 0% -50.18% (p=0.029 n=4+4) SiteNew/Bundle_with_JSON_file-16 52.3k ± 0% 26.1k ± 0% -50.16% (p=0.029 n=4+4) SiteNew/Tags_and_categories-16 336k ± 1% 269k ± 0% -19.90% (p=0.029 n=4+4) SiteNew/Canonify_URLs-16 422k ± 0% 395k ± 0% -6.43% (p=0.029 n=4+4) SiteNew/Deep_content_tree-16 401k ± 0% 313k ± 0% -21.79% (p=0.029 n=4+4) SiteNew/Many_HTML_templates-16 247k ± 0% 143k ± 0% -42.17% (p=0.029 n=4+4) SiteNew/Page_collections-16 282k ± 0% 207k ± 0% -26.55% (p=0.029 n=4+4) ``` Fixes #6716 Fixes #6760 Fixes #6768 Fixes #6778
294 lines
8.3 KiB
Go
294 lines
8.3 KiB
Go
// Copyright 2019 The Hugo Authors. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package hugolib
|
|
|
|
import (
|
|
"bytes"
|
|
"fmt"
|
|
"path"
|
|
"testing"
|
|
|
|
qt "github.com/frankban/quicktest"
|
|
"github.com/gohugoio/hugo/parser"
|
|
"github.com/gohugoio/hugo/parser/metadecoders"
|
|
)
|
|
|
|
func BenchmarkCascade(b *testing.B) {
|
|
allLangs := []string{"en", "nn", "nb", "sv", "ab", "aa", "af", "sq", "kw", "da"}
|
|
|
|
for i := 1; i <= len(allLangs); i += 2 {
|
|
langs := allLangs[0:i]
|
|
b.Run(fmt.Sprintf("langs-%d", len(langs)), func(b *testing.B) {
|
|
c := qt.New(b)
|
|
b.StopTimer()
|
|
builders := make([]*sitesBuilder, b.N)
|
|
for i := 0; i < b.N; i++ {
|
|
builders[i] = newCascadeTestBuilder(b, langs)
|
|
}
|
|
b.StartTimer()
|
|
|
|
for i := 0; i < b.N; i++ {
|
|
builder := builders[i]
|
|
err := builder.BuildE(BuildCfg{})
|
|
c.Assert(err, qt.IsNil)
|
|
first := builder.H.Sites[0]
|
|
c.Assert(first, qt.Not(qt.IsNil))
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestCascade(t *testing.T) {
|
|
|
|
allLangs := []string{"en", "nn", "nb", "sv"}
|
|
|
|
langs := allLangs[:3]
|
|
|
|
t.Run(fmt.Sprintf("langs-%d", len(langs)), func(t *testing.T) {
|
|
b := newCascadeTestBuilder(t, langs)
|
|
b.Build(BuildCfg{})
|
|
|
|
b.AssertFileContent("public/index.html", `
|
|
12|taxonomy|categories/cool/_index.md|Cascade Category|cat.png|categories|HTML-|
|
|
12|taxonomy|categories/catsect1|catsect1|cat.png|categories|HTML-|
|
|
12|taxonomy|categories/funny|funny|cat.png|categories|HTML-|
|
|
12|taxonomyTerm|categories/_index.md|My Categories|cat.png|categories|HTML-|
|
|
32|taxonomy|categories/sad/_index.md|Cascade Category|sad.png|categories|HTML-|
|
|
42|taxonomy|tags/blue|blue|home.png|tags|HTML-|
|
|
42|section|sect3|Cascade Home|home.png|sect3|HTML-|
|
|
42|taxonomyTerm|tags|Cascade Home|home.png|tags|HTML-|
|
|
42|page|p2.md|Cascade Home|home.png||HTML-|
|
|
42|page|sect2/p2.md|Cascade Home|home.png|sect2|HTML-|
|
|
42|page|sect3/p1.md|Cascade Home|home.png|sect3|HTML-|
|
|
42|taxonomy|tags/green|green|home.png|tags|HTML-|
|
|
42|home|_index.md|Home|home.png||HTML-|
|
|
42|page|p1.md|p1|home.png||HTML-|
|
|
42|section|sect1/_index.md|Sect1|sect1.png|stype|HTML-|
|
|
42|section|sect1/s1_2/_index.md|Sect1_2|sect1.png|stype|HTML-|
|
|
42|page|sect1/s1_2/p1.md|Sect1_2_p1|sect1.png|stype|HTML-|
|
|
42|page|sect1/s1_2/p2.md|Sect1_2_p2|sect1.png|stype|HTML-|
|
|
42|section|sect2/_index.md|Sect2|home.png|sect2|HTML-|
|
|
42|page|sect2/p1.md|Sect2_p1|home.png|sect2|HTML-|
|
|
52|page|sect4/p1.md|Cascade Home|home.png|sect4|RSS-|
|
|
52|section|sect4/_index.md|Sect4|home.png|sect4|RSS-|
|
|
`)
|
|
|
|
// Check that type set in cascade gets the correct layout.
|
|
b.AssertFileContent("public/sect1/index.html", `stype list: Sect1`)
|
|
b.AssertFileContent("public/sect1/s1_2/p2/index.html", `stype single: Sect1_2_p2`)
|
|
|
|
// Check output formats set in cascade
|
|
b.AssertFileContent("public/sect4/index.xml", `<link>https://example.org/sect4/index.xml</link>`)
|
|
b.AssertFileContent("public/sect4/p1/index.xml", `<link>https://example.org/sect4/p1/index.xml</link>`)
|
|
b.C.Assert(b.CheckExists("public/sect2/index.xml"), qt.Equals, false)
|
|
|
|
// Check cascade into bundled page
|
|
b.AssertFileContent("public/bundle1/index.html", `Resources: bp1.md|home.png|`)
|
|
|
|
})
|
|
|
|
}
|
|
|
|
func TestCascadeEdit(t *testing.T) {
|
|
p1Content := `---
|
|
title: P1
|
|
---
|
|
`
|
|
b := newTestSitesBuilder(t).Running()
|
|
b.WithTemplatesAdded("_default/single.html", `Banner: {{ .Params.banner }}|Layout: {{ .Layout }}|Type: {{ .Type }}|Content: {{ .Content }}`)
|
|
b.WithContent("post/_index.md", `
|
|
---
|
|
title: Post
|
|
cascade:
|
|
banner: post.jpg
|
|
layout: postlayout
|
|
type: posttype
|
|
---
|
|
`)
|
|
|
|
b.WithContent("post/dir/_index.md", `
|
|
---
|
|
title: Dir
|
|
---
|
|
`, "post/dir/p1.md", p1Content)
|
|
b.Build(BuildCfg{})
|
|
|
|
assert := func() {
|
|
b.Helper()
|
|
b.AssertFileContent("public/post/dir/p1/index.html",
|
|
`Banner: post.jpg|`,
|
|
`Layout: postlayout`,
|
|
`Type: posttype`,
|
|
)
|
|
}
|
|
|
|
assert()
|
|
|
|
b.EditFiles("content/post/dir/p1.md", p1Content+"\ncontent edit")
|
|
b.Build(BuildCfg{})
|
|
|
|
assert()
|
|
b.AssertFileContent("public/post/dir/p1/index.html",
|
|
`content edit`,
|
|
)
|
|
}
|
|
|
|
func newCascadeTestBuilder(t testing.TB, langs []string) *sitesBuilder {
|
|
p := func(m map[string]interface{}) string {
|
|
var yamlStr string
|
|
|
|
if len(m) > 0 {
|
|
var b bytes.Buffer
|
|
|
|
parser.InterfaceToConfig(m, metadecoders.YAML, &b)
|
|
yamlStr = b.String()
|
|
}
|
|
|
|
metaStr := "---\n" + yamlStr + "\n---"
|
|
|
|
return metaStr
|
|
|
|
}
|
|
|
|
createLangConfig := func(lang string) string {
|
|
const langEntry = `
|
|
[languages.%s]
|
|
`
|
|
return fmt.Sprintf(langEntry, lang)
|
|
}
|
|
|
|
createMount := func(lang string) string {
|
|
const mountsTempl = `
|
|
[[module.mounts]]
|
|
source="content/%s"
|
|
target="content"
|
|
lang="%s"
|
|
`
|
|
return fmt.Sprintf(mountsTempl, lang, lang)
|
|
}
|
|
|
|
config := `
|
|
baseURL = "https://example.org"
|
|
defaultContentLanguage = "en"
|
|
defaultContentLanguageInSubDir = false
|
|
|
|
[languages]`
|
|
for _, lang := range langs {
|
|
config += createLangConfig(lang)
|
|
}
|
|
|
|
config += "\n\n[module]\n"
|
|
for _, lang := range langs {
|
|
config += createMount(lang)
|
|
}
|
|
|
|
b := newTestSitesBuilder(t).WithConfigFile("toml", config)
|
|
|
|
createContentFiles := func(lang string) {
|
|
|
|
withContent := func(filenameContent ...string) {
|
|
for i := 0; i < len(filenameContent); i += 2 {
|
|
b.WithContent(path.Join(lang, filenameContent[i]), filenameContent[i+1])
|
|
}
|
|
}
|
|
|
|
withContent(
|
|
"_index.md", p(map[string]interface{}{
|
|
"title": "Home",
|
|
"cascade": map[string]interface{}{
|
|
"title": "Cascade Home",
|
|
"ICoN": "home.png",
|
|
"outputs": []string{"HTML"},
|
|
"weight": 42,
|
|
},
|
|
}),
|
|
"p1.md", p(map[string]interface{}{
|
|
"title": "p1",
|
|
}),
|
|
"p2.md", p(map[string]interface{}{}),
|
|
"sect1/_index.md", p(map[string]interface{}{
|
|
"title": "Sect1",
|
|
"type": "stype",
|
|
"cascade": map[string]interface{}{
|
|
"title": "Cascade Sect1",
|
|
"icon": "sect1.png",
|
|
"type": "stype",
|
|
"categories": []string{"catsect1"},
|
|
},
|
|
}),
|
|
"sect1/s1_2/_index.md", p(map[string]interface{}{
|
|
"title": "Sect1_2",
|
|
}),
|
|
"sect1/s1_2/p1.md", p(map[string]interface{}{
|
|
"title": "Sect1_2_p1",
|
|
}),
|
|
"sect1/s1_2/p2.md", p(map[string]interface{}{
|
|
"title": "Sect1_2_p2",
|
|
}),
|
|
"sect2/_index.md", p(map[string]interface{}{
|
|
"title": "Sect2",
|
|
}),
|
|
"sect2/p1.md", p(map[string]interface{}{
|
|
"title": "Sect2_p1",
|
|
"categories": []string{"cool", "funny", "sad"},
|
|
"tags": []string{"blue", "green"},
|
|
}),
|
|
"sect2/p2.md", p(map[string]interface{}{}),
|
|
"sect3/p1.md", p(map[string]interface{}{}),
|
|
"sect4/_index.md", p(map[string]interface{}{
|
|
"title": "Sect4",
|
|
"cascade": map[string]interface{}{
|
|
"weight": 52,
|
|
"outputs": []string{"RSS"},
|
|
},
|
|
}),
|
|
"sect4/p1.md", p(map[string]interface{}{}),
|
|
"p2.md", p(map[string]interface{}{}),
|
|
"bundle1/index.md", p(map[string]interface{}{}),
|
|
"bundle1/bp1.md", p(map[string]interface{}{}),
|
|
"categories/_index.md", p(map[string]interface{}{
|
|
"title": "My Categories",
|
|
"cascade": map[string]interface{}{
|
|
"title": "Cascade Category",
|
|
"icoN": "cat.png",
|
|
"weight": 12,
|
|
},
|
|
}),
|
|
"categories/cool/_index.md", p(map[string]interface{}{}),
|
|
"categories/sad/_index.md", p(map[string]interface{}{
|
|
"cascade": map[string]interface{}{
|
|
"icon": "sad.png",
|
|
"weight": 32,
|
|
},
|
|
}),
|
|
)
|
|
}
|
|
|
|
createContentFiles("en")
|
|
|
|
b.WithTemplates("index.html", `
|
|
|
|
{{ range .Site.Pages }}
|
|
{{- .Weight }}|{{ .Kind }}|{{ path.Join .Path }}|{{ .Title }}|{{ .Params.icon }}|{{ .Type }}|{{ range .OutputFormats }}{{ .Name }}-{{ end }}|
|
|
{{ end }}
|
|
`,
|
|
|
|
"_default/single.html", "default single: {{ .Title }}|{{ .RelPermalink }}|{{ .Content }}|Resources: {{ range .Resources }}{{ .Name }}|{{ .Params.icon }}|{{ .Content }}{{ end }}",
|
|
"_default/list.html", "default list: {{ .Title }}",
|
|
"stype/single.html", "stype single: {{ .Title }}|{{ .RelPermalink }}|{{ .Content }}",
|
|
"stype/list.html", "stype list: {{ .Title }}",
|
|
)
|
|
|
|
return b
|
|
}
|