hugo/hugolib
Bjørn Erik Pedersen c6d650c8c8
tpl/tplimpl: Rework template management to get rid of concurrency issues
This more or less completes the simplification of the template handling code in Hugo started in v0.62.

The main motivation was to fix a long lasting issue about a crash in HTML content files  without front matter.

But this commit also comes with a big functional improvement.

As we now have moved the base template evaluation to the build stage we now use the same lookup rules for `baseof` as for `list` etc. type of templates.

This means that in this simple example you can have a `baseof` template for the `blog` section without having to duplicate the others:

```
layouts
├── _default
│   ├── baseof.html
│   ├── list.html
│   └── single.html
└── blog
    └── baseof.html
```

Also, when simplifying code, you often get rid of some double work, as shown in the "site building" benchmarks below.

These benchmarks looks suspiciously good, but I have repeated the below with ca. the same result. Compared to master:

```
name                              old time/op    new time/op    delta
SiteNew/Bundle_with_image-16        13.1ms ± 1%    10.5ms ± 1%  -19.34%  (p=0.029 n=4+4)
SiteNew/Bundle_with_JSON_file-16    13.0ms ± 0%    10.7ms ± 1%  -18.05%  (p=0.029 n=4+4)
SiteNew/Tags_and_categories-16      46.4ms ± 2%    43.1ms ± 1%   -7.15%  (p=0.029 n=4+4)
SiteNew/Canonify_URLs-16            52.2ms ± 2%    47.8ms ± 1%   -8.30%  (p=0.029 n=4+4)
SiteNew/Deep_content_tree-16        77.9ms ± 1%    70.9ms ± 1%   -9.01%  (p=0.029 n=4+4)
SiteNew/Many_HTML_templates-16      43.0ms ± 0%    37.2ms ± 1%  -13.54%  (p=0.029 n=4+4)
SiteNew/Page_collections-16         58.2ms ± 1%    52.4ms ± 1%   -9.95%  (p=0.029 n=4+4)

name                              old alloc/op   new alloc/op   delta
SiteNew/Bundle_with_image-16        3.81MB ± 0%    2.22MB ± 0%  -41.70%  (p=0.029 n=4+4)
SiteNew/Bundle_with_JSON_file-16    3.60MB ± 0%    2.01MB ± 0%  -44.20%  (p=0.029 n=4+4)
SiteNew/Tags_and_categories-16      19.3MB ± 1%    14.1MB ± 0%  -26.91%  (p=0.029 n=4+4)
SiteNew/Canonify_URLs-16            70.7MB ± 0%    69.0MB ± 0%   -2.40%  (p=0.029 n=4+4)
SiteNew/Deep_content_tree-16        37.1MB ± 0%    31.2MB ± 0%  -15.94%  (p=0.029 n=4+4)
SiteNew/Many_HTML_templates-16      17.6MB ± 0%    10.6MB ± 0%  -39.92%  (p=0.029 n=4+4)
SiteNew/Page_collections-16         25.9MB ± 0%    21.2MB ± 0%  -17.99%  (p=0.029 n=4+4)

name                              old allocs/op  new allocs/op  delta
SiteNew/Bundle_with_image-16         52.3k ± 0%     26.1k ± 0%  -50.18%  (p=0.029 n=4+4)
SiteNew/Bundle_with_JSON_file-16     52.3k ± 0%     26.1k ± 0%  -50.16%  (p=0.029 n=4+4)
SiteNew/Tags_and_categories-16        336k ± 1%      269k ± 0%  -19.90%  (p=0.029 n=4+4)
SiteNew/Canonify_URLs-16              422k ± 0%      395k ± 0%   -6.43%  (p=0.029 n=4+4)
SiteNew/Deep_content_tree-16          401k ± 0%      313k ± 0%  -21.79%  (p=0.029 n=4+4)
SiteNew/Many_HTML_templates-16        247k ± 0%      143k ± 0%  -42.17%  (p=0.029 n=4+4)
SiteNew/Page_collections-16           282k ± 0%      207k ± 0%  -26.55%  (p=0.029 n=4+4)
```

Fixes #6716
Fixes #6760
Fixes #6768
Fixes #6778
2020-01-22 09:39:49 +01:00
..
assets/images Image resource refactor 2019-08-26 15:00:44 +02:00
filesystems Support files in content mounts 2020-01-01 18:19:49 +01:00
paths tests: Convert from testify to quicktest 2019-08-12 13:26:32 +02:00
testdata hugolib: Add a site benchmark 2019-08-16 16:24:21 +02:00
testsite hugolib: Add testfile to .gitignore 2019-07-07 13:01:30 +02:00
404_test.go Spring test cleaning, take 2 2018-03-18 09:54:32 +01:00
alias.go tpl/tplimpl: Rework template management to get rid of concurrency issues 2020-01-22 09:39:49 +01:00
alias_test.go tests: Convert from testify to quicktest 2019-08-12 13:26:32 +02:00
cascade_test.go tpl/tplimpl: Rework template management to get rid of concurrency issues 2020-01-22 09:39:49 +01:00
case_insensitive_test.go Rework template handling for function and map lookups 2019-12-12 10:04:35 +01:00
collections.go Make Page an interface 2019-03-23 18:51:22 +01:00
collections_test.go tests: Convert from testify to quicktest 2019-08-12 13:26:32 +02:00
config.go resources/images: Make the image cache more robust 2019-11-25 18:59:06 +01:00
config_test.go tests: Convert from testify to quicktest 2019-08-12 13:26:32 +02:00
configdir_test.go tests: Convert from testify to quicktest 2019-08-12 13:26:32 +02:00
content_render_hooks_test.go tpl/tplimpl: Rework template management to get rid of concurrency issues 2020-01-22 09:39:49 +01:00
datafiles_test.go tests: Convert from testify to quicktest 2019-08-12 13:26:32 +02:00
disableKinds_test.go tests: Convert from testify to quicktest 2019-08-12 13:26:32 +02:00
embedded_shortcodes_test.go Rework template handling for function and map lookups 2019-12-12 10:04:35 +01:00
embedded_templates_test.go Add some internal template image tests 2019-11-27 09:24:08 +01:00
fileInfo.go Add Hugo Modules 2019-07-24 09:35:53 +02:00
fileInfo_test.go tests: Convert from testify to quicktest 2019-08-12 13:26:32 +02:00
gitinfo.go Make Page an interface 2019-03-23 18:51:22 +01:00
hugo_modules_test.go tpl/tplimpl: Rework template management to get rid of concurrency issues 2020-01-22 09:39:49 +01:00
hugo_sites.go tpl/tplimpl: Rework template management to get rid of concurrency issues 2020-01-22 09:39:49 +01:00
hugo_sites_build.go tpl/tplimpl: Rework template management to get rid of concurrency issues 2020-01-22 09:39:49 +01:00
hugo_sites_build_errors_test.go tpl/tplimpl: Rework template management to get rid of concurrency issues 2020-01-22 09:39:49 +01:00
hugo_sites_build_test.go Add render template hooks for links and images 2019-12-18 11:44:40 +01:00
hugo_sites_multihost_test.go tests: Convert from testify to quicktest 2019-08-12 13:26:32 +02:00
hugo_sites_rebuild_test.go tpl/tplimpl: Rework template management to get rid of concurrency issues 2020-01-22 09:39:49 +01:00
hugo_smoke_test.go Rework template handling for function and map lookups 2019-12-12 10:04:35 +01:00
image_test.go Fix incorrect MIME type from image/jpg to image/jpeg 2019-12-19 18:02:11 +01:00
language_content_dir_test.go hugofs: Fix crash in multilingual content fs 2019-10-31 16:11:53 +01:00
menu_test.go tests: Convert from testify to quicktest 2019-08-12 13:26:32 +02:00
minify_publisher_test.go Make Page an interface 2019-03-23 18:51:22 +01:00
multilingual.go Add Hugo Modules 2019-07-24 09:35:53 +02:00
page.go tpl/tplimpl: Rework template management to get rid of concurrency issues 2020-01-22 09:39:49 +01:00
page__common.go Implement cascading front matter 2019-08-10 20:07:42 +02:00
page__content.go Add render template hooks for links and images 2019-12-18 11:44:40 +01:00
page__data.go Simplify page tree logic 2019-08-08 20:13:39 +02:00
page__menus.go Fix typo s/Meny/Menu/ 2019-07-09 17:28:53 +02:00
page__meta.go tpl/tplimpl: Rework template management to get rid of concurrency issues 2020-01-22 09:39:49 +01:00
page__new.go Add render template hooks for links and images 2019-12-18 11:44:40 +01:00
page__output.go Add render template hooks for links and images 2019-12-18 11:44:40 +01:00
page__paginator.go Adjust the default paginator for sections 2019-08-17 13:08:03 +02:00
page__paths.go hugolib: Fix bundle path when slug is set 2019-06-09 16:55:08 +02:00
page__per_output.go tpl/tplimpl: Rework template management to get rid of concurrency issues 2020-01-22 09:39:49 +01:00
page__position.go Make Page an interface 2019-03-23 18:51:22 +01:00
page__ref.go Make Page an interface 2019-03-23 18:51:22 +01:00
page__tree.go Simplify page tree logic 2019-08-08 20:13:39 +02:00
page_kinds.go hugolib: Fix output format handling of mix cased page kinds 2019-08-05 11:22:03 +02:00
page_permalink_test.go tests: Convert from testify to quicktest 2019-08-12 13:26:32 +02:00
page_test.go tpl/tplimpl: Rework template management to get rid of concurrency issues 2020-01-22 09:39:49 +01:00
page_unwrap.go Make Page an interface 2019-03-23 18:51:22 +01:00
page_unwrap_test.go Add render template hooks for links and images 2019-12-18 11:44:40 +01:00
pagebundler_test.go Add render template hooks for links and images 2019-12-18 11:44:40 +01:00
pagecollections.go hugolib: Fix relative .Page.GetPage from bundle 2020-01-05 19:41:53 +01:00
pagecollections_test.go tests: Convert from testify to quicktest 2019-08-12 13:26:32 +02:00
pages_capture.go Support files in content mounts 2020-01-01 18:19:49 +01:00
pages_capture_test.go tests: Convert from testify to quicktest 2019-08-12 13:26:32 +02:00
pages_language_merge_test.go tests: Convert from testify to quicktest 2019-08-12 13:26:32 +02:00
pages_map.go Fix headless regression 2019-11-29 13:46:29 +01:00
pages_test.go resources/page: Use binary search in Pages.Prev/Next if possible 2019-10-13 12:36:17 +02:00
paginator_test.go tpl/collections: Fix slice type handling in sort 2019-06-10 08:32:44 +02:00
permalinker.go Make Page an interface 2019-03-23 18:51:22 +01:00
prune_resources.go cache/filecache: Add a cache prune func 2018-11-14 23:14:51 +01:00
resource_chain_test.go Fix abs path handling in module mounts 2019-12-19 18:51:59 +01:00
robotstxt_test.go Spring test cleaning, take 2 2018-03-18 09:54:32 +01:00
rss_test.go tests: Convert from testify to quicktest 2019-08-12 13:26:32 +02:00
shortcode.go tpl/tplimpl: Rework template management to get rid of concurrency issues 2020-01-22 09:39:49 +01:00
shortcode_page.go Add render template hooks for links and images 2019-12-18 11:44:40 +01:00
shortcode_test.go hugolib: Fix inline shortcode regression 2019-12-28 14:31:51 +01:00
site.go tpl/tplimpl: Rework template management to get rid of concurrency issues 2020-01-22 09:39:49 +01:00
site_benchmark_new_test.go hugolib: Some more benchmark adjustments 2020-01-13 16:47:10 +01:00
site_output.go hugolib: Fix output format handling of mix cased page kinds 2019-08-05 11:22:03 +02:00
site_output_test.go hugolib: Add some outputs tests 2019-08-15 10:30:37 +02:00
site_render.go tpl/tplimpl: Rework template management to get rid of concurrency issues 2020-01-22 09:39:49 +01:00
site_sections.go Simplify page tree logic 2019-08-08 20:13:39 +02:00
site_sections_test.go hugolib: Fix .Sections vs siblings 2019-11-26 13:12:44 +01:00
site_stats_test.go tests: Convert from testify to quicktest 2019-08-12 13:26:32 +02:00
site_test.go Add Goldmark as the new default markdown handler 2019-11-23 14:12:24 +01:00
site_url_test.go tests: Convert from testify to quicktest 2019-08-12 13:26:32 +02:00
siteJSONEncode_test.go hugolib: Add a simple test for jsonify of Site 2019-03-28 09:45:25 +01:00
sitemap_test.go Rework template handling for function and map lookups 2019-12-12 10:04:35 +01:00
taxonomy.go Simplify page tree logic 2019-08-08 20:13:39 +02:00
taxonomy_test.go hugolib: Fix draft etc. handling of _index.md pages 2019-08-15 20:41:48 +02:00
template_test.go tpl/tplimpl: Rework template management to get rid of concurrency issues 2020-01-22 09:39:49 +01:00
testhelpers_test.go tpl/tplimpl: Rework template management to get rid of concurrency issues 2020-01-22 09:39:49 +01:00
translations.go Make Page an interface 2019-03-23 18:51:22 +01:00