mirror of
https://github.com/gohugoio/hugo.git
synced 2024-11-29 05:12:09 -05:00
02eaddc2fb
Before this commit, due to a bug in Go's `text/template` package, this would print different output for typed nil interface values:
```
{{ if .AuthenticatedUser }}User is authenticated!{{ else }}{{ end }}
{{ if not .AuthenticatedUser }}{{ else }}}User is authenticated!{{ end }}
```
This commit works around this by wrapping every `if` and `with` with a custom `getif` template func with truth logic that matches `not`, `and` and `or`.
Those 3 template funcs from Go's stdlib are now pulled into Hugo's source tree and adjusted to support custom zero values, e.g. types that implement `IsZero`.
This means that you can now do:
```
{{ with .Date }}{{ . }}{{ end }}
```
And it would work as expected.
Fixes #5738
60 lines
1.6 KiB
Go
60 lines
1.6 KiB
Go
// Copyright 2019 The Hugo Authors. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package compare
|
|
|
|
import (
|
|
"reflect"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/gohugoio/hugo/common/hreflect"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestTruth(t *testing.T) {
|
|
n := New()
|
|
|
|
truthv, falsev := reflect.ValueOf(time.Now()), reflect.ValueOf(false)
|
|
|
|
assertTruth := func(t *testing.T, v reflect.Value, expected bool) {
|
|
if hreflect.IsTruthfulValue(v) != expected {
|
|
t.Fatal("truth mismatch")
|
|
}
|
|
}
|
|
|
|
t.Run("And", func(t *testing.T) {
|
|
assertTruth(t, n.And(truthv, truthv), true)
|
|
assertTruth(t, n.And(truthv, falsev), false)
|
|
|
|
})
|
|
|
|
t.Run("Or", func(t *testing.T) {
|
|
assertTruth(t, n.Or(truthv, truthv), true)
|
|
assertTruth(t, n.Or(falsev, truthv, falsev), true)
|
|
assertTruth(t, n.Or(falsev, falsev), false)
|
|
})
|
|
|
|
t.Run("Not", func(t *testing.T) {
|
|
assert := require.New(t)
|
|
assert.True(n.Not(falsev))
|
|
assert.False(n.Not(truthv))
|
|
})
|
|
|
|
t.Run("getIf", func(t *testing.T) {
|
|
assert := require.New(t)
|
|
assertTruth(t, n.getIf(reflect.ValueOf(nil)), false)
|
|
s := reflect.ValueOf("Hugo")
|
|
assert.Equal(s, n.getIf(s))
|
|
})
|
|
}
|