mirror of
https://github.com/gohugoio/hugo.git
synced 2024-11-29 16:32:09 -05:00
eada236f87
This commit introduces a new data structure to store pages and their resources. This data structure is backed by radix trees. This simplies tree operations, makes all pages a bundle, and paves the way for #6310. It also solves a set of annoying issues (see list below). Not a motivation behind this, but this commit also makes Hugo in general a little bit faster and more memory effective (see benchmarks). Especially for partial rebuilds on content edits, but also when taxonomies is in use. ``` name old time/op new time/op delta SiteNew/Bundle_with_image/Edit-16 1.32ms ± 8% 1.00ms ± 9% -24.42% (p=0.029 n=4+4) SiteNew/Bundle_with_JSON_file/Edit-16 1.28ms ± 0% 0.94ms ± 0% -26.26% (p=0.029 n=4+4) SiteNew/Tags_and_categories/Edit-16 33.9ms ± 2% 21.8ms ± 1% -35.67% (p=0.029 n=4+4) SiteNew/Canonify_URLs/Edit-16 40.6ms ± 1% 37.7ms ± 3% -7.20% (p=0.029 n=4+4) SiteNew/Deep_content_tree/Edit-16 56.7ms ± 0% 51.7ms ± 1% -8.82% (p=0.029 n=4+4) SiteNew/Many_HTML_templates/Edit-16 19.9ms ± 2% 18.3ms ± 3% -7.64% (p=0.029 n=4+4) SiteNew/Page_collections/Edit-16 37.9ms ± 4% 34.0ms ± 2% -10.28% (p=0.029 n=4+4) SiteNew/Bundle_with_image-16 10.7ms ± 0% 10.6ms ± 0% -1.15% (p=0.029 n=4+4) SiteNew/Bundle_with_JSON_file-16 10.8ms ± 0% 10.7ms ± 0% -1.05% (p=0.029 n=4+4) SiteNew/Tags_and_categories-16 43.2ms ± 1% 39.6ms ± 1% -8.35% (p=0.029 n=4+4) SiteNew/Canonify_URLs-16 47.6ms ± 1% 47.3ms ± 0% ~ (p=0.057 n=4+4) SiteNew/Deep_content_tree-16 73.0ms ± 1% 74.2ms ± 1% ~ (p=0.114 n=4+4) SiteNew/Many_HTML_templates-16 37.9ms ± 0% 38.1ms ± 1% ~ (p=0.114 n=4+4) SiteNew/Page_collections-16 53.6ms ± 1% 54.7ms ± 1% +2.09% (p=0.029 n=4+4) name old alloc/op new alloc/op delta SiteNew/Bundle_with_image/Edit-16 486kB ± 0% 430kB ± 0% -11.47% (p=0.029 n=4+4) SiteNew/Bundle_with_JSON_file/Edit-16 265kB ± 0% 209kB ± 0% -21.06% (p=0.029 n=4+4) SiteNew/Tags_and_categories/Edit-16 13.6MB ± 0% 8.8MB ± 0% -34.93% (p=0.029 n=4+4) SiteNew/Canonify_URLs/Edit-16 66.5MB ± 0% 63.9MB ± 0% -3.95% (p=0.029 n=4+4) SiteNew/Deep_content_tree/Edit-16 28.8MB ± 0% 25.8MB ± 0% -10.55% (p=0.029 n=4+4) SiteNew/Many_HTML_templates/Edit-16 6.16MB ± 0% 5.56MB ± 0% -9.86% (p=0.029 n=4+4) SiteNew/Page_collections/Edit-16 16.9MB ± 0% 16.0MB ± 0% -5.19% (p=0.029 n=4+4) SiteNew/Bundle_with_image-16 2.28MB ± 0% 2.29MB ± 0% +0.35% (p=0.029 n=4+4) SiteNew/Bundle_with_JSON_file-16 2.07MB ± 0% 2.07MB ± 0% ~ (p=0.114 n=4+4) SiteNew/Tags_and_categories-16 14.3MB ± 0% 13.2MB ± 0% -7.30% (p=0.029 n=4+4) SiteNew/Canonify_URLs-16 69.1MB ± 0% 69.0MB ± 0% ~ (p=0.343 n=4+4) SiteNew/Deep_content_tree-16 31.3MB ± 0% 31.8MB ± 0% +1.49% (p=0.029 n=4+4) SiteNew/Many_HTML_templates-16 10.8MB ± 0% 10.9MB ± 0% +1.11% (p=0.029 n=4+4) SiteNew/Page_collections-16 21.4MB ± 0% 21.6MB ± 0% +1.15% (p=0.029 n=4+4) name old allocs/op new allocs/op delta SiteNew/Bundle_with_image/Edit-16 4.74k ± 0% 3.86k ± 0% -18.57% (p=0.029 n=4+4) SiteNew/Bundle_with_JSON_file/Edit-16 4.73k ± 0% 3.85k ± 0% -18.58% (p=0.029 n=4+4) SiteNew/Tags_and_categories/Edit-16 301k ± 0% 198k ± 0% -34.14% (p=0.029 n=4+4) SiteNew/Canonify_URLs/Edit-16 389k ± 0% 373k ± 0% -4.07% (p=0.029 n=4+4) SiteNew/Deep_content_tree/Edit-16 338k ± 0% 262k ± 0% -22.63% (p=0.029 n=4+4) SiteNew/Many_HTML_templates/Edit-16 102k ± 0% 88k ± 0% -13.81% (p=0.029 n=4+4) SiteNew/Page_collections/Edit-16 176k ± 0% 152k ± 0% -13.32% (p=0.029 n=4+4) SiteNew/Bundle_with_image-16 26.8k ± 0% 26.8k ± 0% +0.05% (p=0.029 n=4+4) SiteNew/Bundle_with_JSON_file-16 26.8k ± 0% 26.8k ± 0% +0.05% (p=0.029 n=4+4) SiteNew/Tags_and_categories-16 273k ± 0% 245k ± 0% -10.36% (p=0.029 n=4+4) SiteNew/Canonify_URLs-16 396k ± 0% 398k ± 0% +0.39% (p=0.029 n=4+4) SiteNew/Deep_content_tree-16 317k ± 0% 325k ± 0% +2.53% (p=0.029 n=4+4) SiteNew/Many_HTML_templates-16 146k ± 0% 147k ± 0% +0.98% (p=0.029 n=4+4) SiteNew/Page_collections-16 210k ± 0% 215k ± 0% +2.44% (p=0.029 n=4+4) ``` Fixes #6312 Fixes #6087 Fixes #6738 Fixes #6412 Fixes #6743 Fixes #6875 Fixes #6034 Fixes #6902 Fixes #6173 Fixes #6590
471 lines
12 KiB
Go
471 lines
12 KiB
Go
// Copyright 2019 The Hugo Authors. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package hugolib
|
|
|
|
import (
|
|
"fmt"
|
|
"math/rand"
|
|
"path"
|
|
"path/filepath"
|
|
"strconv"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/gohugoio/hugo/resources/page"
|
|
|
|
qt "github.com/frankban/quicktest"
|
|
)
|
|
|
|
type siteBenchmarkTestcase struct {
|
|
name string
|
|
create func(t testing.TB) *sitesBuilder
|
|
check func(s *sitesBuilder)
|
|
}
|
|
|
|
func getBenchmarkSiteDeepContent(b testing.TB) *sitesBuilder {
|
|
pageContent := func(size int) string {
|
|
return getBenchmarkTestDataPageContentForMarkdown(size, benchmarkMarkdownSnippets)
|
|
}
|
|
|
|
sb := newTestSitesBuilder(b).WithConfigFile("toml", `
|
|
baseURL = "https://example.com"
|
|
|
|
[languages]
|
|
[languages.en]
|
|
weight=1
|
|
contentDir="content/en"
|
|
[languages.fr]
|
|
weight=2
|
|
contentDir="content/fr"
|
|
[languages.no]
|
|
weight=3
|
|
contentDir="content/no"
|
|
[languages.sv]
|
|
weight=4
|
|
contentDir="content/sv"
|
|
|
|
`)
|
|
|
|
createContent := func(dir, name string) {
|
|
sb.WithContent(filepath.Join("content", dir, name), pageContent(1))
|
|
}
|
|
|
|
createBundledFiles := func(dir string) {
|
|
sb.WithContent(filepath.Join("content", dir, "data.json"), `{ "hello": "world" }`)
|
|
for i := 1; i <= 3; i++ {
|
|
sb.WithContent(filepath.Join("content", dir, fmt.Sprintf("page%d.md", i)), pageContent(1))
|
|
}
|
|
}
|
|
|
|
for _, lang := range []string{"en", "fr", "no", "sv"} {
|
|
for level := 1; level <= 5; level++ {
|
|
sectionDir := path.Join(lang, strings.Repeat("section/", level))
|
|
createContent(sectionDir, "_index.md")
|
|
createBundledFiles(sectionDir)
|
|
for i := 1; i <= 3; i++ {
|
|
leafBundleDir := path.Join(sectionDir, fmt.Sprintf("bundle%d", i))
|
|
createContent(leafBundleDir, "index.md")
|
|
createBundledFiles(path.Join(leafBundleDir, "assets1"))
|
|
createBundledFiles(path.Join(leafBundleDir, "assets1", "assets2"))
|
|
}
|
|
}
|
|
}
|
|
|
|
return sb
|
|
}
|
|
|
|
func getBenchmarkTestDataPageContentForMarkdown(size int, markdown string) string {
|
|
return `---
|
|
title: "My Page"
|
|
---
|
|
|
|
My page content.
|
|
|
|
` + strings.Repeat(markdown, size)
|
|
}
|
|
|
|
const benchmarkMarkdownSnippets = `
|
|
|
|
## Links
|
|
|
|
|
|
This is [an example](http://example.com/ "Title") inline link.
|
|
|
|
[This link](http://example.net/) has no title attribute.
|
|
|
|
This is [Relative](/all-is-relative).
|
|
|
|
See my [About](/about/) page for details.
|
|
`
|
|
|
|
func getBenchmarkSiteNewTestCases() []siteBenchmarkTestcase {
|
|
|
|
pageContent := func(size int) string {
|
|
return getBenchmarkTestDataPageContentForMarkdown(size, benchmarkMarkdownSnippets)
|
|
}
|
|
|
|
config := `
|
|
baseURL = "https://example.com"
|
|
`
|
|
|
|
benchmarks := []siteBenchmarkTestcase{
|
|
{"Bundle with image", func(b testing.TB) *sitesBuilder {
|
|
sb := newTestSitesBuilder(b).WithConfigFile("toml", config)
|
|
sb.WithContent("content/blog/mybundle/index.md", pageContent(1))
|
|
sb.WithSunset("content/blog/mybundle/sunset1.jpg")
|
|
|
|
return sb
|
|
},
|
|
func(s *sitesBuilder) {
|
|
s.AssertFileContent("public/blog/mybundle/index.html", "/blog/mybundle/sunset1.jpg")
|
|
s.CheckExists("public/blog/mybundle/sunset1.jpg")
|
|
|
|
},
|
|
},
|
|
{"Bundle with JSON file", func(b testing.TB) *sitesBuilder {
|
|
sb := newTestSitesBuilder(b).WithConfigFile("toml", config)
|
|
sb.WithContent("content/blog/mybundle/index.md", pageContent(1))
|
|
sb.WithContent("content/blog/mybundle/mydata.json", `{ "hello": "world" }`)
|
|
|
|
return sb
|
|
},
|
|
func(s *sitesBuilder) {
|
|
s.AssertFileContent("public/blog/mybundle/index.html", "Resources: application/json: /blog/mybundle/mydata.json")
|
|
s.CheckExists("public/blog/mybundle/mydata.json")
|
|
|
|
},
|
|
},
|
|
{"Tags and categories", func(b testing.TB) *sitesBuilder {
|
|
sb := newTestSitesBuilder(b).WithConfigFile("toml", `
|
|
title = "Tags and Cats"
|
|
baseURL = "https://example.com"
|
|
|
|
`)
|
|
|
|
const pageTemplate = `
|
|
---
|
|
title: "Some tags and cats"
|
|
categories: ["caGR", "cbGR"]
|
|
tags: ["taGR", "tbGR"]
|
|
---
|
|
|
|
Some content.
|
|
|
|
`
|
|
for i := 1; i <= 100; i++ {
|
|
content := strings.Replace(pageTemplate, "GR", strconv.Itoa(i/3), -1)
|
|
sb.WithContent(fmt.Sprintf("content/page%d.md", i), content)
|
|
}
|
|
|
|
return sb
|
|
},
|
|
func(s *sitesBuilder) {
|
|
s.AssertFileContent("public/page3/index.html", "/page3/|Permalink: https://example.com/page3/")
|
|
s.AssertFileContent("public/tags/ta3/index.html", "|ta3|")
|
|
},
|
|
},
|
|
{"Canonify URLs", func(b testing.TB) *sitesBuilder {
|
|
sb := newTestSitesBuilder(b).WithConfigFile("toml", `
|
|
title = "Canon"
|
|
baseURL = "https://example.com"
|
|
canonifyURLs = true
|
|
|
|
`)
|
|
for i := 1; i <= 100; i++ {
|
|
sb.WithContent(fmt.Sprintf("content/page%d.md", i), pageContent(i))
|
|
}
|
|
|
|
return sb
|
|
},
|
|
func(s *sitesBuilder) {
|
|
s.AssertFileContent("public/page8/index.html", "https://example.com/about/")
|
|
},
|
|
},
|
|
|
|
{"Deep content tree", func(b testing.TB) *sitesBuilder {
|
|
return getBenchmarkSiteDeepContent(b)
|
|
},
|
|
func(s *sitesBuilder) {
|
|
s.CheckExists("public/blog/mybundle/index.html")
|
|
s.Assert(len(s.H.Sites), qt.Equals, 4)
|
|
s.Assert(len(s.H.Sites[0].RegularPages()), qt.Equals, len(s.H.Sites[1].RegularPages()))
|
|
s.Assert(len(s.H.Sites[0].RegularPages()), qt.Equals, 30)
|
|
|
|
},
|
|
},
|
|
{"Many HTML templates", func(b testing.TB) *sitesBuilder {
|
|
|
|
pageTemplateTemplate := `
|
|
<!DOCTYPE html>
|
|
<html>
|
|
<head>
|
|
<meta charset="utf-8">
|
|
<title>{{ if not .IsPage }}{{ .Title }}{{ else }}{{ printf "Site: %s" site.Title }}{{ end }}</title>
|
|
<style>
|
|
body {
|
|
margin: 3rem;
|
|
}
|
|
</style>
|
|
</head>
|
|
<body>
|
|
<div class="page">{{ .Content }}</div>
|
|
<ul>
|
|
{{ with .Pages }}
|
|
{{ range . }}
|
|
<li><a href="{{ .RelPermalink }}">{{ .LinkTitle }} {{ if not .IsNode }} (Page){{ end }}</a></li>
|
|
{{ end }}
|
|
{{ end }}
|
|
</ul>
|
|
</body>
|
|
</html>
|
|
`
|
|
|
|
sb := newTestSitesBuilder(b).WithConfigFile("toml", `
|
|
baseURL = "https://example.com"
|
|
|
|
[languages]
|
|
[languages.en]
|
|
weight=1
|
|
contentDir="content/en"
|
|
[languages.fr]
|
|
weight=2
|
|
contentDir="content/fr"
|
|
[languages.no]
|
|
weight=3
|
|
contentDir="content/no"
|
|
[languages.sv]
|
|
weight=4
|
|
contentDir="content/sv"
|
|
|
|
`)
|
|
|
|
createContent := func(dir, name string) {
|
|
sb.WithContent(filepath.Join("content", dir, name), pageContent(1))
|
|
}
|
|
|
|
for _, lang := range []string{"en", "fr", "no", "sv"} {
|
|
sb.WithTemplatesAdded(fmt.Sprintf("_default/single.%s.html", lang), pageTemplateTemplate)
|
|
sb.WithTemplatesAdded(fmt.Sprintf("_default/list.%s.html", lang), pageTemplateTemplate)
|
|
|
|
for level := 1; level <= 5; level++ {
|
|
sectionDir := path.Join(lang, strings.Repeat("section/", level))
|
|
createContent(sectionDir, "_index.md")
|
|
for i := 1; i <= 3; i++ {
|
|
leafBundleDir := path.Join(sectionDir, fmt.Sprintf("bundle%d", i))
|
|
createContent(leafBundleDir, "index.md")
|
|
}
|
|
}
|
|
}
|
|
|
|
return sb
|
|
},
|
|
func(s *sitesBuilder) {
|
|
s.CheckExists("public/blog/mybundle/index.html")
|
|
s.Assert(len(s.H.Sites), qt.Equals, 4)
|
|
s.Assert(len(s.H.Sites[0].RegularPages()), qt.Equals, len(s.H.Sites[1].RegularPages()))
|
|
s.Assert(len(s.H.Sites[0].RegularPages()), qt.Equals, 15)
|
|
|
|
},
|
|
},
|
|
{"Page collections", func(b testing.TB) *sitesBuilder {
|
|
|
|
pageTemplateTemplate := `
|
|
{{ if .IsNode }}
|
|
{{ len .Paginator.Pages }}
|
|
{{ end }}
|
|
{{ len .Sections }}
|
|
{{ len .Pages }}
|
|
{{ len .RegularPages }}
|
|
{{ len .Resources }}
|
|
{{ len site.RegularPages }}
|
|
{{ len site.Pages }}
|
|
{{ with .NextInSection }}Next in section: {{ .RelPermalink }}{{ end }}
|
|
{{ with .PrevInSection }}Prev in section: {{ .RelPermalink }}{{ end }}
|
|
{{ with .Next }}Next: {{ .RelPermalink }}{{ end }}
|
|
{{ with .Prev }}Prev: {{ .RelPermalink }}{{ end }}
|
|
`
|
|
|
|
sb := newTestSitesBuilder(b).WithConfigFile("toml", `
|
|
baseURL = "https://example.com"
|
|
|
|
[languages]
|
|
[languages.en]
|
|
weight=1
|
|
contentDir="content/en"
|
|
[languages.fr]
|
|
weight=2
|
|
contentDir="content/fr"
|
|
[languages.no]
|
|
weight=3
|
|
contentDir="content/no"
|
|
[languages.sv]
|
|
weight=4
|
|
contentDir="content/sv"
|
|
|
|
`)
|
|
|
|
sb.WithTemplatesAdded("index.html", pageTemplateTemplate)
|
|
sb.WithTemplatesAdded("_default/single.html", pageTemplateTemplate)
|
|
sb.WithTemplatesAdded("_default/list.html", pageTemplateTemplate)
|
|
|
|
createContent := func(dir, name string) {
|
|
sb.WithContent(filepath.Join("content", dir, name), pageContent(1))
|
|
}
|
|
|
|
createBundledFiles := func(dir string) {
|
|
sb.WithContent(filepath.Join("content", dir, "data.json"), `{ "hello": "world" }`)
|
|
for i := 1; i <= 3; i++ {
|
|
sb.WithContent(filepath.Join("content", dir, fmt.Sprintf("page%d.md", i)), pageContent(1))
|
|
}
|
|
}
|
|
|
|
r := rand.New(rand.NewSource(99))
|
|
|
|
for _, lang := range []string{"en", "fr", "no", "sv"} {
|
|
for level := 1; level <= r.Intn(5)+1; level++ {
|
|
sectionDir := path.Join(lang, strings.Repeat("section/", level))
|
|
createContent(sectionDir, "_index.md")
|
|
createBundledFiles(sectionDir)
|
|
for i := 1; i <= r.Intn(20)+1; i++ {
|
|
leafBundleDir := path.Join(sectionDir, fmt.Sprintf("bundle%d", i))
|
|
createContent(leafBundleDir, "index.md")
|
|
createBundledFiles(path.Join(leafBundleDir, "assets1"))
|
|
createBundledFiles(path.Join(leafBundleDir, "assets1", "assets2"))
|
|
}
|
|
}
|
|
}
|
|
|
|
return sb
|
|
},
|
|
func(s *sitesBuilder) {
|
|
s.CheckExists("public/blog/mybundle/index.html")
|
|
s.Assert(len(s.H.Sites), qt.Equals, 4)
|
|
s.Assert(len(s.H.Sites[0].RegularPages()), qt.Equals, 26)
|
|
|
|
},
|
|
},
|
|
}
|
|
|
|
return benchmarks
|
|
|
|
}
|
|
|
|
// Run the benchmarks below as tests. Mostly useful when adding new benchmark
|
|
// variants.
|
|
func TestBenchmarkSiteNew(b *testing.T) {
|
|
benchmarks := getBenchmarkSiteNewTestCases()
|
|
for _, bm := range benchmarks {
|
|
b.Run(bm.name, func(b *testing.T) {
|
|
s := bm.create(b)
|
|
|
|
err := s.BuildE(BuildCfg{})
|
|
if err != nil {
|
|
b.Fatal(err)
|
|
}
|
|
bm.check(s)
|
|
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestBenchmarkSiteDeepContentEdit(t *testing.T) {
|
|
b := getBenchmarkSiteDeepContent(t).Running()
|
|
b.Build(BuildCfg{})
|
|
|
|
p := b.H.Sites[0].RegularPages()[12]
|
|
|
|
b.EditFiles(p.File().Filename(), fmt.Sprintf(`---
|
|
title: %s
|
|
---
|
|
|
|
Edited!!`, p.Title()))
|
|
|
|
counters := &testCounters{}
|
|
|
|
b.Build(BuildCfg{testCounters: counters})
|
|
|
|
// We currently rebuild all the language versions of the same content file.
|
|
// We could probably optimize that case, but it's not trivial.
|
|
b.Assert(int(counters.contentRenderCounter), qt.Equals, 4)
|
|
b.AssertFileContent("public"+p.RelPermalink()+"index.html", "Edited!!")
|
|
|
|
}
|
|
|
|
func BenchmarkSiteNew(b *testing.B) {
|
|
rnd := rand.New(rand.NewSource(32))
|
|
benchmarks := getBenchmarkSiteNewTestCases()
|
|
for _, edit := range []bool{true, false} {
|
|
for _, bm := range benchmarks {
|
|
name := bm.name
|
|
if edit {
|
|
name = "Edit_" + name
|
|
} else {
|
|
name = "Regular_" + name
|
|
}
|
|
b.Run(name, func(b *testing.B) {
|
|
sites := make([]*sitesBuilder, b.N)
|
|
for i := 0; i < b.N; i++ {
|
|
sites[i] = bm.create(b)
|
|
if edit {
|
|
sites[i].Running()
|
|
}
|
|
}
|
|
|
|
b.ResetTimer()
|
|
for i := 0; i < b.N; i++ {
|
|
if edit {
|
|
b.StopTimer()
|
|
}
|
|
s := sites[i]
|
|
err := s.BuildE(BuildCfg{})
|
|
if err != nil {
|
|
b.Fatal(err)
|
|
}
|
|
bm.check(s)
|
|
|
|
if edit {
|
|
if edit {
|
|
b.StartTimer()
|
|
}
|
|
// Edit a random page in a random language.
|
|
pages := s.H.Sites[rnd.Intn(len(s.H.Sites))].Pages()
|
|
var p page.Page
|
|
count := 0
|
|
for {
|
|
count++
|
|
if count > 100 {
|
|
panic("infinite loop")
|
|
}
|
|
p = pages[rnd.Intn(len(pages))]
|
|
if !p.File().IsZero() {
|
|
break
|
|
}
|
|
}
|
|
|
|
s.EditFiles(p.File().Filename(), fmt.Sprintf(`---
|
|
title: %s
|
|
---
|
|
|
|
Edited!!`, p.Title()))
|
|
|
|
err := s.BuildE(BuildCfg{})
|
|
if err != nil {
|
|
b.Fatal(err)
|
|
}
|
|
}
|
|
}
|
|
})
|
|
}
|
|
}
|
|
}
|