github/hugo
1
0
Fork 0
mirror of https://github.com/gohugoio/hugo.git synced 2024-11-14 20:37:55 -05:00
Code Issues Projects Releases Packages Wiki Activity
hugo/tpl/internal/go_templates/texttemplate
History
Bjørn Erik Pedersen 929808190f tpl/partials: Fix recently introduced deadlock in partials cache 
The change in lock logic for `partialCached` in  0927cf739f was naive as it didn't consider cached partials calling other cached partials.

This changeset may look on the large side for this particular issue, but it pulls in part of a working branch, introducing `context.Context` in the template execution.

Note that the context is only partially implemented in this PR, but the upcoming use cases will, as one example, include having access to the top "dot" (e.g. `Page`) all the way down into partials and shortcodes etc.

The earlier benchmarks rerun against master:

```bash
name              old time/op    new time/op    delta
IncludeCached-10    13.6ms ± 2%    13.8ms ± 1%    ~     (p=0.343 n=4+4)

name              old alloc/op   new alloc/op   delta
IncludeCached-10    5.30MB ± 0%    5.35MB ± 0%  +0.96%  (p=0.029 n=4+4)

name              old allocs/op  new allocs/op  delta
IncludeCached-10     74.7k ± 0%     75.3k ± 0%  +0.77%  (p=0.029 n=4+4)
```

Fixes #9519
2022-02-17 18:47:36 +01:00
..
parse tpl/internal: Synch Go templates fork with Go 1.16dev 2021-02-18 14:11:48 +01:00
testdata Create lightweight forks of text/template and html/template 2019-12-12 09:59:34 +01:00
doc.go tpl/internal: Synch Go templates fork with Go 1.16dev 2021-02-18 14:11:48 +01:00
example_test.go tpl/internal/go_templates: Revert formatting 2020-12-03 13:47:43 +01:00
examplefiles_test.go Pull in latest Go template source 2021-02-18 14:11:48 +01:00
examplefunc_test.go Create lightweight forks of text/template and html/template 2019-12-12 09:59:34 +01:00
exec.go Add resources.GetRemote 2021-12-17 09:33:51 +01:00
exec_test.go Pull in latest Go template source 2021-02-18 14:11:48 +01:00
funcs.go Fix Go template script escaping 2020-05-23 22:00:34 +02:00
helper.go Pull in latest Go template source 2021-02-18 14:11:48 +01:00
hugo_template.go tpl/partials: Fix recently introduced deadlock in partials cache 2022-02-17 18:47:36 +01:00
hugo_template_test.go tpl/partials: Fix recently introduced deadlock in partials cache 2022-02-17 18:47:36 +01:00
link_test.go Pull in latest Go template source 2021-02-18 14:11:48 +01:00
multi_test.go tpl/internal: Synch Go templates fork with Go 1.16dev 2021-02-18 14:11:48 +01:00
option.go Create lightweight forks of text/template and html/template 2019-12-12 09:59:34 +01:00
template.go tpl: Add temporary patch to fix template data race 2021-02-18 14:11:48 +01:00