mirror of
https://github.com/gohugoio/hugo.git
synced 2024-12-01 15:19:09 -05:00
5c41653364
Looking at the code as a whole, we ended up with a little to much "buttons". It turns out that doing case insensitive matching (lower both pattern and strings to match) performs just fine. Or at least, it gives the penalty to the people who uses mixed case filenames. ``` GetGlob/Default_cache-10 10.6ns ± 2% 10.6ns ± 1% ~ (p=0.657 n=4+4) GetGlob/Filenames_cache,_lowercase_searchs-10 10.6ns ± 2% 10.6ns ± 0% ~ (p=1.000 n=4+4) GetGlob/Filenames_cache,_mixed_case_searchs-10 29.7ns ± 1% 29.6ns ± 1% ~ (p=0.886 n=4+4) GetGlob/GetGlob-10 13.7ns ± 1% 13.7ns ± 0% ~ (p=0.429 n=4+4) name old alloc/op new alloc/op delta GetGlob/Default_cache-10 0.00B 0.00B ~ (all equal) GetGlob/Filenames_cache,_lowercase_searchs-10 0.00B 0.00B ~ (all equal) GetGlob/Filenames_cache,_mixed_case_searchs-10 5.00B ± 0% 5.00B ± 0% ~ (all equal) GetGlob/GetGlob-10 0.00B 0.00B ~ (all equal) name old allocs/op new allocs/op delta GetGlob/Default_cache-10 0.00 0.00 ~ (all equal) GetGlob/Filenames_cache,_lowercase_searchs-10 0.00 0.00 ~ (all equal) GetGlob/Filenames_cache,_mixed_case_searchs-10 1.00 ± 0% 1.00 ± 0% ~ (all equal) GetGlob/GetGlob-10 ```
67 lines
1.9 KiB
Go
67 lines
1.9 KiB
Go
// Copyright 2019 The Hugo Authors. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package hugofs
|
|
|
|
import (
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"github.com/spf13/afero"
|
|
|
|
qt "github.com/frankban/quicktest"
|
|
)
|
|
|
|
func TestGlob(t *testing.T) {
|
|
c := qt.New(t)
|
|
|
|
fs := NewBaseFileDecorator(afero.NewMemMapFs())
|
|
|
|
create := func(filename string) {
|
|
err := afero.WriteFile(fs, filepath.FromSlash(filename), []byte("content "+filename), 0777)
|
|
c.Assert(err, qt.IsNil)
|
|
}
|
|
|
|
collect := func(pattern string) []string {
|
|
var paths []string
|
|
h := func(fi FileMetaInfo) (bool, error) {
|
|
paths = append(paths, fi.Meta().Path)
|
|
return false, nil
|
|
}
|
|
err := Glob(fs, pattern, h)
|
|
c.Assert(err, qt.IsNil)
|
|
return paths
|
|
}
|
|
|
|
create("root.json")
|
|
create("jsonfiles/d1.json")
|
|
create("jsonfiles/d2.json")
|
|
create("jsonfiles/sub/d3.json")
|
|
create("jsonfiles/d1.xml")
|
|
create("a/b/c/e/f.json")
|
|
create("UPPER/sub/style.css")
|
|
create("root/UPPER/sub/style.css")
|
|
|
|
c.Assert(collect(filepath.FromSlash("/jsonfiles/*.json")), qt.HasLen, 2)
|
|
|
|
c.Assert(collect("**.json"), qt.HasLen, 5)
|
|
c.Assert(collect("**"), qt.HasLen, 8)
|
|
c.Assert(collect(""), qt.HasLen, 0)
|
|
c.Assert(collect("jsonfiles/*.json"), qt.HasLen, 2)
|
|
c.Assert(collect("*.json"), qt.HasLen, 1)
|
|
c.Assert(collect("**.xml"), qt.HasLen, 1)
|
|
|
|
c.Assert(collect("root/UPPER/sub/style.css"), qt.HasLen, 1)
|
|
c.Assert(collect("UPPER/sub/style.css"), qt.HasLen, 1)
|
|
|
|
}
|