mirror of
https://github.com/gohugoio/hugo.git
synced 2024-12-28 14:01:04 +00:00
4576c82ed4
The isolated benchmark for the function is obviously much faster: ```bash name old time/op new time/op delta GetMethodByName-10 1.21µs ± 7% 0.23µs ± 5% -81.42% (p=0.029 n=4+4) name old alloc/op new alloc/op delta GetMethodByName-10 680B ± 0% 0B -100.00% (p=0.029 n=4+4) name old allocs/op new allocs/op delta GetMethodByName-10 20.0 ± 0% 0.0 -100.00% (p=0.029 n=4+4) ``` But more pleasing is the overall performance looking at the site benchmarks: ```bash name old time/op new time/op delta SiteNew/Regular_Bundle_with_image-10 6.25ms ± 2% 6.10ms ± 2% ~ (p=0.057 n=4+4) SiteNew/Regular_Bundle_with_JSON_file-10 6.30ms ± 2% 5.66ms ±11% ~ (p=0.057 n=4+4) SiteNew/Regular_Tags_and_categories-10 22.2ms ± 2% 17.4ms ± 1% -21.88% (p=0.029 n=4+4) SiteNew/Regular_Canonify_URLs-10 108ms ± 0% 107ms ± 0% -1.20% (p=0.029 n=4+4) SiteNew/Regular_Deep_content_tree-10 36.1ms ± 1% 33.8ms ± 1% -6.44% (p=0.029 n=4+4) SiteNew/Regular_TOML_front_matter-10 24.9ms ± 1% 22.6ms ± 1% -9.30% (p=0.029 n=4+4) SiteNew/Regular_Many_HTML_templates-10 17.9ms ± 1% 16.7ms ± 1% -6.43% (p=0.029 n=4+4) SiteNew/Regular_Page_collections-10 23.3ms ± 1% 22.0ms ± 0% -5.58% (p=0.029 n=4+4) SiteNew/Regular_List_terms-10 8.00ms ± 1% 7.63ms ± 0% -4.62% (p=0.029 n=4+4) name old alloc/op new alloc/op delta SiteNew/Regular_Bundle_with_image-10 2.10MB ± 0% 2.07MB ± 0% -1.46% (p=0.029 n=4+4) SiteNew/Regular_Bundle_with_JSON_file-10 1.88MB ± 0% 1.85MB ± 0% -1.76% (p=0.029 n=4+4) SiteNew/Regular_Tags_and_categories-10 13.5MB ± 0% 11.6MB ± 0% -13.99% (p=0.029 n=4+4) SiteNew/Regular_Canonify_URLs-10 96.1MB ± 0% 95.8MB ± 0% -0.40% (p=0.029 n=4+4) SiteNew/Regular_Deep_content_tree-10 28.4MB ± 0% 27.3MB ± 0% -3.83% (p=0.029 n=4+4) SiteNew/Regular_TOML_front_matter-10 16.9MB ± 0% 15.1MB ± 0% -10.58% (p=0.029 n=4+4) SiteNew/Regular_Many_HTML_templates-10 8.98MB ± 0% 8.44MB ± 0% -6.04% (p=0.029 n=4+4) SiteNew/Regular_Page_collections-10 17.1MB ± 0% 16.5MB ± 0% -3.91% (p=0.029 n=4+4) SiteNew/Regular_List_terms-10 3.92MB ± 0% 3.72MB ± 0% -5.03% (p=0.029 n=4+4) name old allocs/op new allocs/op delta SiteNew/Regular_Bundle_with_image-10 25.8k ± 0% 24.9k ± 0% -3.49% (p=0.029 n=4+4) SiteNew/Regular_Bundle_with_JSON_file-10 25.8k ± 0% 24.9k ± 0% -3.49% (p=0.029 n=4+4) SiteNew/Regular_Tags_and_categories-10 288k ± 0% 233k ± 0% -18.90% (p=0.029 n=4+4) SiteNew/Regular_Canonify_URLs-10 375k ± 0% 364k ± 0% -2.80% (p=0.029 n=4+4) SiteNew/Regular_Deep_content_tree-10 314k ± 0% 283k ± 0% -9.77% (p=0.029 n=4+4) SiteNew/Regular_TOML_front_matter-10 302k ± 0% 252k ± 0% -16.55% (p=0.029 n=4+4) SiteNew/Regular_Many_HTML_templates-10 133k ± 0% 117k ± 0% -11.81% (p=0.029 n=4+4) SiteNew/Regular_Page_collections-10 202k ± 0% 183k ± 0% -9.55% (p=0.029 n=4+4) SiteNew/Regular_List_terms-10 55.6k ± 0% 49.8k ± 0% -10.40% (p=0.029 n=4+4) ``` Thanks to @quasilyte for the suggestion. Fixes 9386
182 lines
4.7 KiB
Go
182 lines
4.7 KiB
Go
// Copyright 2019 The Hugo Authors. All rights reserved.
|
|
// Some functions in this file (see comments) is based on the Go source code,
|
|
// copyright The Go Authors and governed by a BSD-style license.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
// Package hreflect contains reflect helpers.
|
|
package hreflect
|
|
|
|
import (
|
|
"context"
|
|
"reflect"
|
|
"sync"
|
|
|
|
"github.com/gohugoio/hugo/common/types"
|
|
)
|
|
|
|
// TODO(bep) replace the private versions in /tpl with these.
|
|
// IsNumber returns whether the given kind is a number.
|
|
func IsNumber(kind reflect.Kind) bool {
|
|
return IsInt(kind) || IsUint(kind) || IsFloat(kind)
|
|
}
|
|
|
|
// IsInt returns whether the given kind is an int.
|
|
func IsInt(kind reflect.Kind) bool {
|
|
switch kind {
|
|
case reflect.Int, reflect.Int8, reflect.Int16, reflect.Int32, reflect.Int64:
|
|
return true
|
|
default:
|
|
return false
|
|
}
|
|
}
|
|
|
|
// IsUint returns whether the given kind is an uint.
|
|
func IsUint(kind reflect.Kind) bool {
|
|
switch kind {
|
|
case reflect.Uint, reflect.Uint8, reflect.Uint16, reflect.Uint32, reflect.Uint64:
|
|
return true
|
|
default:
|
|
return false
|
|
}
|
|
}
|
|
|
|
// IsFloat returns whether the given kind is a float.
|
|
func IsFloat(kind reflect.Kind) bool {
|
|
switch kind {
|
|
case reflect.Float32, reflect.Float64:
|
|
return true
|
|
default:
|
|
return false
|
|
}
|
|
}
|
|
|
|
// IsTruthful returns whether in represents a truthful value.
|
|
// See IsTruthfulValue
|
|
func IsTruthful(in interface{}) bool {
|
|
switch v := in.(type) {
|
|
case reflect.Value:
|
|
return IsTruthfulValue(v)
|
|
default:
|
|
return IsTruthfulValue(reflect.ValueOf(in))
|
|
}
|
|
}
|
|
|
|
var zeroType = reflect.TypeOf((*types.Zeroer)(nil)).Elem()
|
|
|
|
// IsTruthfulValue returns whether the given value has a meaningful truth value.
|
|
// This is based on template.IsTrue in Go's stdlib, but also considers
|
|
// IsZero and any interface value will be unwrapped before it's considered
|
|
// for truthfulness.
|
|
//
|
|
// Based on:
|
|
// https://github.com/golang/go/blob/178a2c42254166cffed1b25fb1d3c7a5727cada6/src/text/template/exec.go#L306
|
|
func IsTruthfulValue(val reflect.Value) (truth bool) {
|
|
val = indirectInterface(val)
|
|
|
|
if !val.IsValid() {
|
|
// Something like var x interface{}, never set. It's a form of nil.
|
|
return
|
|
}
|
|
|
|
if val.Type().Implements(zeroType) {
|
|
return !val.Interface().(types.Zeroer).IsZero()
|
|
}
|
|
|
|
switch val.Kind() {
|
|
case reflect.Array, reflect.Map, reflect.Slice, reflect.String:
|
|
truth = val.Len() > 0
|
|
case reflect.Bool:
|
|
truth = val.Bool()
|
|
case reflect.Complex64, reflect.Complex128:
|
|
truth = val.Complex() != 0
|
|
case reflect.Chan, reflect.Func, reflect.Ptr, reflect.Interface:
|
|
truth = !val.IsNil()
|
|
case reflect.Int, reflect.Int8, reflect.Int16, reflect.Int32, reflect.Int64:
|
|
truth = val.Int() != 0
|
|
case reflect.Float32, reflect.Float64:
|
|
truth = val.Float() != 0
|
|
case reflect.Uint, reflect.Uint8, reflect.Uint16, reflect.Uint32, reflect.Uint64, reflect.Uintptr:
|
|
truth = val.Uint() != 0
|
|
case reflect.Struct:
|
|
truth = true // Struct values are always true.
|
|
default:
|
|
return
|
|
}
|
|
|
|
return
|
|
}
|
|
|
|
type methodKey struct {
|
|
typ reflect.Type
|
|
name string
|
|
}
|
|
|
|
type methods struct {
|
|
sync.RWMutex
|
|
cache map[methodKey]int
|
|
}
|
|
|
|
var methodCache = &methods{cache: make(map[methodKey]int)}
|
|
|
|
// GetMethodByName is the samve as reflect.Value.MethodByName, but it caches the
|
|
// type lookup.
|
|
func GetMethodByName(v reflect.Value, name string) reflect.Value {
|
|
index := GetMethodIndexByName(v.Type(), name)
|
|
|
|
if index == -1 {
|
|
return reflect.Value{}
|
|
}
|
|
|
|
return v.Method(index)
|
|
}
|
|
|
|
// GetMethodIndexByName returns the index of the method with the given name, or
|
|
// -1 if no such method exists.
|
|
func GetMethodIndexByName(tp reflect.Type, name string) int {
|
|
k := methodKey{tp, name}
|
|
methodCache.RLock()
|
|
index, found := methodCache.cache[k]
|
|
methodCache.RUnlock()
|
|
if found {
|
|
return index
|
|
}
|
|
|
|
methodCache.Lock()
|
|
defer methodCache.Unlock()
|
|
|
|
m, ok := tp.MethodByName(name)
|
|
index = m.Index
|
|
if !ok {
|
|
index = -1
|
|
}
|
|
methodCache.cache[k] = index
|
|
|
|
if !ok {
|
|
return -1
|
|
}
|
|
|
|
return m.Index
|
|
}
|
|
|
|
// Based on: https://github.com/golang/go/blob/178a2c42254166cffed1b25fb1d3c7a5727cada6/src/text/template/exec.go#L931
|
|
func indirectInterface(v reflect.Value) reflect.Value {
|
|
if v.Kind() != reflect.Interface {
|
|
return v
|
|
}
|
|
if v.IsNil() {
|
|
return reflect.Value{}
|
|
}
|
|
return v.Elem()
|
|
}
|
|
|
|
var ContextInterface = reflect.TypeOf((*context.Context)(nil)).Elem()
|