mirror of
https://github.com/gohugoio/hugo.git
synced 2024-11-29 04:32:10 -05:00
0927cf739f
This commit revises the locking strategy for `partialCached`. We have added a benchmark that may be a little artificial, but it should at least show that we're not losing any performance over this:
```bash
name old time/op new time/op delta
IncludeCached-10 12.2ms ± 2% 11.3ms ± 1% -7.36% (p=0.029 n=4+4)
name old alloc/op new alloc/op delta
IncludeCached-10 7.17MB ± 0% 5.09MB ± 0% -29.00% (p=0.029 n=4+4)
name old allocs/op new allocs/op delta
IncludeCached-10 128k ± 1% 70k ± 0% -45.42% (p=0.029 n=4+4)
```
This commit also revises the template metrics hints logic a little, and add a test for it, which output is currently this:
```bash
cumulative average maximum cache percent cached total
duration duration duration potential cached count count template
---------- -------- -------- --------- ------- ------ ----- --------
163.334µs 163.334µs 163.334µs 0 0 0 1 index.html
23.749µs 5.937µs 19.916µs 25 50 2 4 partials/dynamic1.html
9.625µs 4.812µs 6.75µs 100 50 1 2 partials/static1.html
7.625µs 7.625µs 7.625µs 100 0 0 1 partials/static2.html
```
Some notes:
* The duration now includes the cached invocations (which should be very short)
* A cached template gets executed once before it gets cached, so the "percent cached" will never be 100.
Fixes #4086
Fixes #9506
55 lines
1.5 KiB
Go
55 lines
1.5 KiB
Go
// Copyright 2017 The Hugo Authors. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package partials
|
|
|
|
import (
|
|
"github.com/gohugoio/hugo/deps"
|
|
"github.com/gohugoio/hugo/tpl/internal"
|
|
)
|
|
|
|
const namespaceName = "partials"
|
|
|
|
func init() {
|
|
f := func(d *deps.Deps) *internal.TemplateFuncsNamespace {
|
|
ctx := New(d)
|
|
|
|
ns := &internal.TemplateFuncsNamespace{
|
|
Name: namespaceName,
|
|
Context: func(args ...interface{}) (interface{}, error) { return ctx, nil },
|
|
}
|
|
|
|
ns.AddMethodMapping(ctx.Include,
|
|
[]string{"partial"},
|
|
[][2]string{
|
|
{`{{ partial "header.html" . }}`, `<title>Hugo Rocks!</title>`},
|
|
},
|
|
)
|
|
|
|
// TODO(bep) we need the return to be a valid identifier, but
|
|
// should consider another way of adding it.
|
|
ns.AddMethodMapping(func() string { return "" },
|
|
[]string{"return"},
|
|
[][2]string{},
|
|
)
|
|
|
|
ns.AddMethodMapping(ctx.IncludeCached,
|
|
[]string{"partialCached"},
|
|
[][2]string{},
|
|
)
|
|
|
|
return ns
|
|
}
|
|
|
|
internal.AddTemplateFuncsNamespace(f)
|
|
}
|