mirror of
https://github.com/gohugoio/hugo.git
synced 2024-11-21 20:46:30 -05:00
c6d650c8c8
This more or less completes the simplification of the template handling code in Hugo started in v0.62. The main motivation was to fix a long lasting issue about a crash in HTML content files without front matter. But this commit also comes with a big functional improvement. As we now have moved the base template evaluation to the build stage we now use the same lookup rules for `baseof` as for `list` etc. type of templates. This means that in this simple example you can have a `baseof` template for the `blog` section without having to duplicate the others: ``` layouts ├── _default │ ├── baseof.html │ ├── list.html │ └── single.html └── blog └── baseof.html ``` Also, when simplifying code, you often get rid of some double work, as shown in the "site building" benchmarks below. These benchmarks looks suspiciously good, but I have repeated the below with ca. the same result. Compared to master: ``` name old time/op new time/op delta SiteNew/Bundle_with_image-16 13.1ms ± 1% 10.5ms ± 1% -19.34% (p=0.029 n=4+4) SiteNew/Bundle_with_JSON_file-16 13.0ms ± 0% 10.7ms ± 1% -18.05% (p=0.029 n=4+4) SiteNew/Tags_and_categories-16 46.4ms ± 2% 43.1ms ± 1% -7.15% (p=0.029 n=4+4) SiteNew/Canonify_URLs-16 52.2ms ± 2% 47.8ms ± 1% -8.30% (p=0.029 n=4+4) SiteNew/Deep_content_tree-16 77.9ms ± 1% 70.9ms ± 1% -9.01% (p=0.029 n=4+4) SiteNew/Many_HTML_templates-16 43.0ms ± 0% 37.2ms ± 1% -13.54% (p=0.029 n=4+4) SiteNew/Page_collections-16 58.2ms ± 1% 52.4ms ± 1% -9.95% (p=0.029 n=4+4) name old alloc/op new alloc/op delta SiteNew/Bundle_with_image-16 3.81MB ± 0% 2.22MB ± 0% -41.70% (p=0.029 n=4+4) SiteNew/Bundle_with_JSON_file-16 3.60MB ± 0% 2.01MB ± 0% -44.20% (p=0.029 n=4+4) SiteNew/Tags_and_categories-16 19.3MB ± 1% 14.1MB ± 0% -26.91% (p=0.029 n=4+4) SiteNew/Canonify_URLs-16 70.7MB ± 0% 69.0MB ± 0% -2.40% (p=0.029 n=4+4) SiteNew/Deep_content_tree-16 37.1MB ± 0% 31.2MB ± 0% -15.94% (p=0.029 n=4+4) SiteNew/Many_HTML_templates-16 17.6MB ± 0% 10.6MB ± 0% -39.92% (p=0.029 n=4+4) SiteNew/Page_collections-16 25.9MB ± 0% 21.2MB ± 0% -17.99% (p=0.029 n=4+4) name old allocs/op new allocs/op delta SiteNew/Bundle_with_image-16 52.3k ± 0% 26.1k ± 0% -50.18% (p=0.029 n=4+4) SiteNew/Bundle_with_JSON_file-16 52.3k ± 0% 26.1k ± 0% -50.16% (p=0.029 n=4+4) SiteNew/Tags_and_categories-16 336k ± 1% 269k ± 0% -19.90% (p=0.029 n=4+4) SiteNew/Canonify_URLs-16 422k ± 0% 395k ± 0% -6.43% (p=0.029 n=4+4) SiteNew/Deep_content_tree-16 401k ± 0% 313k ± 0% -21.79% (p=0.029 n=4+4) SiteNew/Many_HTML_templates-16 247k ± 0% 143k ± 0% -42.17% (p=0.029 n=4+4) SiteNew/Page_collections-16 282k ± 0% 207k ± 0% -26.55% (p=0.029 n=4+4) ``` Fixes #6716 Fixes #6760 Fixes #6768 Fixes #6778
149 lines
4.4 KiB
Go
149 lines
4.4 KiB
Go
// Copyright 2017 The Hugo Authors. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package create
|
|
|
|
import (
|
|
"bytes"
|
|
"fmt"
|
|
"path/filepath"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/pkg/errors"
|
|
|
|
"github.com/gohugoio/hugo/helpers"
|
|
"github.com/gohugoio/hugo/source"
|
|
|
|
"github.com/gohugoio/hugo/hugolib"
|
|
"github.com/gohugoio/hugo/tpl"
|
|
"github.com/spf13/afero"
|
|
)
|
|
|
|
// ArchetypeFileData represents the data available to an archetype template.
|
|
type ArchetypeFileData struct {
|
|
// The archetype content type, either given as --kind option or extracted
|
|
// from the target path's section, i.e. "blog/mypost.md" will resolve to
|
|
// "blog".
|
|
Type string
|
|
|
|
// The current date and time as a RFC3339 formatted string, suitable for use in front matter.
|
|
Date string
|
|
|
|
// The Site, fully equipped with all the pages etc. Note: This will only be set if it is actually
|
|
// used in the archetype template. Also, if this is a multilingual setup,
|
|
// this site is the site that best matches the target content file, based
|
|
// on the presence of language code in the filename.
|
|
Site *hugolib.SiteInfo
|
|
|
|
// Name will in most cases be the same as TranslationBaseName, e.g. "my-post".
|
|
// But if that value is "index" (bundles), the Name is instead the owning folder.
|
|
// This is the value you in most cases would want to use to construct the title in your
|
|
// archetype template.
|
|
Name string
|
|
|
|
// The target content file. Note that the .Content will be empty, as that
|
|
// has not been created yet.
|
|
source.File
|
|
}
|
|
|
|
const (
|
|
// ArchetypeTemplateTemplate is used as initial template when adding an archetype template.
|
|
ArchetypeTemplateTemplate = `---
|
|
title: "{{ replace .Name "-" " " | title }}"
|
|
date: {{ .Date }}
|
|
draft: true
|
|
---
|
|
|
|
`
|
|
)
|
|
|
|
var (
|
|
archetypeShortcodeReplacementsPre = strings.NewReplacer(
|
|
"{{<", "{x{<",
|
|
"{{%", "{x{%",
|
|
">}}", ">}x}",
|
|
"%}}", "%}x}")
|
|
|
|
archetypeShortcodeReplacementsPost = strings.NewReplacer(
|
|
"{x{<", "{{<",
|
|
"{x{%", "{{%",
|
|
">}x}", ">}}",
|
|
"%}x}", "%}}")
|
|
)
|
|
|
|
func executeArcheTypeAsTemplate(s *hugolib.Site, name, kind, targetPath, archetypeFilename string) ([]byte, error) {
|
|
|
|
var (
|
|
archetypeContent []byte
|
|
archetypeTemplate []byte
|
|
err error
|
|
)
|
|
|
|
f, err := s.SourceSpec.NewFileInfoFrom(targetPath, targetPath)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
if name == "" {
|
|
name = f.TranslationBaseName()
|
|
|
|
if name == "index" || name == "_index" {
|
|
// Page bundles; the directory name will hopefully have a better name.
|
|
dir := strings.TrimSuffix(f.Dir(), helpers.FilePathSeparator)
|
|
_, name = filepath.Split(dir)
|
|
}
|
|
}
|
|
|
|
data := ArchetypeFileData{
|
|
Type: kind,
|
|
Date: time.Now().Format(time.RFC3339),
|
|
Name: name,
|
|
File: f,
|
|
Site: &s.Info,
|
|
}
|
|
|
|
if archetypeFilename == "" {
|
|
// TODO(bep) archetype revive the issue about wrong tpl funcs arg order
|
|
archetypeTemplate = []byte(ArchetypeTemplateTemplate)
|
|
} else {
|
|
archetypeTemplate, err = afero.ReadFile(s.BaseFs.Archetypes.Fs, archetypeFilename)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("failed to read archetype file %s", err)
|
|
}
|
|
|
|
}
|
|
|
|
// The archetype template may contain shortcodes, and these does not play well
|
|
// with the Go templates. Need to set some temporary delimiters.
|
|
archetypeTemplate = []byte(archetypeShortcodeReplacementsPre.Replace(string(archetypeTemplate)))
|
|
|
|
// Reuse the Hugo template setup to get the template funcs properly set up.
|
|
templateHandler := s.Deps.Tmpl().(tpl.TemplateManager)
|
|
templateName := helpers.Filename(archetypeFilename)
|
|
if err := templateHandler.AddTemplate("_text/"+templateName, string(archetypeTemplate)); err != nil {
|
|
return nil, errors.Wrapf(err, "Failed to parse archetype file %q:", archetypeFilename)
|
|
}
|
|
|
|
templ, _ := templateHandler.Lookup(templateName)
|
|
|
|
var buff bytes.Buffer
|
|
if err := templateHandler.Execute(templ, &buff, data); err != nil {
|
|
return nil, errors.Wrapf(err, "Failed to process archetype file %q:", archetypeFilename)
|
|
}
|
|
|
|
archetypeContent = []byte(archetypeShortcodeReplacementsPost.Replace(buff.String()))
|
|
|
|
return archetypeContent, nil
|
|
|
|
}
|