mirror of
https://github.com/gohugoio/hugo.git
synced 2024-12-26 23:11:38 +00:00
6bf010fed4
This is a pretty fundamental change in Hugo, but absolutely needed if we should have any hope of getting "multiple outputs" done. This commit's goal is to say: * Every file target path is created by `createTargetPath`, i.e. one function for all. * That function takes every page and site parameter into account, to avoid fragile string parsing to uglify etc. later on. * The path creation logic has full test coverage. * All permalinks, paginator URLs etc. are then built on top of that same logic. Fixes #1252 Fixes #2110 Closes #2374 Fixes #1885 Fixes #3102 Fixes #3179 Fixes #1641 Fixes #1989
190 lines
5.4 KiB
Go
190 lines
5.4 KiB
Go
// Copyright 2015 The Hugo Authors. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package hugolib
|
|
|
|
import (
|
|
"fmt"
|
|
"path/filepath"
|
|
"reflect"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/spf13/hugo/deps"
|
|
)
|
|
|
|
func TestByCountOrderOfTaxonomies(t *testing.T) {
|
|
t.Parallel()
|
|
taxonomies := make(map[string]string)
|
|
|
|
taxonomies["tag"] = "tags"
|
|
taxonomies["category"] = "categories"
|
|
|
|
cfg, fs := newTestCfg()
|
|
|
|
cfg.Set("taxonomies", taxonomies)
|
|
|
|
writeSource(t, fs, filepath.Join("content", "page.md"), pageYamlWithTaxonomiesA)
|
|
|
|
s := buildSingleSite(t, deps.DepsCfg{Fs: fs, Cfg: cfg}, BuildCfg{})
|
|
|
|
st := make([]string, 0)
|
|
for _, t := range s.Taxonomies["tags"].ByCount() {
|
|
st = append(st, t.Name)
|
|
}
|
|
|
|
if !reflect.DeepEqual(st, []string{"a", "b", "c"}) {
|
|
t.Fatalf("ordered taxonomies do not match [a, b, c]. Got: %s", st)
|
|
}
|
|
}
|
|
|
|
//
|
|
func TestTaxonomiesWithAndWithoutContentFile(t *testing.T) {
|
|
for _, uglyURLs := range []bool{false, true} {
|
|
t.Run(fmt.Sprintf("uglyURLs=%t", uglyURLs), func(t *testing.T) {
|
|
for _, preserveTaxonomyNames := range []bool{false, true} {
|
|
t.Run(fmt.Sprintf("preserveTaxonomyNames=%t", preserveTaxonomyNames), func(t *testing.T) {
|
|
doTestTaxonomiesWithAndWithoutContentFile(t, preserveTaxonomyNames, uglyURLs)
|
|
})
|
|
}
|
|
})
|
|
|
|
}
|
|
}
|
|
|
|
func doTestTaxonomiesWithAndWithoutContentFile(t *testing.T, preserveTaxonomyNames, uglyURLs bool) {
|
|
t.Parallel()
|
|
|
|
siteConfig := `
|
|
baseURL = "http://example.com/blog"
|
|
preserveTaxonomyNames = %t
|
|
uglyURLs = %t
|
|
|
|
paginate = 1
|
|
defaultContentLanguage = "en"
|
|
|
|
[Taxonomies]
|
|
tag = "tags"
|
|
category = "categories"
|
|
other = "others"
|
|
empty = "empties"
|
|
`
|
|
|
|
pageTemplate := `---
|
|
title: "%s"
|
|
tags:
|
|
%s
|
|
categories:
|
|
%s
|
|
others:
|
|
%s
|
|
---
|
|
# Doc
|
|
`
|
|
|
|
siteConfig = fmt.Sprintf(siteConfig, preserveTaxonomyNames, uglyURLs)
|
|
|
|
th, h := newTestSitesFromConfigWithDefaultTemplates(t, siteConfig)
|
|
require.Len(t, h.Sites, 1)
|
|
|
|
fs := th.Fs
|
|
|
|
if preserveTaxonomyNames {
|
|
writeSource(t, fs, "content/p1.md", fmt.Sprintf(pageTemplate, "t1/c1", "- tag1", "- cat1", "- o1"))
|
|
} else {
|
|
// Check lower-casing of tags
|
|
writeSource(t, fs, "content/p1.md", fmt.Sprintf(pageTemplate, "t1/c1", "- Tag1", "- cAt1", "- o1"))
|
|
|
|
}
|
|
writeSource(t, fs, "content/p2.md", fmt.Sprintf(pageTemplate, "t2/c1", "- tag2", "- cat1", "- o1"))
|
|
writeSource(t, fs, "content/p3.md", fmt.Sprintf(pageTemplate, "t2/c12", "- tag2", "- cat2", "- o1"))
|
|
writeSource(t, fs, "content/p4.md", fmt.Sprintf(pageTemplate, "Hello World", "", "", "- \"Hello Hugo world\""))
|
|
|
|
writeNewContentFile(t, fs, "Category Terms", "2017-01-01", "content/categories/_index.md", 10)
|
|
writeNewContentFile(t, fs, "Tag1 List", "2017-01-01", "content/tags/tag1/_index.md", 10)
|
|
|
|
err := h.Build(BuildCfg{})
|
|
|
|
require.NoError(t, err)
|
|
|
|
// So what we have now is:
|
|
// 1. categories with terms content page, but no content page for the only c1 category
|
|
// 2. tags with no terms content page, but content page for one of 2 tags (tag1)
|
|
// 3. the "others" taxonomy with no content pages.
|
|
|
|
pathFunc := func(s string) string {
|
|
if uglyURLs {
|
|
return strings.Replace(s, "/index.html", ".html", 1)
|
|
}
|
|
return s
|
|
}
|
|
|
|
// 1.
|
|
th.assertFileContent(pathFunc("public/categories/cat1/index.html"), "List", "Cat1")
|
|
th.assertFileContent(pathFunc("public/categories/index.html"), "Terms List", "Category Terms")
|
|
|
|
// 2.
|
|
th.assertFileContent(pathFunc("public/tags/tag2/index.html"), "List", "Tag2")
|
|
th.assertFileContent(pathFunc("public/tags/tag1/index.html"), "List", "Tag1")
|
|
th.assertFileContent(pathFunc("public/tags/index.html"), "Terms List", "Tags")
|
|
|
|
// 3.
|
|
th.assertFileContent(pathFunc("public/others/o1/index.html"), "List", "O1")
|
|
th.assertFileContent(pathFunc("public/others/index.html"), "Terms List", "Others")
|
|
|
|
s := h.Sites[0]
|
|
|
|
// Make sure that each KindTaxonomyTerm page has an appropriate number
|
|
// of KindTaxonomy pages in its Pages slice.
|
|
taxonomyTermPageCounts := map[string]int{
|
|
"tags": 2,
|
|
"categories": 2,
|
|
"others": 2,
|
|
"empties": 0,
|
|
}
|
|
|
|
for taxonomy, count := range taxonomyTermPageCounts {
|
|
term := s.getPage(KindTaxonomyTerm, taxonomy)
|
|
require.NotNil(t, term)
|
|
require.Len(t, term.Pages, count)
|
|
|
|
for _, page := range term.Pages {
|
|
require.Equal(t, KindTaxonomy, page.Kind)
|
|
}
|
|
}
|
|
|
|
cat1 := s.getPage(KindTaxonomy, "categories", "cat1")
|
|
require.NotNil(t, cat1)
|
|
if uglyURLs {
|
|
require.Equal(t, "/blog/categories/cat1.html", cat1.RelPermalink())
|
|
} else {
|
|
require.Equal(t, "/blog/categories/cat1/", cat1.RelPermalink())
|
|
}
|
|
|
|
// Issue #3070 preserveTaxonomyNames
|
|
if preserveTaxonomyNames {
|
|
helloWorld := s.getPage(KindTaxonomy, "others", "Hello Hugo world")
|
|
require.NotNil(t, helloWorld)
|
|
require.Equal(t, "Hello Hugo world", helloWorld.Title)
|
|
} else {
|
|
helloWorld := s.getPage(KindTaxonomy, "others", "hello-hugo-world")
|
|
require.NotNil(t, helloWorld)
|
|
require.Equal(t, "Hello Hugo World", helloWorld.Title)
|
|
}
|
|
|
|
// Issue #2977
|
|
th.assertFileContent(pathFunc("public/empties/index.html"), "Terms List", "Empties")
|
|
|
|
}
|