mirror of
https://github.com/gohugoio/hugo.git
synced 2024-12-26 23:11:38 +00:00
8b5b558bb5
Before this commit, Hugo used `html/template` for all Go templates. While this is a fine choice for HTML and maybe also RSS feeds, it is painful for plain text formats such as CSV, JSON etc. This commit fixes that by using the `IsPlainText` attribute on the output format to decide what to use. A couple of notes: * The above requires a nonambiguous template name to type mapping. I.e. `/layouts/_default/list.json` will only work if there is only one JSON output format, `/layouts/_default/list.mytype.json` will always work. * Ambiguous types will fall back to HTML. * Partials inherits the text vs HTML identificator of the container template. This also means that plain text templates can only include plain text partials. * Shortcode templates are, by definition, currently HTML templates only. Fixes #3221
220 lines
5.6 KiB
Go
220 lines
5.6 KiB
Go
// Copyright 2017-present The Hugo Authors. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package hugolib
|
|
|
|
import (
|
|
"reflect"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/spf13/afero"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"fmt"
|
|
|
|
"github.com/spf13/hugo/helpers"
|
|
"github.com/spf13/hugo/output"
|
|
"github.com/spf13/viper"
|
|
)
|
|
|
|
func TestDefaultOutputFormats(t *testing.T) {
|
|
t.Parallel()
|
|
defs, err := createDefaultOutputFormats(viper.New())
|
|
|
|
require.NoError(t, err)
|
|
|
|
tests := []struct {
|
|
name string
|
|
kind string
|
|
want output.Formats
|
|
}{
|
|
{"RSS not for regular pages", KindPage, output.Formats{output.HTMLFormat}},
|
|
{"Home Sweet Home", KindHome, output.Formats{output.HTMLFormat, output.RSSFormat}},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
if got := defs[tt.kind]; !reflect.DeepEqual(got, tt.want) {
|
|
t.Errorf("createDefaultOutputFormats(%v) = %v, want %v", tt.kind, got, tt.want)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestSiteWithPageOutputs(t *testing.T) {
|
|
for _, outputs := range [][]string{{"html", "json", "calendar"}, {"json"}} {
|
|
t.Run(fmt.Sprintf("%v", outputs), func(t *testing.T) {
|
|
doTestSiteWithPageOutputs(t, outputs)
|
|
})
|
|
}
|
|
}
|
|
|
|
func doTestSiteWithPageOutputs(t *testing.T, outputs []string) {
|
|
t.Parallel()
|
|
|
|
outputsStr := strings.Replace(fmt.Sprintf("%q", outputs), " ", ", ", -1)
|
|
|
|
siteConfig := `
|
|
baseURL = "http://example.com/blog"
|
|
|
|
paginate = 1
|
|
defaultContentLanguage = "en"
|
|
|
|
disableKinds = ["page", "section", "taxonomy", "taxonomyTerm", "RSS", "sitemap", "robotsTXT", "404"]
|
|
|
|
[Taxonomies]
|
|
tag = "tags"
|
|
category = "categories"
|
|
|
|
defaultContentLanguage = "en"
|
|
|
|
[languages]
|
|
|
|
[languages.en]
|
|
title = "Title in English"
|
|
languageName = "English"
|
|
weight = 1
|
|
|
|
[languages.nn]
|
|
languageName = "Nynorsk"
|
|
weight = 2
|
|
title = "Tittel på Nynorsk"
|
|
|
|
`
|
|
|
|
pageTemplate := `---
|
|
title: "%s"
|
|
outputs: %s
|
|
---
|
|
# Doc
|
|
`
|
|
|
|
mf := afero.NewMemMapFs()
|
|
|
|
writeToFs(t, mf, "i18n/en.toml", `
|
|
[elbow]
|
|
other = "Elbow"
|
|
`)
|
|
writeToFs(t, mf, "i18n/nn.toml", `
|
|
[elbow]
|
|
other = "Olboge"
|
|
`)
|
|
|
|
th, h := newTestSitesFromConfig(t, mf, siteConfig,
|
|
|
|
"layouts/_default/baseof.json", `START JSON:{{block "main" .}}default content{{ end }}:END JSON`,
|
|
"layouts/_default/baseof.html", `START HTML:{{block "main" .}}default content{{ end }}:END HTML`,
|
|
|
|
"layouts/_default/list.json", `{{ define "main" }}
|
|
List JSON|{{ .Title }}|{{ .Content }}|Alt formats: {{ len .AlternativeOutputFormats -}}|
|
|
{{- range .AlternativeOutputFormats -}}
|
|
Alt Output: {{ .Name -}}|
|
|
{{- end -}}|
|
|
{{- range .OutputFormats -}}
|
|
Output/Rel: {{ .Name -}}/{{ .Rel }}|{{ .MediaType }}
|
|
{{- end -}}
|
|
{{ with .OutputFormats.Get "JSON" }}
|
|
<atom:link href={{ .Permalink }} rel="self" type="{{ .MediaType }}" />
|
|
{{ end }}
|
|
{{ .Site.Language.Lang }}: {{ T "elbow" -}}
|
|
{{ end }}
|
|
`,
|
|
"layouts/_default/list.html", `{{ define "main" }}
|
|
List HTML|{{.Title }}|
|
|
{{- with .OutputFormats.Get "HTML" -}}
|
|
<atom:link href={{ .Permalink }} rel="self" type="{{ .MediaType }}" />
|
|
{{- end -}}
|
|
{{ .Site.Language.Lang }}: {{ T "elbow" -}}
|
|
{{ end }}
|
|
`,
|
|
)
|
|
require.Len(t, h.Sites, 2)
|
|
|
|
fs := th.Fs
|
|
|
|
writeSource(t, fs, "content/_index.md", fmt.Sprintf(pageTemplate, "JSON Home", outputsStr))
|
|
writeSource(t, fs, "content/_index.nn.md", fmt.Sprintf(pageTemplate, "JSON Nynorsk Heim", outputsStr))
|
|
|
|
err := h.Build(BuildCfg{})
|
|
|
|
require.NoError(t, err)
|
|
|
|
s := h.Sites[0]
|
|
require.Equal(t, "en", s.Language.Lang)
|
|
|
|
home := s.getPage(KindHome)
|
|
|
|
require.NotNil(t, home)
|
|
|
|
lenOut := len(outputs)
|
|
|
|
require.Len(t, home.outputFormats, lenOut)
|
|
|
|
// There is currently always a JSON output to make it simpler ...
|
|
altFormats := lenOut - 1
|
|
hasHTML := helpers.InStringArray(outputs, "html")
|
|
th.assertFileContent("public/index.json",
|
|
"List JSON",
|
|
fmt.Sprintf("Alt formats: %d", altFormats),
|
|
)
|
|
|
|
if hasHTML {
|
|
th.assertFileContent("public/index.json",
|
|
"Alt Output: HTML",
|
|
"Output/Rel: JSON/alternate|",
|
|
"Output/Rel: HTML/canonical|",
|
|
"en: Elbow",
|
|
)
|
|
|
|
th.assertFileContent("public/index.html",
|
|
// The HTML entity is a deliberate part of this test: The HTML templates are
|
|
// parsed with html/template.
|
|
`List HTML|JSON Home|<atom:link href=http://example.com/blog/ rel="self" type="text/html+html" />`,
|
|
"en: Elbow",
|
|
)
|
|
th.assertFileContent("public/nn/index.html",
|
|
"List HTML|JSON Nynorsk Heim|",
|
|
"nn: Olboge")
|
|
} else {
|
|
th.assertFileContent("public/index.json",
|
|
"Output/Rel: JSON/canonical|",
|
|
// JSON is plain text, so no need to safeHTML this and that
|
|
`<atom:link href=http://example.com/blog/index.json rel="self" type="application/json+json" />`,
|
|
)
|
|
th.assertFileContent("public/nn/index.json",
|
|
"List JSON|JSON Nynorsk Heim|",
|
|
"nn: Olboge",
|
|
)
|
|
}
|
|
|
|
of := home.OutputFormats()
|
|
require.Len(t, of, lenOut)
|
|
require.Nil(t, of.Get("Hugo"))
|
|
require.NotNil(t, of.Get("json"))
|
|
json := of.Get("JSON")
|
|
_, err = home.AlternativeOutputFormats()
|
|
require.Error(t, err)
|
|
require.NotNil(t, json)
|
|
require.Equal(t, "/blog/index.json", json.RelPermalink())
|
|
require.Equal(t, "http://example.com/blog/index.json", json.Permalink())
|
|
|
|
if helpers.InStringArray(outputs, "cal") {
|
|
cal := of.Get("calendar")
|
|
require.NotNil(t, cal)
|
|
require.Equal(t, "/blog/index.ics", cal.RelPermalink())
|
|
require.Equal(t, "webcal://example.com/blog/index.ics", cal.Permalink())
|
|
}
|
|
|
|
}
|