hugo/hugolib
Paul Gottschling 25d645f47a
Fix missing page data for alternative formats
When a template calls the .Translations function and a
Hugo environment is using multiple output formats,
a template that calls methods like .Summary and .Len on
each translation will unexpectedly show empty return
values for these methods.

This is because each pageOutput's ContentProvider is
assigned to a page.NopPage in newPageOutput. When
*HugoSites.render assigns pageContentOutputs to
pageOutputs in *pageState.shiftToOutputFormat, it
reuses pageContentOutputs from other pageOutputs,
leaving some pageContentOutputs as NopPages. While this
approach conserves resources, sometimes it means that
a template will unexpectedly call a method on a
pageContentOutput that is actually a NopPage.

In the case of ContentProvider methods called on
translations for alternative output formats, the methods
were called on NopPages.

This change introduces LazyContentProvider, which
performs late initialization when one of its methods is
called. This way, we can reuse content in "normal" cases
but ensure that ContentProvider methods work as expected
when a pageOutput is not assigned a pageContentOutput
during the initial pre-render phase.

Fixes #8919
2022-01-12 07:45:53 +01:00
..
assets/images
filesystems Make sure we always create the /public folder 2021-12-23 15:09:27 +01:00
paths
testdata Add some basic security policies with sensible defaults 2021-12-16 09:40:22 +01:00
testsite
404_test.go
alias.go
alias_test.go
breaking_changes_test.go
cascade_test.go
case_insensitive_test.go
collections.go
collections_test.go
config.go Misc depreation updates 2022-01-04 17:10:39 +01:00
config_test.go
configdir_test.go
content_factory.go
content_factory_test.go
content_map.go
content_map_page.go Misc depreation updates 2022-01-04 17:10:39 +01:00
content_map_test.go
content_render_hooks_test.go
datafiles_test.go
dates_test.go
disableKinds_test.go
embedded_shortcodes_test.go
embedded_templates_test.go Remove empty href element from pagination template 2021-12-02 09:14:30 +01:00
fileInfo.go
fileInfo_test.go
gitinfo.go
hugo_modules_test.go Validate private use language tags 2021-12-02 16:30:53 +01:00
hugo_sites.go
hugo_sites_build.go
hugo_sites_build_errors_test.go
hugo_sites_build_test.go
hugo_sites_multihost_test.go
hugo_sites_rebuild_test.go
hugo_smoke_test.go Add hugo.Deps 2022-01-11 18:06:23 +01:00
image_test.go
js_test.go deps: Upgrade github.com/evanw/esbuild v0.14.2 => v0.14.5 2021-12-17 08:26:45 +01:00
language_content_dir_test.go
language_test.go
menu_test.go
minify_publisher_test.go
mount_filters_test.go
multilingual.go
openapi_test.go
page.go Fix missing page data for alternative formats 2022-01-12 07:45:53 +01:00
page__common.go
page__content.go
page__data.go
page__menus.go
page__meta.go Misc depreation updates 2022-01-04 17:10:39 +01:00
page__new.go
page__output.go
page__paginator.go
page__paths.go
page__per_output.go
page__position.go
page__ref.go
page__tree.go
page_kinds.go
page_permalink_test.go
page_test.go Fix missing page data for alternative formats 2022-01-12 07:45:53 +01:00
page_unwrap.go
page_unwrap_test.go
pagebundler_test.go
pagecollections.go
pagecollections_test.go
pages_capture.go
pages_capture_test.go
pages_language_merge_test.go
pages_process.go Fix "stuck on build" in error situations in content processing 2021-12-23 15:09:27 +01:00
pages_test.go
paginator_test.go
permalinker.go
prune_resources.go
resource_chain_babel_test.go Add some basic security policies with sensible defaults 2021-12-16 09:40:22 +01:00
resource_chain_test.go media: Also consider extension in FromContent 2021-12-22 11:35:53 +01:00
robotstxt_test.go
rss_test.go
securitypolicies_test.go Add resources.GetRemote 2021-12-17 09:33:51 +01:00
shortcode.go Add some basic security policies with sensible defaults 2021-12-16 09:40:22 +01:00
shortcode_page.go
shortcode_test.go Remove mmark 2022-01-04 17:10:39 +01:00
site.go Add hugo.Deps 2022-01-11 18:06:23 +01:00
site_benchmark_new_test.go
site_output.go
site_output_test.go Fix surprise OutputFormat.Rel overwriting 2022-01-04 10:38:38 +01:00
site_render.go
site_sections.go
site_sections_test.go
site_stats_test.go
site_test.go Misc depreation updates 2022-01-04 17:10:39 +01:00
site_url_test.go
siteJSONEncode_test.go
sitemap_test.go
taxonomy.go
taxonomy_test.go
template_test.go Allow for return partials with falsy arguments (#9298) 2021-12-17 08:35:21 +01:00
testhelpers_test.go Misc depreation updates 2022-01-04 17:10:39 +01:00
translations.go