mirror of
https://github.com/gohugoio/hugo.git
synced 2024-12-26 00:32:07 +00:00
8b5b558bb5
Before this commit, Hugo used `html/template` for all Go templates. While this is a fine choice for HTML and maybe also RSS feeds, it is painful for plain text formats such as CSV, JSON etc. This commit fixes that by using the `IsPlainText` attribute on the output format to decide what to use. A couple of notes: * The above requires a nonambiguous template name to type mapping. I.e. `/layouts/_default/list.json` will only work if there is only one JSON output format, `/layouts/_default/list.mytype.json` will always work. * Ambiguous types will fall back to HTML. * Partials inherits the text vs HTML identificator of the container template. This also means that plain text templates can only include plain text partials. * Shortcode templates are, by definition, currently HTML templates only. Fixes #3221
127 lines
2.8 KiB
Go
127 lines
2.8 KiB
Go
// Copyright 2016 The Hugo Authors. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package tplimpl
|
|
|
|
import (
|
|
"errors"
|
|
"io/ioutil"
|
|
"testing"
|
|
|
|
"github.com/spf13/hugo/deps"
|
|
|
|
"github.com/spf13/hugo/tpl"
|
|
"github.com/spf13/viper"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
// Test for bugs discovered by https://github.com/dvyukov/go-fuzz
|
|
func TestTplGoFuzzReports(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
// The following test case(s) also fail
|
|
// See https://github.com/golang/go/issues/10634
|
|
//{"{{ seq 433937734937734969526500969526500 }}", 2}}
|
|
|
|
for i, this := range []struct {
|
|
data string
|
|
expectErr int
|
|
}{
|
|
// Issue #1089
|
|
//{"{{apply .C \"first\" }}", 2},
|
|
// Issue #1090
|
|
{"{{ slicestr \"000000\" 10}}", 2},
|
|
// Issue #1091
|
|
//{"{{apply .C \"first\" 0 0 0}}", 2},
|
|
{"{{seq 3e80}}", 2},
|
|
// Issue #1095
|
|
{"{{apply .C \"urlize\" " +
|
|
"\".\"}}", 2}} {
|
|
|
|
d := &Data{
|
|
A: 42,
|
|
B: "foo",
|
|
C: []int{1, 2, 3},
|
|
D: map[int]string{1: "foo", 2: "bar"},
|
|
E: Data1{42, "foo"},
|
|
F: []string{"a", "b", "c"},
|
|
G: []string{"a", "b", "c", "d", "e"},
|
|
H: "a,b,c,d,e,f",
|
|
}
|
|
|
|
config := newDepsConfig(viper.New())
|
|
|
|
config.WithTemplate = func(templ tpl.TemplateHandler) error {
|
|
return templ.AddTemplate("fuzz", this.data)
|
|
}
|
|
|
|
de, err := deps.New(config)
|
|
require.NoError(t, err)
|
|
require.NoError(t, de.LoadResources())
|
|
|
|
templ := de.Tmpl.(*templateHandler)
|
|
|
|
if len(templ.errors) > 0 && this.expectErr == 0 {
|
|
t.Errorf("Test %d errored: %v", i, templ.errors)
|
|
} else if len(templ.errors) == 0 && this.expectErr == 1 {
|
|
t.Errorf("#1 Test %d should have errored", i)
|
|
}
|
|
|
|
tt := de.Tmpl.Lookup("fuzz")
|
|
require.NotNil(t, tt)
|
|
err = tt.Execute(ioutil.Discard, d)
|
|
|
|
if err != nil && this.expectErr == 0 {
|
|
t.Fatalf("Test %d errored: %s", i, err)
|
|
} else if err == nil && this.expectErr == 2 {
|
|
t.Fatalf("#2 Test %d should have errored", i)
|
|
}
|
|
|
|
}
|
|
}
|
|
|
|
type Data struct {
|
|
A int
|
|
B string
|
|
C []int
|
|
D map[int]string
|
|
E Data1
|
|
F []string
|
|
G []string
|
|
H string
|
|
}
|
|
|
|
type Data1 struct {
|
|
A int
|
|
B string
|
|
}
|
|
|
|
func (Data1) Q() string {
|
|
return "foo"
|
|
}
|
|
|
|
func (Data1) W() (string, error) {
|
|
return "foo", nil
|
|
}
|
|
|
|
func (Data1) E() (string, error) {
|
|
return "foo", errors.New("Data.E error")
|
|
}
|
|
|
|
func (Data1) R(v int) (string, error) {
|
|
return "foo", nil
|
|
}
|
|
|
|
func (Data1) T(s string) (string, error) {
|
|
return s, nil
|
|
}
|