github/hugo
1
0
Fork 0
mirror of https://github.com/gohugoio/hugo.git synced 2024-11-21 20:46:30 -05:00
Code Issues Projects Releases Packages Wiki Activity

transform/livereloadinject: Don't use document.write to inject livereload

Browse source 
I suspect the person who originally implemented it saw examples using location.host etc. to build the URL.

We have all that information ready at build (static) time.

Fixes #6507
This commit is contained in:
Bjørn Erik Pedersen 2020-01-31 08:02:53 +01:00
parent 5859586453
commit ef78a0d18a
No known key found for this signature in database
GPG key ID: 330E6E2BD4859D8F
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
transform/livereloadinject/livereloadinject.go
View file

@ -59,7 +59,7 @@ func New(port int) transform.Transformer {
return err return err
} }
script := []byte(fmt.Sprintf(`<script data-no-instant>document.write('<script src="/livereload.js?port=%d&mindelay=10&v=2"></' + 'script>')</script>`, port)) script := []byte(fmt.Sprintf(`<script src="/livereload.js?port=%d&mindelay=10&v=2" data-no-instant></script>`, port))
i := idx i := idx
if match.appendScript { if match.appendScript {

2
transform/livereloadinject/livereloadinject_test.go
View file

@ -25,7 +25,7 @@ import (
func TestLiveReloadInject(t *testing.T) { func TestLiveReloadInject(t *testing.T) {
c := qt.New(t) c := qt.New(t)
expectBase := `<script data-no-instant>document.write('<script src="/livereload.js?port=1313&mindelay=10&v=2"></' + 'script>')</script>` expectBase := `<script src="/livereload.js?port=1313&mindelay=10&v=2" data-no-instant></script>`
apply := func(s string) string { apply := func(s string) string {
out := new(bytes.Buffer) out := new(bytes.Buffer)
in := strings.NewReader(s) in := strings.NewReader(s)