github/hugo
1
0
Fork 0
mirror of https://github.com/gohugoio/hugo.git synced 2024-11-21 20:46:30 -05:00
Code Issues Projects Releases Packages Wiki Activity

Use pooled buffer in replaceShortcodes

Browse source 
Even as a copy at the end is needed, this consumes way less memory on Go 1.4.2:

```benchmark                           old ns/op     new ns/op     delta
BenchmarkParsePage                  145979        139964        -4.12%
BenchmarkReplaceShortcodeTokens     633574        631946        -0.26%
BenchmarkShortcodeLexer             195842        187938        -4.04%

benchmark                           old allocs     new allocs     delta
BenchmarkParsePage                  87             87             +0.00%
BenchmarkReplaceShortcodeTokens     9424           9415           -0.10%
BenchmarkShortcodeLexer             274            274            +0.00%

benchmark                           old bytes     new bytes     delta
BenchmarkParsePage                  141830        141830        +0.00%
BenchmarkReplaceShortcodeTokens     35219         25385         -27.92%
BenchmarkShortcodeLexer             30178         30177         -0.00%
```
See #1148
This commit is contained in:
Bjørn Erik Pedersen 2015-06-22 19:40:12 +02:00
parent 67209dbfb3
commit e764a6e638
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
hugolib/shortcode.go
View file

@ -458,7 +458,8 @@ func replaceShortcodeTokens(source []byte, prefix string, replacements map[strin
return source, nil return source, nil
} }
var buff bytes.Buffer buff := bp.GetBuffer()
defer bp.PutBuffer(buff)
sourceLen := len(source) sourceLen := len(source)
start := 0 start := 0
@ -507,7 +508,11 @@ func replaceShortcodeTokens(source []byte, prefix string, replacements map[strin
if err != nil { if err != nil {
return nil, errors.New("buff write failed") return nil, errors.New("buff write failed")
} }
return buff.Bytes(), nil
bc := make([]byte, buff.Len(), buff.Len())
copy(bc, buff.Bytes())
return bc, nil
} }
func getShortcodeTemplate(name string, t tpl.Template) *template.Template { func getShortcodeTemplate(name string, t tpl.Template) *template.Template {